From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B68376A03 for ; Mon, 13 Jul 2026 15:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783955547; cv=none; b=a5t4+v0txmZNILlDwxeXYZajCvM7ZeOC+1CUNbNoHeF2JTCnJPuU1NiwWALdYr1PJQhhibAb3RLU3WiJ9Y0kgnPNjK0xQMXYWSHXPV7y09uX2q1UgXWhMylGri/EnuS35quUE+HkhLqGGh5XsOqeBTGdSskjEh4ew4zzwy9Z0U0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783955547; c=relaxed/simple; bh=sfNhb2R8s/6yKt4BPY7jMkwV/kl2zg5+s7lGbts3IxA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ROeKbgmZ8mb2f/2xI81EBHwkwMONdudsagc8oRTIJRlOoIm+jANYnEOvItax+aYxUseYb6Iei062d5QsBXFmpGwbgX7dNbmcfJZnRybP90fnCH1BY+NAdmCUg5oOZIqYVUUd+3PAHOuskLZLfS2h+Wpsj0Tf26h99dVjdSxYb7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fk86STtQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QLflJ6wN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fk86STtQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QLflJ6wN" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DF8Dip1611664 for ; Mon, 13 Jul 2026 15:12:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tVr5dRf8jqbsYQUjS230GnPY/TS/CzublqdJwnQejdE=; b=Fk86STtQkF1LD7T2 ihKoY74MW02xYdI+Hk3AArC5I0aBw72cFqVeGI6Qn8XQQhNBU0PXYHompsgzaeFO 2f5Shemhn0w7N8qTh73P3HxuvpxIPIc7IO7P3fGWCLhJtxk3hTbbF5Hi4yXOidRJ TDHh7GdjVbHV8TClwkoNhrFuT85q33+B4g2JcX+jWsZKVK1YEntkXo3tWFJfoj/c VmavKg0PZKQyc6jo+rv+aROR5Jq9ZoWmwWPXP0uSYzKAUw6h/XL0TfbxPJHtGeDb p0wsm7xkr1uKryrOjfPYsdr74QXrkPGe9+jAr4yDumT/5JVLL8eCd21QyhARa5jt gzpijA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcw4qsdpt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 15:12:25 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c0e702df8so36159491cf.2 for ; Mon, 13 Jul 2026 08:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783955544; x=1784560344; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tVr5dRf8jqbsYQUjS230GnPY/TS/CzublqdJwnQejdE=; b=QLflJ6wNydjb9dBEQs91slzDDVmWKoyLc7hLU4LWqUBFptKHk0VYVUTiLRo/md+596 ALj7LzcmMoYK8bUIanroGG1nnaaFaRjjy9pCtTm2blAvkTY7JfDvS0HWnA9bbKuHxbOi pT7TiMqNhbUqGEoZzUwDG+HBkl+7u/l0y2znDuCQBgvnZ7FyKON90ILRSuTEynb4wsa3 avNk66l9bLj5643v4EFPFZ9vQLsrA9Fa4lLgzGz5lJpMu7gKdNEQOD7lMf5lS1Gn57pQ Ew8BFo33Jw2KnvGpqOVx8kFdC8mknPCEMpvoOw/3OQX4uGqPeBSLidqn0MtMeWUebXka FDog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783955544; x=1784560344; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tVr5dRf8jqbsYQUjS230GnPY/TS/CzublqdJwnQejdE=; b=DPQJHSSceHz9GFvFyCCU2tE08zIJioKGGjP4Vm6t1BUYn9Jzvu/9BTXWuDN8v8yk0x Piy9C7aE7AMSh8gSFVu/a98wBS2pP66KY7Z8oNE/FtjATz0aRLKyPktfwtsYSEqc/aZ2 ocEIo9eoVDo5J1IWQNevwAyJNPU0cyhaPXLA/AiORx1CfDezrnLTqkkuA5EsKEvYR7t6 dVUz3KCvzq0TKBEt4x5tTeMN3RcotpSDcM87+KNBuJTcRpMPwAggNLoJn8mMUQtOWqWS EnTYP1C2QzeTI6vTmQQj3d8d9OUwi52wE8xSC4U0eauPgAqZsaKVVk8UiEqxOa6knlYt rNEw== X-Forwarded-Encrypted: i=1; AHgh+Roj5B5fpa+L0JkqTwSTe3WTuPkKgWCxQjO2G4anADu/0dgRQNnaasGhzS9li/tWExkEGonFNE6uPgBkAiU=@vger.kernel.org X-Gm-Message-State: AOJu0YysMcy67DOS1LPgXg+rr4G8RNRhMItV2fTOtYSg/ZvbkCWKLaeB MZjjy+PgVtKz7vBUIZJ8w13+RjRDo+CWANqE+lxugZeYUicU34wUu5Q1lTuAMY7F4u7sVfGvL97 NcMP1b0p6KFUNxYij07Ejaw7mWhO9TGMmuRKa6eS1Hs6SpkDf0CmrJ/aWYrHtlBxlN58= X-Gm-Gg: AfdE7cmIlnhu/TaBqPZDCZlP5lv1R1LY0F1j8s1KS+zKLo9PWSWDaoC/2eMv4FYn5eY Mz5AFa7TZUm4rNK3+SoyAuVfurLGAtoWyp/IW6pzkkeDaiEwI9Mth78GQxCFEESBfaXO7UELhNa 82YzbUo1W248Gunwgne/ySUJ9rFWc0O26mFNhWKOJewuVuOpZ3WQ3Y/F/OhGtXcdXDG4Gf4yCTD jOaT1kEMcJIC53+hvA1/pXr5MldqTU72rEXkHI3MhA1rJMSk2OKXrvCQM6Xig67BthqdkNftcta wp2MygM46Gdh45j3bWewRsuRRglxbVY4N8WMKzbzRtzVIhrzlkAdt8s/6p40Zo2J4KGtfnmt6kt BDgSv3MiQi8iGj9lX2ez2xsEdPA4feq8WcY/BrLLw X-Received: by 2002:a05:622a:38b:b0:51c:11aa:1cd with SMTP id d75a77b69052e-51cbf20254cmr92718671cf.50.1783955544107; Mon, 13 Jul 2026 08:12:24 -0700 (PDT) X-Received: by 2002:a05:622a:38b:b0:51c:11aa:1cd with SMTP id d75a77b69052e-51cbf20254cmr92718121cf.50.1783955543604; Mon, 13 Jul 2026 08:12:23 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:8881:83b8:89fa:1a2a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0a558easm87956664f8f.27.2026.07.13.08.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 08:12:22 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 13 Jul 2026 17:11:59 +0200 Subject: [PATCH v7 3/4] driver core: platform: unify release path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260713-swnode-remove-on-dev-unreg-v7-3-6d6bc448427a@oss.qualcomm.com> References: <20260713-swnode-remove-on-dev-unreg-v7-0-6d6bc448427a@oss.qualcomm.com> In-Reply-To: <20260713-swnode-remove-on-dev-unreg-v7-0-6d6bc448427a@oss.qualcomm.com> To: Maximilian Luz , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Cc: brgl@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, driver-core@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2372; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=sfNhb2R8s/6yKt4BPY7jMkwV/kl2zg5+s7lGbts3IxA=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqVQBMkeWmMCvmewYOj8J1fRY0qezWMr55m63rs XwMM+Ug+rKJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCalUATAAKCRAFnS7L/zaE wzJ3EACVzej+VwkeVnB5DJG57mn9yd2KIxtjlxZdjJi6jk9SdHkz51frdxdmaZB0HOwIMjI2qT5 QHx9D0OiS7SLaC0Soqt7lOgyXIiFNJ3dHECznM2oladKUsTzLOOJZv3dDPkWajJOZ/5Dpdn3W2+ 8Yj7woq3cc+2xy7F68zqec9f6piDO61ZOCiRoKoOwN5F/fzmA5roxFCGMXG0kTnJC3qLYli9Rtq ksRRiLQ4xSLXtBNTFrmlGbUefn3GxekVpbQDhTko0LXCi4100tXUrJRrcLGsDIvy3ZyCk323Dtn s+uAezDzW5w4aZumcwTOigoEKb1PMuohjhcQuaz5WbNEk3QMi3GyrDCsHfZZeIavvh44UABOQjZ MVcgMuX12ZhA5O6Ipz1E1oXcMBq125MGO6jYWFgjg/kkZoGTtIJUYNReui87wI44rZJP9/+MiSr BPu3kKxS+ZOt3xODnlzmZJMUKsh29Zn7Q7RArB1VZ1hGE967gtxGtZjfmx8BwTc49nePXooofYl szN2ZI1weWNzzvJMWq5UruQuQyOg/7aNXQibTBbv4NrRgpUDEp+KaJx95KZQldPB1iD2FReuLwM VpVjW/B3/McT3NZ+PTzJ0V4eOXZqA+6ki+rt473xmMUbEctWt5M+/uorPc2rBL7DoioEyTqR3w2 Zio/n6wszuIIiwA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDE1OCBTYWx0ZWRfX+r2UytWgfZ0h IhbAf4T16cbISFTWKaWutAW7v309GNtQDA3o7xLgm5dei6bv6qN7ROFVpSpgrKoFjicr+Q+lCE5 /rEjcchigB87L/OhzO74n3edFNj3CC6t+1LcT0PQVGCtkWDb3GeX3hLmBT12YPY9rhRdexTlUeM 85qcGyIicBCYLDa46KmNLxpwdvpvoW+Y2iYSeBtXappPfmmB0QfcaTzKVUMCJkzegJrx/igdREL IJ33rYB5SFIuJ8D5tcyLvXms2jh6AezTCXSqCv+5HUnqKErzwkfbGdhwOaV2QDG/giIWWU8pAKz jS8gkL9cENzffmTk6YHrkBpCeGgxgFY59BQ0hUEuSpSt5I1EpRfwbSfpO/BEnhY8T7bDh21w3tP p5VhYDlJwHg2EBTqP7hZh+PvobMsj50crke4JpZv9GLmuUQwNBPSRRTbI1TzAG3cy0jJXRxhQsb JxAsafUXxrtOLVtR0QQ== X-Authority-Analysis: v=2.4 cv=HJrz0Itv c=1 sm=1 tr=0 ts=6a550059 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=hkyMZWt8Xm0hL-3MNhcA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: dGc-dQefq36050VZjVIEVEfpLKmnpcjE X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDE1OCBTYWx0ZWRfX4WYfKTCelAbV RgoDLa6DEIqsZB+9cOGw4PCVjhhzIDrssHqT6/cl/C+GjCWupKmI/7o+gzlVGMtO6w+mKK46Csr cBZ6vlW47Zg2jAbR4EXtlpyU7P46mH4= X-Proofpoint-ORIG-GUID: dGc-dQefq36050VZjVIEVEfpLKmnpcjE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_04,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130158 With no drivers that manually assign software nodes to platform devices created with platform_device_alloc(), we can now unify the release path and remove platform_device_release_full(). Signed-off-by: Bartosz Golaszewski --- drivers/base/platform.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index a71015f1d915340aa01ebfae67196d4d7ccecba8..1df1a9ebd59ca6e0efdcd4038b100bebe224ee82 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -599,6 +599,7 @@ static void platform_device_release(struct device *dev) struct platform_object *pa = container_of(dev, struct platform_object, pdev.dev); + device_remove_software_node(dev); fwnode_handle_put(pa->pdev.dev.fwnode); kfree(pa->pdev.dev.platform_data); kfree(pa->pdev.mfd_cell); @@ -606,12 +607,6 @@ static void platform_device_release(struct device *dev) kfree(pa); } -static void platform_device_release_full(struct device *dev) -{ - device_remove_software_node(dev); - platform_device_release(dev); -} - /** * platform_device_alloc - create a platform device * @name: base name of the device we're adding @@ -933,6 +928,16 @@ struct platform_device *platform_device_register_full(const struct platform_devi pdev->dev.coherent_dma_mask = pdevinfo->dma_mask; } + /* + * If the primary firmware node is a software node and there's no + * secondary firmware node, the primary will be affected by the call + * to device_remove_software_node() in platform_device_release() and + * its reference count will be dropped by one. Take another reference + * here to make it have no effect. + */ + if (is_software_node(pdevinfo->fwnode)) + fwnode_handle_get(pdevinfo->fwnode); + ret = platform_device_add_resources(pdev, pdevinfo->res, pdevinfo->num_res); if (ret) goto err; @@ -945,8 +950,6 @@ struct platform_device *platform_device_register_full(const struct platform_devi ret = device_add_software_node(&pdev->dev, pdevinfo->swnode); if (ret) goto err; - - pdev->dev.release = platform_device_release_full; } else if (pdevinfo->properties) { ret = device_create_managed_software_node(&pdev->dev, pdevinfo->properties, NULL); -- 2.47.3