From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541561A9F8C for ; Mon, 13 Jul 2026 00:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783903489; cv=none; b=U31Xw4+9E6AB7IUWdvqOF1txImxuRcz0HuxZJ8BDadEi0SfbmbFfOIambXDjzLG0QyyochpPYrvq9AM8gQLF/1YKWAJ/eoNdjiFkE4q+82hr4qOkUqM02vXfYJ1hol0MC5IvAvT6RpsKvtUF51FyVxxF4hmT6NNFs+cI5hrsDWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783903489; c=relaxed/simple; bh=cVrP9LbImd/DLV4exAMspuFQjCFkyTv6E9ZIoIh5ps4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nN1UdoxOB7eqHlzJBHyKgCzxYLR2CN75rYst5jY9l3ELagkVO9Wc4j4pwLwZPFAZlOWbbcNioPZS/9g4xJWV9UUNZdhxYanD7LP0f2wetoL6D5mBkLmrVwSyr5XehMWknVac6PBr6klRv1En3cDgxOsiNr5nkKHXVv0fGxfXhoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BoU7XLjC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=evCHDaXM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BoU7XLjC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="evCHDaXM" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66CNU8Bb3966713 for ; Mon, 13 Jul 2026 00:44:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HqqOZmOmVi+XVHlGNma//JaIAhFplFOGhvKHJnsNboM=; b=BoU7XLjCeb81bmb4 xY5AjjBi9KplMXSESgivsvrUzAoqBq1VHtVtwdBKdDWb1+h+H3Mw8tI70d0tagEH lkshQFJHTOo+z5Br00B+M3P4xqHZd72jKAQv7X9fAc+ZF9LFhkIvwmjrN+5TdLnr IMQShCT77k09CVxOYIW2JNKIfXOw+i6ptpVk5j9W3OanVa3t5ZViR09uSQLI1YP6 bDPTkQwbafMCzNmqSZ0n+at5A9l0XjpSYDHgQ6Ke1Il2SWNwQHCqqWTyUqNcjc6N j0Vs4XMMA2ROp88jrwj29ZY24XzzBE4dkK/swSgzDRNgBFaVilkgIZd2okQc6S2n /bu1Ng== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbecgkuct-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 00:44:47 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-388b404eaa4so3407899a91.0 for ; Sun, 12 Jul 2026 17:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783903486; x=1784508286; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=HqqOZmOmVi+XVHlGNma//JaIAhFplFOGhvKHJnsNboM=; b=evCHDaXMfzTiAuJOAjd02nEjWJNgMtMX+WsNDCPt4GmdPo9Kn8a3YLhgQb8D1z/3Yt iisGt+ampg2NxyPViuHoUGBaulbAFKmGxYlI2AUoaN1hH2kAQ+DQpVfWJ9ZOJuKDcqlp oWLJV7Eab/wiuEiPfIveoqQW+3cY3xYvKoDg0ig2qOKVIehTG6/IidWtwqtXXfZkKphJ Td5u8k7v67vqFHKa66VURG4KHpvMzMPYacKcEfz2neHf/qWnfBRO+aXB0ISxGWFKLfdL 5uVGCOkdQFZLYO8SGHQ/V5HWe5SI1aERgiRPuBcs1w0TpbF1h89zn6SMZS4hITIGojvG 3yqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783903486; x=1784508286; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HqqOZmOmVi+XVHlGNma//JaIAhFplFOGhvKHJnsNboM=; b=o66svSPgCxvPTazIiyrGDGTLox0LI0zUzaWhwZqGqhUgEkPAqSvWqpOAmZ5asQbdnI Kmt5GeMoN7mXPl6tc86mnx7kQbunfDBQ8sXSeqgY+7fXWQw3S8lzwYU+ZF6HUOiQ6kCN gB8u8mdq7gdsRFhsMVc7gtKKsJsTnoijrFBrZ+uhkv2aMModqsmGys8RK/1Jc/vK4Bbm xWC12CnU0s5Y5Rvg5MhLmoluL8Dc5HIQ4zP+falJ34qsbBnlFuhsF/PpBd77oSTj42Rj nBO+/hhCF4+UUX/1Dd9OWOadPm4/rzCDZWfs5x5diI83IWwX+F7CbSq9BlRNqZZzPXUo Ucow== X-Forwarded-Encrypted: i=1; AHgh+RrrKTkMVng5aj/eoql8CPkzG6IydgftYBsQP0h30DbCqiVo16pjB1QV24hiEw5xfuawExwmHJHMYItMLGw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1a7OB6sOB5vjt3q8kCQGsWeHVZa9/UxUilg+MsU+RZpDv+bjd vLqOggkAyr3Oh3MVqickw3hMicBeFE3j9cbPgTeDnOWAaS7UioVb9ZIm62YerWHqb08+ecJ7WUB UqZSOGkot7wXKoQ8nicdcZfAShDBAjcD/yGrFj/JipgpAInqUe/zJ7ogV2SXCc9l1dj8= X-Gm-Gg: AfdE7cltY3Ka1UU4OMMLc+g0AIVJ1gzL8fKpVbJR4BebscH98FtcZOY+UCKyPBK45OV fx/nkM6aXWjDuG0zhKXS8SJsrzCz6iQpb+KhWwBGaZVV4e26PM2xIDnv59glfIkMqRhVFNaE9im YZrrCCKHADx77lPTPG1DL4LZctLs8uKSTmGUtD8gOreGDE1eb6P165DNEol8T02/Hl096rjn8yU SHOR2Bol8v4Q4qush76UHfkSMTD5KDLjStCoa7i3kDZhIP19bPBFnPPRvDKD1EHgqp0AZazy/na RtDyjC5ZN2yRayxM3dUIWQMUUBPYWQqgR8jYNxPuC+XGHZF85R9F7kt9avFDY5NEgNr4s/Yrz+A A4eQE5WTODXAC2kehs6JDx+KP1i8= X-Received: by 2002:a17:90b:1dd2:b0:37f:bfa2:1887 with SMTP id 98e67ed59e1d1-38dc75d02a1mr6837496a91.8.1783903486182; Sun, 12 Jul 2026 17:44:46 -0700 (PDT) X-Received: by 2002:a17:90b:1dd2:b0:37f:bfa2:1887 with SMTP id 98e67ed59e1d1-38dc75d02a1mr6837480a91.8.1783903485743; Sun, 12 Jul 2026 17:44:45 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a55b3c9eesm5689729a91.11.2026.07.12.17.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 17:44:45 -0700 (PDT) Date: Mon, 13 Jul 2026 01:44:42 +0100 From: Jonathan Cameron To: Nikhil Gautam Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/4] iio: light: opt4001: Reject integration times with a non-zero seconds part Message-ID: <20260713014442.612ed45d@jic23-huawei> In-Reply-To: <20260712202451.20822-4-nikhilgtr@gmail.com> References: <20260712202451.20822-1-nikhilgtr@gmail.com> <20260712202451.20822-4-nikhilgtr@gmail.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDAwNSBTYWx0ZWRfX+7U+EdDtfxcd wMEi0KiATzduaxhGWPmgNbzoradblnNCyNybzm5xugsRQWyl0iY5fd7TjDDOL4c20PrxRyKCOAv ylWoWuIgsG9WwQvjHo11NUK8BWf+7Tw= X-Proofpoint-ORIG-GUID: HIHFIF9VHkrtoFUT_szJAtLSIVKLVMZA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDAwNSBTYWx0ZWRfX+nr2U3DYcYoq ZXxG12hPtOaqtcKwQaCsqPRxLvwsc9fDRCSHA+VAuZ0WMSz/jG/tt8bRlMX9hVv4PRK1Vs1jCBI Hd3nDbBg7/MJrc3rhDUscnDXZrBi9XD2YoyDgHDI14Di0rPXzWd5rHfON5PRZ1fQjtFNADM92pj hnYTNmZUSAZPcW11+VXXGDailmla6GNhEYnrww+b6p9S35j1fLFIUibe9QxqrRWXDxDxTLpZbtt w8Lo/6/nI2pomBotDwREe+TQ8HreTVbkw0mtcDdKVMXWB12lsIxKG3NL4e1+wujMqXQxxj5+Wqf ZgYQUW9/X5XHChEYfFk0RWiO2OwLP73FM/02T1yOHSXo1ufIbmYJlfDEwcnQOxltVLezQeBnWT1 DfQsZ4tImOv5t+4yyim2iIlBycDFx2TVSfbVLW8naPuY7SvWQieB8S4M9iZEU9/CF1zviuzaWnR +ym/W7pJoveFodpkskw== X-Proofpoint-GUID: HIHFIF9VHkrtoFUT_szJAtLSIVKLVMZA X-Authority-Analysis: v=2.4 cv=KM9qylFo c=1 sm=1 tr=0 ts=6a5434ff cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=pGLkceISAAAA:8 a=UBEt2JK6THHEFw8g2C4A:9 a=CjuIK1q_8ugA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-12_08,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130005 On Mon, 13 Jul 2026 01:54:50 +0530 Nikhil Gautam wrote: > opt4001_write_raw() only looks at val2 when setting the integration > time, so a write such as 1.000600 is silently accepted as 600 us. > Return -EINVAL if val is non-zero. > > Signed-off-by: Nikhil Gautam Fixes tag definitely makes sense for this one. Good spot. > --- > drivers/iio/light/opt4001.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c > index bdb1eadbd450..31a5397926eb 100644 > --- a/drivers/iio/light/opt4001.c > +++ b/drivers/iio/light/opt4001.c > @@ -288,6 +288,8 @@ static int opt4001_write_raw(struct iio_dev *indio_dev, > > switch (mask) { > case IIO_CHAN_INFO_INT_TIME: > + if (val) > + return -EINVAL; Blank line here. Otherwise lgtm. > int_time = opt4001_als_time_to_index(val2); > if (int_time < 0) > return int_time;