From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20F2078F3A for ; Mon, 13 Jul 2026 00:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783904007; cv=none; b=Z4gFz5pfSbK5v4sCPIjIlgmyfAYafUsAMYAFOBqSnuhDdGdGW6IUIYlY3lTa07mfONIoI4sZM1Ol2mAGhGcV3bLGZj+AA4cGnEPbkbgSsxUtBEgIb1IY1XZTl0T7SJjUjYhI0xbsutS/aa5hGsHg5UssxHBA/m8265pM0rJhoDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783904007; c=relaxed/simple; bh=NOKl/2FsOpUDU2KR3IEXpajjEC9SS61hl/FuBauFTR8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KWMm0MPx/kaH/nDZcS1+cYxmY12Z1paH/4nDZl62qn5NCSvrgaK+mUKXm213fPeFa3aF8R5/xKWQifrfHqc653nkM+rFNEZBkF7B1tjM2ytiDQGyWEeMzZGP0iut7jzhFb8EHe4Z7fRaWG/xYoHnxsjGzmnvpcUMkn4hDCtaQVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TT3IifZE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KogstQxf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TT3IifZE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KogstQxf" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D0kBTL4098419 for ; Mon, 13 Jul 2026 00:53:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DEm2NjDElLA5IULCO3hBWJcbnNmUCSWVAsvH9Q8gQho=; b=TT3IifZE/S82HA3Y 3JuAlGTQdPPBpkKjpAlT3CvkbEjR712B4AXnFZNCUfJUS7n7lIxF5uMcxdK2k9bK TMM9FNoG3A5ofatc+ejoE1TCQW8FBsumt7yik/ncW/AecFWl/05hHpA9zb6BDIQU MyFS4Iy1ZPeisC1BSV/EhK5ySagZlqacFJjSM9Rg6nzfpXlH9LuOi7TXmglQ4tPY xHuo88o+lrLXi0X6TLT9UfmC3XbGFusGkMD4N57sn5vAhEI2iK0HY3hr5Uvw5J4e Pjlk8hA3XuX2ARurhp1CqSm7qQtYT6fkVPfja5Cacjc2NxNkgm5Ic8g4AdygkIqC Vq2nAQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbebr3qnb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 00:53:24 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c88fc985a65so2013323a12.2 for ; Sun, 12 Jul 2026 17:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783904004; x=1784508804; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=DEm2NjDElLA5IULCO3hBWJcbnNmUCSWVAsvH9Q8gQho=; b=KogstQxfaCVUVP+Bdx9LBtUG7NT1ieGsJZ9Qy3AS3NfIl68mLeH3pnNnUVATfiG1hZ sF5kPBqvjh1iipZnERsiW7meVuqhMijusmNdRyEkfCBmQtm5S4j1kdzmY6u/3BxGRKUh NkphIB3/nW0x2WNTiuF/c/ymkzkueszTLO1ET+oBeoxhD66XoR3h+JNgkvSVWwwikRqu 2hC6CzYaM+4q0/AvdOO4AK2rQHhmYIgzACNYT3admsoj70DfZJv3JEaLnZFD3CeuEk36 AxAZDbabCL01NxCgS2J09zMyc9wFyuOTRZ8kJwjlsNkHm1dHFBx8p6T5vfb1W+lCNoY8 GcRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783904004; x=1784508804; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DEm2NjDElLA5IULCO3hBWJcbnNmUCSWVAsvH9Q8gQho=; b=IS7v7FNNAD5kV2oa10tVdRKGVJbbBnXLu3v0UCkkHGnLVWgv1rGX0P0zmMdhhTmnFY 89hP+7xTe/2H9j8rgqpkVUJJvrYS64bICPDzPCEAqHO5vJYXkqGUQJjDbBOuro+XkuyI wrS+AZPz1i8m6ISyUi1q4SVXBP/IdKWOa80xx025yKmmTHq6o2CuWkxCu4I3Xfv3Xsbn VQwnY0dq+QVAdRXwRkJx8hh/T+ugcSZR2h6oJXVz5/ObEb05C91Po247E+kG/e8iF4pC dY5NDAD/9qecpBZdQ0RyxE+R5cq9nCFH6d2jxfSV5TxRShmmUOkOSyTwElRWHAv8bsKk hdZw== X-Forwarded-Encrypted: i=1; AHgh+RqitT8Zdl53p4qWNnJNgnKKvKEGD7WPf0zni31fJCrGV+K4hjK8ZRgF6GMOU0qfGWkbnq7flM/901dlu/U=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwe97t6SeHeVZTdhZVs5m22Y1yuoD1ysIY321j/q6TMd2EzOEW tq+3LreoUIB46VnktcQJjiOrNhH1NUiAyddm+oLeI+RCssspILepGTMeDHfbP5YPMPswpGb4txn s+jXCW6lklIqKIrS4oApY79lgABFlVtj1gRvfNOTCh5VWJrA+FUGoeXQaK+1k/bXMebI= X-Gm-Gg: AfdE7cnhOQPvwd119Ch+VRac6sSaZZHJMYLDymu/gfaPAp8DGx2ZDOkO9Yphf1We17B RxajRDhnoJKV/1bTAJ6IeNpXb9xbsknArWiYppIZdjhjP6o2TlJK0pIXI/1udf4amS3JGOBBNKr 5YEZ6cPma7lqFy/lFDVPL3U2r+a7VfPdmZLfdiiTdTnD9RWo/umCln8+UBJUvwNUsWq4zr9wUNn Iy+pP+HhbypA/g5LHohIgA77BYSOnBtAJ7T5MOutYuqcun0ePDeRojGwA8f2gyi6XodxBrvaXiw yG/zYoyy9w4orURylC1/d7S/zbVTdqbv9agUlPz9akIPy0h+1Zn1jhO5vBgoQVmQ373hUjHqzbS yf/NPa7WYz1jbacPQlW+QgDLYAcA= X-Received: by 2002:a05:6a21:b8d:b0:3a2:d316:de53 with SMTP id adf61e73a8af0-3c10fb70319mr7960290637.0.1783904004305; Sun, 12 Jul 2026 17:53:24 -0700 (PDT) X-Received: by 2002:a05:6a21:b8d:b0:3a2:d316:de53 with SMTP id adf61e73a8af0-3c10fb70319mr7960265637.0.1783904003876; Sun, 12 Jul 2026 17:53:23 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3162b59sm7525127a12.16.2026.07.12.17.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 17:53:23 -0700 (PDT) Date: Mon, 13 Jul 2026 01:53:20 +0100 From: Jonathan Cameron To: "Maxwell Doose" Cc: "Joshua Crofts" , "Tomasz Duszynski" , "David Lechner" , Nuno =?UTF-8?B?U8Oh?= , "Andy Shevchenko" , "open list:IIO SUBSYSTEM AND DRIVERS" , "open list" Subject: Re: [PATCH] iio: chemical: scd30: remove kernel.h header Message-ID: <20260713015320.10153605@jic23-huawei> In-Reply-To: References: <20260712164225.358852-1-m32285159@gmail.com> <20260712185237.6a60e112@systembl0wer> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDAwNSBTYWx0ZWRfX+EnsNIDnAgLf yqXWlru6Fjaq5sk7UacEvmD+moPf1Z5FSDeyHmouIMCWZCsGtf2e9h2r84aHyvBnMamVOPRUiOE UDzzbOxu6afyIC5vqXPye7PdRbn9YbY= X-Authority-Analysis: v=2.4 cv=OK8XGyaB c=1 sm=1 tr=0 ts=6a543705 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=c92rfblmAAAA:8 a=pGLkceISAAAA:8 a=OOtRYDRuGAbdYZyHC38A:9 a=CjuIK1q_8ugA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=GvGzcOZaWPEFPQC_NcjD:22 X-Proofpoint-GUID: 7v7SUcXyDQpVnTkC8GTIhbP43bH-R_-G X-Proofpoint-ORIG-GUID: 7v7SUcXyDQpVnTkC8GTIhbP43bH-R_-G X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDAwNSBTYWx0ZWRfX6EFMqMG6v/MV rOD+NqLEWxmxB8l6hKq7zaSpTL2+ycpHXPZnx9MzvjH6Pxok5/e+NhTvJj6STkcxzGp9NskdYNs Ujg65i1EpqfWWII9avY++nM3Ze03jmdnNOHae30cZ7GEcruA/K4MM2s/Lt/aooPDJ7ViKxjaXyZ cDoSsA7Cs8IHxx1hL5hISJBe77QPdZ9GnbHdPWZeiYNKWyFCDbcUHU5FYUba5r0XbwJD/d/hTpa GYAPd8760YTCW/pv8uQ28mGhVszA0H52hR+cfhtoQnbUF3YBURDk3Z/lwRJqhn+DgJ93lBCVYba F8kLnlTM5Ilvj4IQf8vNm235wyG+SH6PIEtBm8Bj2Dpk55LSGpG9XejFme93q1uiUeHoSWXKDqx 8V+j7C+Mxf14A6sRfvEyRcGHskOgMAwHkADBLNmAA13Vk3Tbn8R6EpyHtqDma+43oPJEsK7P2Bl 2HS6D9h9+MeeEP1aBzQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-12_08,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130005 On Sun, 12 Jul 2026 13:47:24 -0500 "Maxwell Doose" wrote: > On Sun Jul 12, 2026 at 11:52 AM CDT > Joshua Crofts wrote: > > > On Sun, 12 Jul 2026 11:42:25 -0500 > > Maxwell Doose wrote: > > > >> kernel.h is no longer recommended for usage because it can cause longer > >> build times and pull in transient dependencies. In addition, it's not > >> being used by the SCD30 driver. Remove it. > >> > >> Signed-off-by: Maxwell Doose > >> --- > >> drivers/iio/chemical/scd30_core.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c > >> index f85cdd8bd84f..40bbf26a667b 100644 > >> --- a/drivers/iio/chemical/scd30_core.c > >> +++ b/drivers/iio/chemical/scd30_core.c > >> @@ -23,7 +23,6 @@ > >> #include > >> #include > >> #include > >> -#include > >> #include > >> #include > >> #include > > > > Since you're doing IWYU stuff, you should also remove errno.h and > > add err.h instead, as the code uses IS_ERR() etc. and err.h includes > > errno.h > > > > I tried to set up iwyu-tool to no avail, but I can send a v2 with that. > > > Also consider grouping the iio headers and asm headers separately. > > (separate patch though). The include list looks overwhelming! > > Indeed it is but we try our best. Good thing is the more we remove > unneeded headers the better it gets. > As a side note, (and I haven't checked it) Sashiko had some interesting other stuff noticed whilst I reviewed this: https://sashiko.dev/#/patchset/20260712164225.358852-1-m32285159%40gmail.com If anyone has time to take a look the CMD_TEMP_OFFSET / 10 indeed looks obviously wrong. + I moved that code without even noticing whilst using guard() in this driver :( Jonathan