From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9215353A65 for ; Mon, 13 Jul 2026 03:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783915069; cv=none; b=JBhY+F9rNvqe+xdHdDlmc239te3hUNNRsxsltltRkFcFPUuN/2g/c97iiLJAmlGwzFKO9E8qUkGkQ1hx2NwHesylqQ6KUuqRk/yqy4JLn7/3wxN5w3kjE0ZPlti9F8z3XEFns6UOoZ+O3YExGGrAqpWc87fNgDekn1L36qptJ9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783915069; c=relaxed/simple; bh=WcD/SwZ51u5D7/QlDApFgv7wv7BrDF1ptkN3NyTZTK4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Wu3bRFmRGpwceR78FGBuPt+LpWcpmG9HbnH9DQCAsBd7SIfJENG6EyT1eE+Dhks4kWUGZOLqoX9hYpYqc8EzWh7d2A+FbjBvJgmwkJr3w48W2quh4aao4j6u4c6WlybLuX//R6fwPhlgD2f68gF7We8IC3aZPWGoZnhJH8Rb1Ow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z98qlz8U; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z98qlz8U" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2c7cfa17fedso38070925ad.3 for ; Sun, 12 Jul 2026 20:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783915068; x=1784519868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wxIbOIh/93KyJON4/kBivEyvzBtFQfz4AT0SG4ihafY=; b=Z98qlz8UmWwZApTJ2fQ8I/YU03u/g+VOfY09HQbOluyyQI1fDcNDxj8Z+9P6qscZrq oWSFKJluYqHyWRnPohxdFOsl2BuQzPa+T5tuOWHhCYFlM4BLxxWXJf1cdSs2elDfmQAR 40yjfE75x+67m3YDMZMnbIEd1W9fV4+5cuNrBH7FaWD1nSTdqeLodPNBoxYmZeKu27Jo i0keOAcgICFjtTnQ7XthTWsB4D9skb3QjWDLVLod2IQZrmvBFuTUXoEyAcypKkX1A3a4 0yGjtt5P24skCycCTBKoPtcxPzU3I4LT3P0Ubkj2KHXS6h52rH6T9/HwUiY/FU3J7ym6 FOoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783915068; x=1784519868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wxIbOIh/93KyJON4/kBivEyvzBtFQfz4AT0SG4ihafY=; b=PCAI+APPTpt65QiADQz/pjdEz1CMBMR9MgLctNoAtBtggOMR778kjGztW/vY5HoV+e L3SO79KZZw1vxj4gNzFpxpOuT5o3EDbmPycCFGgJH8mO7FbEa/b+f7/Eucz/bB34NxlH dsUf+i6SaB/SFX2ezT3QcymukLph1+qn133C4Z7rclbrx0pvZfBxUH7e1qzhUH7E4VQv QYoWq1MnFVtHjtuHineHaSHqCVnJzfvWCvRabPW+MWgDtJjQSfZt5pDEvBYHhVTHb8P8 rM4+4An0rgsYlgYo2J6vZRA6sowKVfbposWdry7eK89FVixQTZFWkGwfjIPUULEbI5Yy f0xQ== X-Forwarded-Encrypted: i=1; AHgh+RpukEgaa0TFj5zsZPcj66lkLNXhkrlZZp+q3iziaew32I3RbIFr8hMWB61XwlPmeKVqF0IyyqHx13TJSNA=@vger.kernel.org X-Gm-Message-State: AOJu0YwbnLW7EMlfZp3NQp/J24tC8rm+nj+SUKs8IB6GCWHeMuK9ai+f dw3AYLVUvCUX75ts3dT2sCU4SpawT1GdcvbHWPbQnT/ASt0jv8IdHSMh6tud+yU= X-Gm-Gg: AfdE7cnna4PEVVFN1c9Ul8pATbX6Jr0tIBJsExu0TxWnSvWiLAKVzuNjJeC/Mx4jAbO 8DY82SnmX6blljv95fjXf0dctmGQVZ/nhuvMeuSpNDC6klEfRSZlUrH27+h2ozeMNVVGdoDQOCM ipNCbsoIV4nsc+t5QPjD88rAye3mQoSHpSVDXE3SRNLK6FYg8fnGmwMqniuzWCGwHLB7EIynplV w3g1DX45WV1JwIGj7Q+2jfePIrdZS+DXDoktr69G3UzaH0yBNyuL5KU5ejKyLq6Sn9fDYFQGVbz iOemlNQTFw7GTcNegrJDb3W5DxOUXghUej+9XXqdShuwKWRkY1aUg8CXO3yzFPkFvuvexMOwg1/ ZoNKuFXogMPdHFFCgKZLhMDF2EmncoWgtIfHa/Or2bIOUjT/F6jKUC0iCtp826KP0MRYQ6qhx0x +rRXRqXiKeIA+Wd66bNX4m16KRG4QQlv3CRSlngNaiyq4VdJ84MsCo X-Received: by 2002:a05:6a21:6817:b0:3bf:ab02:439e with SMTP id adf61e73a8af0-3c11028952amr8112912637.27.1783915067796; Sun, 12 Jul 2026 20:57:47 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.154]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f5975sm60862704eec.4.2026.07.12.20.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 20:57:47 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v2 1/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask Date: Mon, 13 Jul 2026 09:27:33 +0530 Message-Id: <20260713035736.11346-2-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260713035736.11346-1-nikhilgtr@gmail.com> References: <20260713035736.11346-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit GENMASK(h, l) requires h >= l, but OPT4001_CTRL_FAULT_COUNT is defined as GENMASK(0, 1). The define is currently unused so there is no functional impact, but fix it before anyone builds on it, and add the _MASK suffix for consistency with the neighbouring definitions. Fixes: 9a9608418292 ("iio: light: Add support for TI OPT4001 light sensor") Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index ba4eb82d9bc2..0a2d2273355f 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -39,7 +39,7 @@ #define OPT4001_CTRL_OPER_MODE_MASK GENMASK(5, 4) #define OPT4001_CTRL_LATCH_MASK GENMASK(3, 3) #define OPT4001_CTRL_INT_POL_MASK GENMASK(2, 2) -#define OPT4001_CTRL_FAULT_COUNT GENMASK(0, 1) +#define OPT4001_CTRL_FAULT_COUNT_MASK GENMASK(1, 0) /* OPT4001 constants */ #define OPT4001_DEVICE_ID_VAL 0x121 -- 2.39.5