From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25C20377019 for ; Mon, 13 Jul 2026 03:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783915073; cv=none; b=IILo1+iRILPcyD6BvKCzCmNhfFOPauLupI0OWt32DfyRZ8rnRbpvs4oYeeoy0Uyd/2Z/9niDXqMkreOuhzU5nIwt0JVtG4IZNQMb3SUm1SEKC/0xwAAMHWcVmQReMmKH4LK4anH89PqZwn7mTIpc4/AU+TNVPrM6xom+abQVnrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783915073; c=relaxed/simple; bh=z+U8oayBtbyDjiqzkSugPHEzyalDbZXOfve5HtCvp4s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XATimFNM0tHnmQMMN08G1+5r5s+Rg5o5yWqIzTr+PUxYuPh6X5lzZSyN24K8wmuu1lv8abTs1jGsHPM1PB1P+fHXweKOodDOvL7Vwhx4bK6XBGuH1tQZQMuLxIlShD8462mhfjJGo/rb1eoZDiaVJD8Y5MCaC4GY54UIxJ4HW9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YxBQltby; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YxBQltby" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2caed617615so28979625ad.3 for ; Sun, 12 Jul 2026 20:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783915071; x=1784519871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vxnQGcuHLKcf9MzGH2TOhY5/hCrMKAUAuuzoIzFw4Gs=; b=YxBQltbyyfo8kSN2MC8465WvRj9Vn25AXVcXoF+lG1WFxYlGzI31e83YUqWkSdWLHM MIXLlOcSMvlk7VDaHXF2E16KMGug2tCrVmlN55wnU1Y2jZdv13NHZrLwNQGnyGSDxu7k cmR7+1YIKOmIjZtz/ptkYEWocTv2MYFur+tMhQ6ZHC1KTIU54MMceZekGiERDRxiW4hl FUZWtPsc9kMKNb2n8PV2GE9d4zAjNFzFJ8MLOly7Mbp3y6/smWA2U55XPTUVwhXc33Zl FCvb9ilsH7+zbei5bunYKZxrssxTNoOoiPEhGE/3rBUEBBfRRAdKlWHOKTFwygl89i+6 pMNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783915071; x=1784519871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vxnQGcuHLKcf9MzGH2TOhY5/hCrMKAUAuuzoIzFw4Gs=; b=ickyG7X05Ex6qgh+0iLWtDbJZFIGK9iqzThOgZS7kiYnUYSOzkWv/1HRU9SXSDIOmK /KyKp9lvl7LnuqmIcqA2beHsQ0EjZAZ0+3NMSPIXPBH+BZt8LgSu9MceFqckeR+dDLpP 5LvmUSlAEMH/iiVKeTPZsp9bb0pkrAbknRF8MgWlFDH8AkJurX/V4kaP4YSNAEiOH1xX tn68C//HiNm3XNjZoiNPtskv8lZYuHdWD439nT73bIjsShFEkE2X6Q1VQKbeK99Ja2ds qR8nvmo1gu8PxPfuJfrMY5IG2pSxT8n3ABftaJUIbql005nypFA4BwxriyJf4t+WIsua PMiw== X-Forwarded-Encrypted: i=1; AHgh+RoDtpuFF/N8zj+FhcgbN98dK98M2h8zih1GUajAlVgNYdD28/lDDy4IcvSWhFvGHeikx+9SdKZOdRXAWkA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywc6p92bz3WiyBjxIfXeCheljS7wuNA2jOPomvy3d/4pb4OZA3x dDDrztKbnlapj6OpoLNAsOHnvrkMnAZlR33DOoTrvLOxYdd5VAlg2hPZYUMwqJI= X-Gm-Gg: AfdE7cmMpeLD7tijbhHlQuSK566neHS267CmM868Em6OLHKkN1l8FbmudIEpDKNwHS+ BK1LmU0T8xFU35dBX0dsoCs82YrCt0ip4LcJxq5uNpSrJHycPsu6OwU7MtyAWki3+Y3/dR+qk6n /KDbiYbNcm9iM+SVeUUS79t3ctTKgI2p8oneQ5K/GiD+qPn24rGDbyeQQPpRI8K28swHl31nmov No6kyZFnB0k5qp8ivCPNhMC1bThvuxJXkRSwcuT3Qe0+xF9Wchk59OswtNmDiUnOrypHtgZNBpi ORVBs043bAfkK1XvBcMRyo2SxEt2UcuruNkJvX6fc7on0ZnFpGPiWfKHjMVqxHggHCg4lCmJCbl 4XVXfYXjAOEI8vwEIZvRhYf5Jw6xeClGxaabJslwW+1g1uD9SFwLkgRvZyz8NGlsR8giaSb/utE RI/No420NrP2492LL73XO83IUBLvbY9IRE4ci5he1bOFounOt/CC1h X-Received: by 2002:a05:6a21:386:b0:3c0:9c19:659f with SMTP id adf61e73a8af0-3c110b7b9d2mr8245371637.71.1783915071565; Sun, 12 Jul 2026 20:57:51 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.154]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f5975sm60862704eec.4.2026.07.12.20.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 20:57:51 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v2 2/4] iio: light: opt4001: Reject integration times with a non-zero seconds part Date: Mon, 13 Jul 2026 09:27:34 +0530 Message-Id: <20260713035736.11346-3-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260713035736.11346-1-nikhilgtr@gmail.com> References: <20260713035736.11346-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit opt4001_write_raw() only looks at val2 when setting the integration time, so a write such as 1.000600 is silently accepted as 600 us. Return -EINVAL if val is non-zero. Fixes: 9a9608418292 ("iio: light: Add support for TI OPT4001 light sensor") Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index 0a2d2273355f..9ff99c19b6ae 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -287,6 +287,9 @@ static int opt4001_write_raw(struct iio_dev *indio_dev, switch (mask) { case IIO_CHAN_INFO_INT_TIME: + if (val) + return -EINVAL; + int_time = opt4001_als_time_to_index(val2); if (int_time < 0) return int_time; -- 2.39.5