From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f1.google.com (mail-pz2-f1.google.com [74.125.228.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15ABF29ACCD for ; Mon, 13 Jul 2026 07:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926357; cv=none; b=I9VrXtkPHrKf6kXC4x01o3mW/Dq+hKa35oSt9kaFYg0eEYHY8oibIGilI4kvKuSyRrWTNNRq8YG/XtQckHie7tdBfboFBOOi3YtyFxzbAQAFF6InbtTEtpF2VNpg4ZeRStrg+zzMlA8+0yz8lDCFYA9fddnrmG2RkjZoSZ9hB9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926357; c=relaxed/simple; bh=f/MBbiCuKKupEkf1byRULDmHXfS8NTVvAP9nhNm0auc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=smMRJHZFiWKurEy/v6YGcBKLkwJ6DT+MXHNJHHoSwWITVzFeU0E+esyRNbRh6r6pqpObCHWNmIBhfJz1q1OjRdTx1Cmb9x7qMxCowQ0cXtViTYEumMkAHogQE2NOqcMRWfW3JYANcXsqfWMpyG43A5uvWkTKk9G6BqFgeEqKSsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LWqMPWrj; arc=none smtp.client-ip=74.125.228.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LWqMPWrj" Received: by mail-pz2-f1.google.com with SMTP id 41be03b00d2f7-c9486571b64so1743728a12.0 for ; Mon, 13 Jul 2026 00:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783926355; x=1784531155; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qA1SnyVW2zGbBB6hZifBtURCT9h+B8LPBVvb0SNXHhc=; b=LWqMPWrjZiEiGjo5YESZsk9BHc6k1buWYJwNr/EhIv898iHOyQlhymFMV0tq32R/IG QRrY4BUInFR/zVqUh/of4ZWR/Iqm+RQNWcf1lObtaeWvkfEFaU77a0n9wgYMyMeRq1xU tTCQt4gCDOP8iNLGL7Bs/IUKz4lfdrdcsHUtQ5GYaf8RW2L6+JxelL/DQLDy6vF5KkJE dH1tUh6UawyREHZ0Wj6ZYoQHKmP+flO6Cu+gaaera785Am4uNZhdqoXDPzMWqZySzix3 XkBV6Ev2gA+m3V8s4oaV3Wl9fbvB0puYQjAv6gr2QstLvY+89gZLskv2QvYxWg/kyLNW mE6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783926355; x=1784531155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qA1SnyVW2zGbBB6hZifBtURCT9h+B8LPBVvb0SNXHhc=; b=JjWVgLPWpF+Y7THwj8MQsiqFWwm6vtT8BuI3829B2XbDPvYnZ3KLYo5TMOf38p4dC/ GPd88BOT3IIEHoR/h/5yqCBRaU7ebFWycvSQ3BIkw3sAMHRXR9OaMH2Bk8kqSCGpCOdS SnIDWYBpqN6dY9vh0V7jAD3TKnPUduo5eei+HsbNDIGCBNSBZiIGWLPMemnYYe0d2tW8 Voa3Y+ZvPq5fmiMM60SM5sMJwbbhBvTMT+YFZC18B0bv8X6P7l0SvSyK9EEoA0VAZ2Hx sF01X9UZLzZOmRXLbi9bsS09P7/ZeTSWovqiJVnDqQBG1U21ddivtpF5T3FqJ8HM2V/Y jEsA== X-Forwarded-Encrypted: i=1; AHgh+RoCScrDB30xGQ32RH+179jQ5LweT/C3o315ZaaoII2vMCCoAFNwr4yudgDes2Nwl+GqhAzU+2UzCD6lxgI=@vger.kernel.org X-Gm-Message-State: AOJu0Yye0u+58q+9WtzzJM3nqFtIeXmxlIUgmdnoLSV5dVWZHJ63zzTF lOcqMTknI/dqAweIiAhPHyvWw84Ub4Uf21YfBRFAze6/8KWIouOUkFu1 X-Gm-Gg: AfdE7clGxoth1YmqBjN0N5bRPM0JD395hK5hRLJXafvYRLRgPZMLcupBfBW8CUYa1v9 2Uknb+6FhLvUAc4HycqgBT/bc20uuq4axpBq1txKpEs198+UxcdScU7htOgCVbNp1NOcd/qzdRm bR9VD1NzAi+iX+1Aza0pE3s1dGaD5az+NVUiLdYHGo1TKPJVHtnlOlhMO5v94WGgCTxzn+OxNyt uHhoPNIUI1QBLyK6CGEh+QqlxHNxUlA9pxH37eYtRk0guL+ch7GaPGlF+3tQT//pYcfVgPNP9F1 vShnLAgDPV9GdMpRcI7MiNy3Nw8jCm9PgsNXJUrEkxkvkyinE8kr5Qs1Dvv2lEtqVHVUdOPXulA 9UdacBsjnfgTZJplqHDe8llnpl6zNRXNRbkriALpczPiINCjC4sOx7xWmQZfOI5aBC2U+WXrL12 Vt3YRpSAYJDpcYPdwUvpQiJeykt+9u/tFwCcR+5m0J1tcC X-Received: by 2002:a05:6a21:4d8f:b0:3bf:97e8:a04d with SMTP id adf61e73a8af0-3c110b45600mr9044683637.43.1783926355337; Mon, 13 Jul 2026 00:05:55 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b0240570sm33971943eec.28.2026.07.13.00.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:05:54 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 1/5] staging: rtl8723bs: remove redundant return variable in rtw_make_wlanhdr() Date: Mon, 13 Jul 2026 07:05:33 +0000 Message-ID: <20260713070537.15903-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713070537.15903-1-dennylin0707@gmail.com> References: <20260713070537.15903-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The temporary return variable is no longer needed because the only error path returns directly. Remove the redundant variable and exit label, and return _SUCCESS directly on the success path. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index ca8f01575b55..ff67e2576b31 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -911,7 +911,6 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct qos_priv *pqospriv = &pmlmepriv->qospriv; u8 qos_option = false; - signed int res = _SUCCESS; __le16 *fctrl = &pwlanhdr->frame_control; memset(hdr, 0, WLANHDR_OFFSET); @@ -951,8 +950,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr if (pattrib->qos_en) qos_option = true; } else { - res = _FAIL; - goto exit; + return _FAIL; } if (pattrib->mdata) @@ -1026,8 +1024,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr } else { } -exit: - return res; + return _SUCCESS; } s32 rtw_txframes_pending(struct adapter *padapter) -- 2.43.0