From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f1.google.com (mail-pj2-f1.google.com [74.125.227.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5DB369219 for ; Mon, 13 Jul 2026 07:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.129 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926361; cv=none; b=kr2iLajwpXaeNRAEoYCsdJEU4p3AnceK+IBW7mwH1n1koYRsSh/1B2cOP5dKeUwS4/yeuF14LuqUEGJgwpkDE+ZcA9/J+moPk11vd7QvURuzkyCutwbK4j5xkbTQ5xkPb1kaj6N8H0BkF4yxTRN8r2bSJ1HXp7aVYoC4h3DL1M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783926361; c=relaxed/simple; bh=N9HLizXXiFAvZaaWH1ui6wNm8m+fAkUVUXVihRy1fBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L5BXGZyN7V1SweJlprluEAFs5geUsD7EAcYOIUqjsTpM5Wo26Bqrtyf2QrWKMr8J9K6aMYqaH4P+0JB2NGfucvfYEbMYeWZ7FIeRODFz2NuSdA488DDbG0C5okidai0z+l7d04PQaBXBUmR6GrKTVOhyjFZN1+TUIkVCBbSR0tY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P2pF0rvY; arc=none smtp.client-ip=74.125.227.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P2pF0rvY" Received: by mail-pj2-f1.google.com with SMTP id 98e67ed59e1d1-3810f0aba07so1656789a91.1 for ; Mon, 13 Jul 2026 00:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783926357; x=1784531157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bFy8a5KYcxfhVgWB2o9ncTF1rCZKKEFMUuyrfhVpuV4=; b=P2pF0rvYv5hiAYWMDApzELBn6tv3La0dYWk2Ppxgj1Zzs8gTy6+zfvhwPNDcbHu6RV uam9M9CA/Udw6mtGjrgO4x/piHBlMZ6HfSxFJfvKi4SqNYSYAiZaLVF4cd58eeO8uSW3 uDQdKdmyLc1TUOd5quuYHKuFVxpxpFVznugLQAXh+Mw9swKSVI0eObrCDN/1UOCYMrDK PhKyJvN1lsVXvPmfuldRSXuNzLUf27uraBQ+/WJCplkon1limJAw6b0ETJYhyUF9fD1D X9BbWvmAT0wPoX8QE9AdF/6Nn3+pVsoNsrh6d+2hDXrXz4q+QXWQmHUaGcqs3UqB7Ghz iFcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783926357; x=1784531157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bFy8a5KYcxfhVgWB2o9ncTF1rCZKKEFMUuyrfhVpuV4=; b=jZnfJVC1tnV+wAGC4SbD9V3/r4oafOg/am2pLiCorijpJzB2qAHXx/cX0KiHI0sXqZ f9dxDInMNZLI2iwnmkXJ+5468G1OfEN8HyNdYgqjItXstHC7pRknn4MskDXlOJp0NgwE BZQiT/huFM2IbWnKEIjxUAs6xp1MPEyGTR/ibd3an1MCJL4mxITk5rdIwAB89Y5obKWA 53axpZzjG5oOYWmIuEuDbMXxhjidq27N4ZOT9ZOUBq1TYoUQz+qowj09aZvAMV3RAlnh eghZoSgxn+WzSp3B3fw++aXWA0tZxhB5VyTM3rRLYXrrG+X0RSDdPT2qw5L35exv2Q3/ Ui9A== X-Forwarded-Encrypted: i=1; AHgh+Rr4NSpCknQtHe/zjuAM5ziMt6rmoa9RACw/+ocBNjqcmbC80LezAxYM8ZH7ADpvs+xPi2UamBt/7QNQZ/Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxlZL0YLVhqklM+3WcP/I4fdOiAjhYxcDcOd5lNTjVIL6eb4pnb kvl841DwW10ZTR6rox80jTch4ByMul93CbuaL/LV1aMXN1bHOPrQE9RVqUUPjd3i X-Gm-Gg: AfdE7cnWN/K/X5T+NZo+spAksn1h6HlQJ12N02ZNXc/uavkaYIcfk5ygKDNBtCltKBN Pcj/afK8bgcFtwpkkisF80olMPu8kLJhZV/GCqaqRmQoPPjYADe2DfeHzzJitLmcjvF5knb6Xml hac+tflVXy5pUro0tFZysxHnPKhVTpfjSt6gbko0xiXxpTWsyTgBTlMp96F46lUJ+WneI5dHxTK 13JOateIEtqzD6XTYccZlz473Izhmy0lysCGvYFQ4AjATVW9rSqkvksFSsJF5xdlmN+X475yMg0 SaRIJivpAuDJvIyqs06RSeu+/FSKbw/jnIZWm65SH6a52Dv3XxhsBFmIoCgCOQcbDEbQgsvhkOK eZvlsJywJeA9EPWT9vdXJDCrGjxo3nKqABYZmnWtDK/WhT3ah6VJYRfHL67uVx6gP8kQ2SGVa04 1ViUAGpC44CyHVvqrY0ePstIc10d4CQvgXQaJLWGm8m/Zi X-Received: by 2002:a17:90b:17c9:b0:387:e0db:3d90 with SMTP id 98e67ed59e1d1-38dc77e8853mr7597465a91.43.1783926356989; Mon, 13 Jul 2026 00:05:56 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b0240570sm33971943eec.28.2026.07.13.00.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:05:56 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, khomenkov@mailbox.org, khushalchitturi@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 3/5] staging: rtl8723bs: convert xmitframe_addmic() to return errno Date: Mon, 13 Jul 2026 07:05:35 +0000 Message-ID: <20260713070537.15903-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713070537.15903-1-dennylin0707@gmail.com> References: <20260713070537.15903-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert xmitframe_addmic() to return 0 on success and a negative errno on failure. Update the immediate caller to handle errno return values while preserving the existing _SUCCESS/_FAIL semantics. No functional change intended. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 98b886732646..07e413f4dbdb 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -797,7 +797,7 @@ static int update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p return 0; } -static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitframe) +static int xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitframe) { signed int curfragnum, length; u8 *pframe, *payload, mic[8]; @@ -820,12 +820,12 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr if (bmcst) { if (!memcmp(psecuritypriv->dot118021XGrptxmickey[psecuritypriv->dot118021XGrpKeyid].skey, null_key, 16)) - return _FAIL; + return -EINVAL; /* start to calculate the mic code */ rtw_secmicsetkey(&micdata, psecuritypriv->dot118021XGrptxmickey[psecuritypriv->dot118021XGrpKeyid].skey); } else { if (!memcmp(&pattrib->dot11tkiptxmickey.skey[0], null_key, 16)) - return _FAIL; + return -EINVAL; /* start to calculate the mic code */ rtw_secmicsetkey(&micdata, &pattrib->dot11tkiptxmickey.skey[0]); } @@ -876,7 +876,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr pattrib->last_txcmdsz += 8; } } - return _SUCCESS; + return 0; } static s32 xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame *pxmitframe) @@ -1175,7 +1175,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct memcpy(mem_start, pbuf_start + hw_hdr_offset, pattrib->hdrlen); } - if (xmitframe_addmic(padapter, pxmitframe) == _FAIL) { + ret = xmitframe_addmic(padapter, pxmitframe); + if (ret) { res = _FAIL; goto exit; } -- 2.43.0