From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0698E3ACEF3 for ; Mon, 13 Jul 2026 08:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783930406; cv=none; b=WGQOuexnlkl3QWq6SOUQhT2eG7zVGsnWwn/ena2cUd2f8At7O8MTf2AJl8F4m15jCSUTygh1JtF2Udjj8SQvCqq4gKdKTEgOgoTdbWZg9fUqgt9/wHIy3gR+u0sXwQfswUOAWtSXWGJNvztyFPkyLSH5wXdY7+LUk4bAKfww9w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783930406; c=relaxed/simple; bh=hRvQrqQiaT77C24qSbN9FSfU+6cDdGETb6Ihl7Xd0tk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oJQOp+V+BEo9ncreIM4URGWaD7FT318TOK4krc2aojugcq4uYM7bb38QvbprWI0vQ91omx6nCtdxuCG6+ELfQkIH5VSD/mmOJx5oeVRZ1/jCd/4UwAOBXVpq6qvWRS7KpaWyZRJHCZn+37XZIzUpn8+toFBUneUJ6u3pJtAPxW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=daeE9u2R; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="daeE9u2R" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493f25d47dcso20704315e9.1 for ; Mon, 13 Jul 2026 01:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1783930401; x=1784535201; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PjPIm4ums30j8g3FxgvW5VOiT2yATydhPlXxinqrvQw=; b=daeE9u2R2S/P/tKRYYrd0NaUGigckb7v9er3URbsIROcNLgwbtoUrjfLDGD263LB73 RMw3ok+a0oLcGBKRawGbafQCol53sOQmerYV9w4w/cHRdbSCWPHAO1yYW9QiDicOvjm6 dh9A3r5hF1HaMngZChAEoBjXGTuhiRLU2hoZrTAdkQaVEXmbky14v0hrrEzSRsPnSUTd 3xzqH67DZEzzTw765cEhyuHazoldDbEvNT2ht+UcA90OEkG72ljq4HYNgTMrnowVJfeX LNDk7iiFWzA8uX5t8b4mzsqkqAJol0RuNC+936S17KBNmWzClgCJXwuOxYC+RSNE/oGv Ulfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783930401; x=1784535201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PjPIm4ums30j8g3FxgvW5VOiT2yATydhPlXxinqrvQw=; b=QUPMb/k0IAmIOQh+9M+qKjFKxKc9hNml3dPA2PE2T4yDG7GwRapIyIW0fyC493YU6F XQBKHWpyby73apkRcLg4A/vQEtzwGJ176CAwmgvnojIc1/dN7auDPf+iTsRwLJLmlxu8 tYJiu96zmXV+LnzVTRn5/RatGfFEHaeYxbyALMb9CT8nYwSzhQThERouFCeaLgz1AwZc OmycXWVEG8kBTN2js8Zw3cHamiO5cjrkAyxfKmONhZcImrcTuf4kLk7UsC3FC7I4TbX9 A+527TcDDPvr8F2J4dRg7PwzxZYCS5Zf32YP23zDlk62A3tW+MsRUCWSR27bXa0ndUT3 hHQA== X-Forwarded-Encrypted: i=1; AHgh+Rqf58jPkJemle5NZN4GqXiVcgwxJC1Hc81xLFhZ5QaDL6ueDcdNT2o9d092tCmUY5mQZeH6fvQvSuchvTY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6Gvw7A7RvkbK9ceI0T58mHUJiKFgOU8zRG6YUkAFlokyqCJXp 70GVOBWVrbwwObE3jNOphNiZ1HGFWrj50US2Phcz/Alo40YyJmBNLNXIuE6GI85jJQ== X-Gm-Gg: AfdE7cnWud/4pWqcps6w5NWqy9Khelxwg7BwB8wfjXVAIQsrMwAdRKkvd39vJ1lNCRK IyWqG1U+OuijYZu8HwpTRra09dwUjQsfnzlbYsYbFdxHftAZxHoC0gNJIY6FCPxeg/AI94xJeuY T/H7jwi4DiZ/X42WUDE+dyq88yYo2qeebqidZLzbZZImY4BdADrIiH8upYClwgMwsmDc1GrkMY7 ZX7Kb1EWQOJ7dSU3wtdfghkvlwCQhfg2Ck+ZyLIKl2RERhSDmtWVmp7Aqh7uAWVvHMWtW6OCh63 vXh/8HwAeSjIcRPhAgK2GE81TQB7FCL070/SX9tB7vdTZOtjI+V2ZOka+nR4Fsy9AzQaCXCYIgM mRoUpAgGo7kR5M0zhMr58/QUIhuH8jtHfQqZ5/WqZRefAqkUQhWXgPgdi5F/hg52LHcTg0lt76J kuoX3jZcz37vpcV9S7FculkWh2pDi7dAmpalKg31R+uF3WJH72QGHGHW38EV3JudHe/AQ= X-Received: by 2002:a05:600c:2e15:b0:493:eb71:5cc6 with SMTP id 5b1f17b1804b1-493f88280bamr47688225e9.27.1783930400868; Mon, 13 Jul 2026 01:13:20 -0700 (PDT) Received: from horizon.localdomain ([150.228.38.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb73ae14sm343217885e9.11.2026.07.13.01.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 01:13:20 -0700 (PDT) From: Sean Rhodes To: tzungbi@kernel.org Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, corentin.chary@gmail.com, luke@ljones.dev, denis.benato@linux.dev, prasanth.ksr@dell.com, jorge.lopez2@hp.com, mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com, josh@joshuagrisham.com, briannorris@chromium.org, jwerner@chromium.org, tzimmermann@suse.de, javierm@redhat.com, kees@kernel.org, u.kleine-koenig@baylibre.com, mst@redhat.com, chenhuacai@kernel.org, wenst@chromium.org, florian.fainelli@broadcom.com, titouan.ameline@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, chrome-platform@lists.linux.dev Subject: [PATCH v6 0/3] firmware: Add coreboot CFR firmware attributes driver Date: Mon, 13 Jul 2026 09:13:14 +0100 Message-ID: <20260713081317.2954586-1-sean@starlabs.systems> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260713054526.2902319-1-sean@starlabs.systems> References: <20260713054526.2902319-1-sean@starlabs.systems> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move the firmware attributes class helper out of platform/x86, rename the coreboot-table firmware driver directory from google to coreboot, and add a coreboot CFR firmware attributes driver. Changes in v6: - Move firmware_attributes.h into the sorted Linux include block in each converted platform/x86 driver. - Add Derek's Reviewed-by to patch 1. Sean Rhodes (3): firmware: Move firmware attributes class helper firmware: Rename google firmware directory to coreboot firmware: coreboot: Add CFR firmware attributes driver MAINTAINERS | 18 +- drivers/firmware/Kconfig | 5 +- drivers/firmware/Makefile | 3 +- drivers/firmware/{google => coreboot}/Kconfig | 19 +- .../firmware/{google => coreboot}/Makefile | 1 + drivers/firmware/{google => coreboot}/cbmem.c | 0 drivers/firmware/coreboot/coreboot-cfr.c | 1065 +++++++++++++++++ .../{google => coreboot}/coreboot_table.c | 0 .../{google => coreboot}/coreboot_table.h | 0 .../framebuffer-coreboot.c | 0 drivers/firmware/{google => coreboot}/gsmi.c | 0 .../memconsole-coreboot.c | 0 .../memconsole-x86-legacy.c | 0 .../{google => coreboot}/memconsole.c | 0 .../{google => coreboot}/memconsole.h | 6 +- drivers/firmware/{google => coreboot}/vpd.c | 0 .../{google => coreboot}/vpd_decode.c | 0 .../{google => coreboot}/vpd_decode.h | 0 .../firmware_attributes_class.c | 2 +- drivers/platform/x86/Kconfig | 3 - drivers/platform/x86/Makefile | 2 - drivers/platform/x86/asus-armoury.c | 2 +- .../x86/dell/dell-wmi-sysman/sysman.c | 9 +- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 9 +- drivers/platform/x86/lenovo/think-lmi.c | 5 +- drivers/platform/x86/lenovo/wmi-other.c | 2 +- drivers/platform/x86/samsung-galaxybook.c | 3 +- .../linux/firmware_attributes.h | 6 +- 28 files changed, 1128 insertions(+), 32 deletions(-) rename drivers/firmware/{google => coreboot}/Kconfig (83%) rename drivers/firmware/{google => coreboot}/Makefile (92%) rename drivers/firmware/{google => coreboot}/cbmem.c (100%) create mode 100644 drivers/firmware/coreboot/coreboot-cfr.c rename drivers/firmware/{google => coreboot}/coreboot_table.c (100%) rename drivers/firmware/{google => coreboot}/coreboot_table.h (100%) rename drivers/firmware/{google => coreboot}/framebuffer-coreboot.c (100%) rename drivers/firmware/{google => coreboot}/gsmi.c (100%) rename drivers/firmware/{google => coreboot}/memconsole-coreboot.c (100%) rename drivers/firmware/{google => coreboot}/memconsole-x86-legacy.c (100%) rename drivers/firmware/{google => coreboot}/memconsole.c (100%) rename drivers/firmware/{google => coreboot}/memconsole.h (82%) rename drivers/firmware/{google => coreboot}/vpd.c (100%) rename drivers/firmware/{google => coreboot}/vpd_decode.c (100%) rename drivers/firmware/{google => coreboot}/vpd_decode.h (100%) rename drivers/{platform/x86 => firmware}/firmware_attributes_class.c (94%) rename drivers/platform/x86/firmware_attributes_class.h => include/linux/firmware_attributes.h (60%) Range-diff against v5: 1: 4a82d0a07612 ! 1: 02edc6d05059 firmware: Move firmware attributes class helper @@ Commit message under platform/x86. Reviewed-by: Mark Pearson + Reviewed-by: Derek J. Clark Signed-off-by: Sean Rhodes ## MAINTAINERS ## @@ drivers/platform/x86/Makefile: obj-$(CONFIG_X86_PLATFORM_DRIVERS_HP) += hp/ obj-$(CONFIG_SENSORS_HDAPS) += hdaps.o ## drivers/platform/x86/asus-armoury.c ## +@@ + #include + #include + #include ++#include + #include + #include + #include @@ #include #include "asus-armoury.h" -#include "firmware_attributes_class.h" -+#include #define ASUS_NB_WMI_EVENT_GUID "0B3CBB35-E3C2-45ED-91C2-4C5A6D195D1C" ## drivers/platform/x86/dell/dell-wmi-sysman/sysman.c ## @@ + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + + #include +-#include + #include +-#include ++#include ++#include + #include ++#include ++#include + #include #include #include ++ #include "dell-wmi-sysman.h" -#include "../../firmware_attributes_class.h" -+#include #define MAX_TYPES 4 - #include +-#include + + struct wmi_sysman_priv wmi_priv = { + .mutex = __MUTEX_INITIALIZER(wmi_priv.mutex), ## drivers/platform/x86/hp/hp-bioscfg/bioscfg.c ## @@ + + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + ++#include ++#include + #include +-#include + #include ++#include ++#include + #include #include #include ++ #include "bioscfg.h" -#include "../../firmware_attributes_class.h" -+#include - #include - #include +-#include +-#include + MODULE_AUTHOR("Jorge Lopez "); + MODULE_DESCRIPTION("HP BIOS Configuration Driver"); ## drivers/platform/x86/lenovo/think-lmi.c ## @@ + + #include + #include ++#include + #include ++#include + #include + #include + #include #include - #include +-#include #include -#include "../firmware_attributes_class.h" -+#include ++ #include "think-lmi.h" static bool debug_support; ## drivers/platform/x86/lenovo/wmi-other.c ## +@@ + #include + #include + #include ++#include + #include + #include + #include @@ #include "wmi-capdata.h" #include "wmi-events.h" #include "wmi-helpers.h" -#include "../firmware_attributes_class.h" -+#include #define LENOVO_OTHER_MODE_GUID "DC2A8805-3A8C-41BA-A6F7-092E0089CD3B" ## drivers/platform/x86/samsung-galaxybook.c ## @@ + #include + #include + #include ++#include + #include + #include + #include +@@ + #include #include #include ++ #include -#include "firmware_attributes_class.h" -+#include #define DRIVER_NAME "samsung-galaxybook" 2: 285b33f805dc = 2: d5d3d1334994 firmware: Rename google firmware directory to coreboot 3: ce91f4da5510 = 3: 7a65c6b0e631 firmware: coreboot: Add CFR firmware attributes driver -- 2.53.0