From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF1F0334C39 for ; Mon, 13 Jul 2026 09:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783934757; cv=none; b=V0t/QsE9wxt0XNwnyqeBsjV1aGSYrFC7BJXlL5LejKHdLmu0qkBQqWwlWoQIAWOuAVWXugS5UTJlWlTUcczlr3LQiQbEXW1m44XaPkXyhB5nFmh98+AcxYH29rE7/McPv/ulHY01gPlLwWU0B2nggi6I6AN/YR6C/+4KbiHHykI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783934757; c=relaxed/simple; bh=IGwU/XzHL5SyWQ9S/hw4TQ6IbW+i1/eFqewpz5BZux4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JBYPqj7OeTq8nbM+V+4q6CPwuskJYca2eY8nTmX9omlmAtdcIKo3te+Kp/ZYKjJRcRh6vTYactWFyWo6gUfUxFYRpeyvp+/du1W0nzWT/MGwv+Z/EVQ2S0qs65oiv8Yk8A4Dpcd/U+MrkjlVeq1/7jxQgazguJxeIJJrxa6djSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D4r0JED/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=URT92oqC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D4r0JED/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="URT92oqC" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D6NrKT732376 for ; Mon, 13 Jul 2026 09:25:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=NbBmG6kgKD2 CVzzcP60K4ZcdLZpgmeYKoleCsoDM+Ww=; b=D4r0JED/rr9wtjtCMM66Ly6auYz sm6/XhNXWNLB9C3tM/7oD3opkoU+aZjiiGdGe4jdRlPWE56PPsryex3GWydx9IT/ vNTFlNrL4NCzV4NMMYqXzN6hW+n111kLX5uapuMMoUDJzoul5q1ScU6ZLrDRUxty qtsTfnpd5Qq2uRpH/cXbrlSf6D4JQtTLO5YFFDCynhZthA/oOMHat75UzB6h5qjO NlnLc+bgy6Mz/ojFMaP8awhQAID9mdBZ2VUdZbiiOF5iLaeVthLzgMJG8G6RSh1t eaWpXjiIio7M7VgVfc8DHJzgu9gsEQM8tcqC/FlMvstX/44QZcpBvVNpd+Q== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcjn39u8p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 09:25:53 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c9e5aba3d80so281237a12.2 for ; Mon, 13 Jul 2026 02:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783934753; x=1784539553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NbBmG6kgKD2CVzzcP60K4ZcdLZpgmeYKoleCsoDM+Ww=; b=URT92oqCOtzZMG0Hd/Ptt6yIQdjqB/xV0UepMtdQumP/0lBLbTdOpqDUd3M/XMQvhH k0pGKGkzFJiEypCBqy2fGJNIwinwG2Qtgv4iC2B+PGJ4kbFklfxOivsKmainrC3fpE66 /W7UA6L8nDGZUTNCb1/iMP3Ot5NBkBPFmqzfGPBUW9oDaWjDRCqdk7zPEIvOLCsgCO6Y HbzkbBXzZhmwOB3rkp7UJGYR1y+m86YTBZV8liJexQM7flAty72IwTR+0k6BUbzS3cAl tj+5GW7xPl00mnVHMOC+Mv4JHLdGpR15CojcRTq2cUhWjM/+LvzQuas8bG8KOpDB5YQJ vFaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783934753; x=1784539553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NbBmG6kgKD2CVzzcP60K4ZcdLZpgmeYKoleCsoDM+Ww=; b=OsvjsOE+TS4gwSi4iOJCka3mKsB/wlZAGNSgyTWTicYVl9hPMnWppLLFUkkJ42sN9I XE2+LgI1cRgZf0wRsVLZubKZlBWjhTYt7Ict/D/Qhb5IFJkRRFXgTX8SIK9iFD0I1YUv tU6gzcovWSMUEM29gtT4iK+DmBQG1RZnkdrk2j35mexuppWdLjMKmEunWel5hq4P/Qof RT31rpjVWBQpsLgBBVb+/rLCkklGCxC7Hsc0jwQSrFubaUPI7JznZbOQvAHk9ONhS59M 3zNt3c9XyE3aqykuEluz0VlL8E0GAr2/uSeha1aAYS+110vgOJW0RVwQ5cZmEyTj+JVR R/zA== X-Forwarded-Encrypted: i=1; AHgh+RqXUFw29zjb5uqNc7/QRrFzuG6enhlhOoXTiePhUguvSfMzf3Vkb/WK70zlIZSGl829hTPTpottLyHQuOk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl+XgksfI+WjFwAqlTCFOYemF+XjXKJ9nwKIBltJeuHZHeczeJ 34hC63jDNhfxVG0ht3huvO8tH+FVb2rgj3Vs+bUZVmTU2tv3dRYdZWOdQ8SRRCHL56yfXF6w2NR 3BD2KSCpc/7OLtEupcfCMFUryQ3VS2U6FOeTw5Q9cjvMYbbj6HE805VBVTIotRoC39aw= X-Gm-Gg: AfdE7cmAjhx9KI8nRSzmvRBUvYas8AC6sp6i6aZlkwNuVP4oWK1swYHCwul7ssY8MmD /KFJeu0eq7Dw3dRbUAN6FAE0/92WL6gu+mrn6kN64qDEumpxCt1k1l/kMxHsbONaq7TFOB8++Qr 2BLjfhvVHizo53w23Fv7KRsjbIaejr4Tr24qHfY/g/mGr0k77SvJKdN88uKF9qguu2w7zBoJQpv eC16GwjJFl8cmClc6JIMhhIcJ50rqHzhCJnVVR+4B1lUrKHSg6gZpU/y7okVkKGflmSKgjNIF1y cAvC8ZfbZeSvUMkF0NAILdmxk7iFYrtAXwlBfgkemAPGJVjcLU1jyhvFZAFyL+8dhz50u9mNOaJ Acp9sf1L9XjDBOnGNfwQY0R+gOn+WzlLISh0f3E8iIYGxbqFNxd7JzaoD/pIuVQ== X-Received: by 2002:a17:90a:7307:b0:38e:bfe:81e6 with SMTP id 98e67ed59e1d1-38e0bfe9036mr506234a91.1.1783934753192; Mon, 13 Jul 2026 02:25:53 -0700 (PDT) X-Received: by 2002:a17:90a:7307:b0:38e:bfe:81e6 with SMTP id 98e67ed59e1d1-38e0bfe9036mr506220a91.1.1783934752667; Mon, 13 Jul 2026 02:25:52 -0700 (PDT) Received: from hu-weiden-sha.qualcomm.com (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3117d847e17sm67901497eec.18.2026.07.13.02.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 02:25:52 -0700 (PDT) From: Wei Deng To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, mengshi.wu@oss.qualcomm.com, quic_chezhou@quicinc.com, cheng.jiang@oss.qualcomm.com, shuai.zhang@oss.qualcomm.com, jinwang.li@oss.qualcomm.com, xiuzhuo.shang@oss.qualcomm.com Subject: Re: [PATCH 1/3] arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector Date: Mon, 13 Jul 2026 14:55:47 +0530 Message-Id: <20260713092547.4100116-1-wei.deng@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <63643fc3-3a3b-4aef-96b4-de42498cf47b@oss.qualcomm.com> References: <63643fc3-3a3b-4aef-96b4-de42498cf47b@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDA5NyBTYWx0ZWRfX6IDjKOu6zaRc D1dM4oUo/azSrKZyEg706KUgAwZqzOnFRqWlcENw5bVSTLLH+rjs9EM8XfB6MkYU9f79Yi94hOR hC4PmFynFLKBjMHe2ly6NKraXFTr844bhksiFW9qFX7HobAxiMDnMZUBf3YpBtfL3VIFkSm9Rzj 2FksomnplKi8ffV+14hVAxkE2L+cjQtvWtG8tREVXT7j5RAEEJb7oQmUGqgaSClm+FyrKIchp5p krZf0KU1IDf8102QzX0bckvQvU+Juv0Gd8oyTeZyyRAzjdCUeeaSJYhX3eM4t9KMSfaWbsyLbY6 5SwltpYCiF2ZT3cUe1yRUKaHmvQJGSfVBMwgyiTtzjLS3Shflhvy5zxz6YRopxPM9u72vS0Ng4x uVcD1hGwm7hmBvVRA5872GFaQj5UMRtzK3GLEE/gjOyQwzErm8C6/iIiPLE+FngpacvFLTpTH8v yaiJu/BlLPZQEufDzoA== X-Proofpoint-ORIG-GUID: e6iT1_cLWBBDY4OrRP5RQJjlh_uQ3PHj X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDA5NyBTYWx0ZWRfXxQUT0TPW6iij EGbToV6LbrR2QcVeZ0gr5YlPM+c5P/DzXP1gu0Uy4JYcFKszTBKOOUm1YBhs8dJ8W/k+BoA/bPX xmPIpp6BXVNs+RgQ4qCc+2B6Jy6QZYw= X-Proofpoint-GUID: e6iT1_cLWBBDY4OrRP5RQJjlh_uQ3PHj X-Authority-Analysis: v=2.4 cv=aaJRWxot c=1 sm=1 tr=0 ts=6a54af21 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=VjGlub7PaFdePbqR2KAA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130097 On Fri, 10 Jul 2026, Konrad Dybcio wrote: > On 7/9/26 9:29 AM, Wei Deng wrote: > > The hamoa IoT EVK has the PCIe M.2 Mechanical Key E connector to > > connect wireless connectivity cards over PCIe and UART interfaces. > > Hence, describe the connector node, link it with the PCIe 4 Root Port > > node and replace the static BT serdev under UART14 and the > > chip-specific wifi@0 child node with graph port/endpoints, allowing > > the pwrseq-pcie-m2 driver to power the card and dynamically create > > the BT serdev device. > > > > The M.2 Key E connector is powered by vreg_wcn_3p3. WLAN enable is > > controlled via W_DISABLE1# (GPIO117) and BT enable via W_DISABLE2# > > (GPIO116), both described as active-low GPIOs on the connector node. > > > > Remove the chip-specific wcn7850-pmu node as the M.2 connector > > approach replaces the WCN7850-specific power sequencing with a > > chip-agnostic one managed by the pwrseq-pcie-m2 driver. > > > > Also add 'compatible = "pciclass,0604"' to pcie4_port0 in hamoa.dtsi > > to allow the PCI subsystem to associate the DT node with the > > PCI-to-PCI bridge device. > > > > Signed-off-by: Wei Deng > > --- > > [...] > > > @@ -1025,19 +1004,10 @@ &pcie4_port0 { > > reset-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>; > > wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>; > > > > - wifi@0 { > > - compatible = "pci17cb,1107"; > > - reg = <0x10000 0x0 0x0 0x0 0x0>; > > - > > - vddaon-supply = <&vreg_pmu_aon_0p59>; > > - vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > > - vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > > - vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > > - vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > > - vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > > - vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>; > > - vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; > > - vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; > > + port { > > + pcie4port0_ep: endpoint { > > "pcie4_port0_ep", please > > Reviewed-by: Konrad Dybcio > > Konrad > Thanks for the review! Will fix in v2. -- Best Regards, Wei Deng