From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b8-smtp.messagingengine.com (fhigh-b8-smtp.messagingengine.com [202.12.124.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F192637E2E1 for ; Mon, 13 Jul 2026 11:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783941672; cv=none; b=ZzZBH/hAjluqMuF6JeLQDGW9IJHk9BHDXP6nM/oE+gupX8ewTcS+6oTbCvGfNKMXi9nRhqnl3Ngv0vqvlPQ+E78wecODOyvdVM7JLV6SmLom6cdUuenfiAS72gH84J9UaZYSLBPlOK2A06sljjYVRIQ/EfVq5L5EVvJhuhJ4/A8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783941672; c=relaxed/simple; bh=Jm+TBYo1XPsGuMPlJeW4TwGSfjGesnsT5MbdssZ7veQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jmu3gKQE7CRR5hq1HBpiA5QnzUU3aFjKZscKqnn6E96jl6DlxKPTrrMmPPl7zNag3fQNHyxf78/LOAiTyua2ISKwgEpQV1IfB3rZodICeIveYJ2Yndqsb0MG8C9WOJ6oR74+CgG2G/CatdspRIFMoedEscYrM8d/6ZcWJHZgj/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=gUnWRe5n; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=DtU4xJfV; arc=none smtp.client-ip=202.12.124.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="gUnWRe5n"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="DtU4xJfV" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id 23DEA7A000E; Mon, 13 Jul 2026 07:21:09 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Mon, 13 Jul 2026 07:21:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1783941668; x= 1784028068; bh=nTPkYS5gbdSDM6LN1NX+SWr5Y9fRMRygQc/8boWEWgw=; b=g UnWRe5nUXO82g/f8QZtIMazpcAfQSZrgnCo+41/6FK2MzRNzCDrPVhmAqXklv59L YVBOhItWVaB/veDVV4s4e/D8CvXjshULNAX+RmX97MkPwc02pWrBXL3wXZlNcOxq nELw5NG8n0AEBaqVpbaHLsVtn2ErzSqgFEQRCVYTuaBLPJKBQz88uaIzkNoz70qZ nQOH1M0ixubhrWGoPseXmWTBP54A4vFxSBttPlPs+aNGH/7QgwzGgI2kwXRN/pV/ s2x/oTefbjWyeYoLcutO+4DFf4ZO5XCHSY4BGMnNTz++hkRO4VsAzaZD4V3JF4wv d/6gYEqlv/loBD289r9PQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1783941668; x=1784028068; bh=nTPkYS5gbdSDM6LN1NX+SWr5Y9fRMRygQc/ 8boWEWgw=; b=DtU4xJfVN5B44aNse58b8rrGPZJt5buJb5CH+ZeIQ5QQzT10EXQ DDdYl9L9VP9Uj90VesgmFf+ocLp5zrXbUsteuFnXmYjLP+0qkJ9E7701DknkyMq1 IkBzNdziZN+544+jMOca5NjvAK87BKh9ARwmPFIFHWyRVWyTMwSrYkFb20v/0cGM LUBrLid+eKltLrqt82XVCu51HWHtow4hgjI8tPGNIXrqwVxArh639l3GuqTQ1NkX 342/1M5HVhpuFD9Kv36OIMzSOg75Xic7vK0YiCLou/5e2VVDh5/mlL5B0v02iDGe t+JoFmSfUY9ErPn5AlO/TZRkH8AZoWQX9BQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFeLx66sUxifRoDA7iZE8NaVZ3Z01HaMbQ+vk8h7YSMRwSXFKrLCrTWt1/mnRhlhN PgoOVOg3xgAX1X6sOjLaDHWwuIHnLgr0raT39G3R9MmOYFWfiwsspaLrBYwAOrNGaGZxmC v8x8YttvbKElDa10YAvRYuOCvpIfV+V4TajVjKb8ZLryEBlxuZ9WkgzyzDHQnDPx/mo7HN v/qmXi8AcEavqwzRr3LcOjow4lEtvL73aRHE2UIA8fHbxKv16pOwFl0QZ9VRw4NggUfUCK OD31NeKGnX8QNt4Fa10r3hu4nfDlWAJo+KBRyeW3TbIT0jIFOTYYFMlh420/Y/p7zHeKmJ 2u8BKJVagffatpnJms1cKg4P99vLJ78troW/D2Rr+nYYyW/eQveryt4Dn4T3SyqeK2vBBF ahGcqNRkDDiEOPF+REHsMOp1K5QuwH2EhZhxxXh3s/frNgHAvv8ykOyNuXMemUba29UZhm ZP6PrfHnWAPS4C2Nwp9kxuTIvpYoOMRlFgAqJETkl/CvTzJJV//8GzgMXieGWLhXKM1ddj JfhgO/QAgB+/dUkX4PYvcWpHqHVJg4FsKPpkoOLkcPztYoN3lTsHA+QesvW8PMdGHWTywF RNpnWIcYVoSx/Wpk8DX5j3qTbwjO8n99Bgxapb/WiEkyWUGvUYaswO8Qh+vQ X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Jul 2026 07:21:07 -0400 (EDT) Date: Mon, 13 Jul 2026 20:21:04 +0900 From: Takashi Sakamoto To: Ruoyu Wang Cc: fenlason@redhat.com, stefanr@s5r6.in-berlin.de, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firewire: net: Fix fragmented datagram reassembly Message-ID: <20260713112104.GA123079@sakamocchi.jp> Mail-Followup-To: Ruoyu Wang , fenlason@redhat.com, stefanr@s5r6.in-berlin.de, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20260707150454.2265951-1-ruoyuw560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260707150454.2265951-1-ruoyuw560@gmail.com> Hi, On Tue, Jul 07, 2026 at 11:04:54PM +0800, Ruoyu Wang wrote: > fwnet_frag_new() keeps a sorted list of received fragments for a partial > datagram. When a new fragment is adjacent to an existing fragment, the > code checks whether the new fragment also closes the gap to the next or > previous list entry. > > Those neighbor lookups currently assume that the current fragment always > has a real next or previous fragment. At a list edge, the next or > previous entry is the list head, not a struct fwnet_fragment_info. > > The gap checks also compare against the old edge of the current fragment > instead of the edge after adding the new fragment. As a result, a > fragment that bridges two existing ranges may leave two adjacent ranges > unmerged, so fwnet_pd_is_complete() can miss a complete datagram. > > Check for the list head before looking up the neighboring fragment, and > compare the neighbor against the new fragment's far edge when deciding > whether to merge all three ranges. > > This issue was found by a static analysis checker and confirmed by > manual source review. > > Fixes: c76acec6d551 ("firewire: add IPv4 support") > Signed-off-by: Ruoyu Wang > --- > drivers/firewire/net.c | 39 +++++++++++++++++++++------------------ > 1 file changed, 21 insertions(+), 18 deletions(-) Applied to for-linus branch. Thanks Takashi Sakamoto