From: Amit Machhiwal <amachhiw@linux.ibm.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Geoff Levand <geoff@infradead.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Amit Machhiwal <amachhiw@linux.ibm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/ps3: Remove unused struct table in setup_areas()
Date: Mon, 13 Jul 2026 14:57:30 +0530 [thread overview]
Message-ID: <20260713145642.aaa21051-11-amachhiw@linux.ibm.com> (raw)
In-Reply-To: <20260713091731.97212-3-thorsten.blum@linux.dev>
On 2026/07/13 11:17 AM, Thorsten Blum wrote:
> The local table structure is not used - remove it.
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> Changes in v2:
> - Drop the %0 change because it is valid kernel-doc markup (Amit)
Thanks for addressing the comment and sending a v2!
Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>
~Amit
> - v1: https://lore.kernel.org/r/20260712151300.3664-3-thorsten.blum@linux.dev/
> ---
> arch/powerpc/platforms/ps3/spu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
> index e817def7f424..2c785bc72565 100644
> --- a/arch/powerpc/platforms/ps3/spu.c
> +++ b/arch/powerpc/platforms/ps3/spu.c
> @@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)
>
> static int __init setup_areas(struct spu *spu)
> {
> - struct table {char* name; unsigned long addr; unsigned long size;};
> -
> spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
> sizeof(struct spe_shadow),
> pgprot_noncached_wc(PAGE_KERNEL_RO));
next prev parent reply other threads:[~2026-07-13 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 9:17 Thorsten Blum
2026-07-13 9:27 ` Amit Machhiwal [this message]
2026-07-13 14:03 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713145642.aaa21051-11-amachhiw@linux.ibm.com \
--to=amachhiw@linux.ibm.com \
--cc=chleroy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome