From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC6D349AE6 for ; Mon, 13 Jul 2026 17:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783963848; cv=none; b=Uu9CwRSgv4KO+Uk9UpdCGvZMtjcei9EiHoImWCRuJOjw2KcSLrl3sZlVxafHC3YrgA2vgq94SkL0u82n0bm9O9FOtfaZaayq3JjaZE/HMIvnURl6ExCuM5kOKgZIZigwAcd0Mmxo3plDnROnAyeauvOo5HrGmIRfyqJWrIFUc5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783963848; c=relaxed/simple; bh=1die7bI0OcCIcn1bppUSBazJU6X5SGKun1KXOThfxSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gta8B6KrtferRPIRng7Np9rv+3cawv13MpEKauLb4seG0Jvmnpg127flbd1rgISfpwtXMDuzyIJAc/3dwBWW8evQww1y7jyvgRUTl8L5bFxMrC6WqReMfNPeuwnLfjX1bzzHIiS/h4Ae3ZcAlWxI8ae0KZiQR2i1OviwQMNQu08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai; spf=pass smtp.mailfrom=0sec.ai; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b=PXUAqGMG; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0sec.ai Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b="PXUAqGMG" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493f140ca8eso21420605e9.1 for ; Mon, 13 Jul 2026 10:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0sec.ai; s=google; t=1783963835; x=1784568635; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bhFRmtEAl63b5XEQYkBemzUeown6Ez5I0lj5DtalopQ=; b=PXUAqGMGt9VdATqyXceiAh1SejsxG5hJ3b/DFrxKlOMynHIb7j1rxTZudsGZu6laFG kTZRi1Ml3G7gDQXTgrjfd1oN+qZZBew6/oQSx+HuPI9tzzZ8eEtGJthJNn5yyZRbqefK 3nFkELcDsNxCOVAsDf4Er8Lx5trgNdtRM/+ZY419GOnhlbOVunb+itoM4Cwvhk4R2XtM AAhDllS39/XpSku1k44zwf5qnP5+V79OJYzqTokB41U75PcEYq4WYD2q8pVYR92fz5pD a6uTw7Vx+NkqjXk/tKcDqKqXdlL9MK+TJ5+TRcUG8OQipWT5o10Pm5878M0gVh0HttiB A+ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783963835; x=1784568635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bhFRmtEAl63b5XEQYkBemzUeown6Ez5I0lj5DtalopQ=; b=Tgsq1oeFhqweb3dcQ+lmOppBCUCbi7lZoAFtjm7zXae1d7AkUjVPoqoN2IhX/II3m1 4AJRjkEE9omET6kvWrFDVrKeVcubdLBF4S5CZy4roXgmQFKNai88Ez7iNV/ZCXueua0g BmR/n7S2AiLL1pF9ch3HiNMbGIPOezKO/wGxeerBY5MUMqviBXqKnY7t5lfj18W9Prnw 9Xt3gNa2Eg6/2nGBtOZT5ig3Sn49QCQ5ksukfTHRYx4Ih809XI5CfzF30a9Pq6uY7CBx eMhLOsABb+oTFsQgjR1xjZkLhZ1oF7Iv07CF4Qiremc7VA3tPBRs+Px47KpI/ChSKptr r3Xg== X-Forwarded-Encrypted: i=1; AHgh+RpWqUPTA0ZmBaeLqMI2pC92xxv2G76V85fowqyyUq6RcBmcT/KhYjdfMCDVMfw9wE9nuTIQOg4H3jeJc+M=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd8h64KJ1Ij8iKrRlOyD+oNYa/IKZvpflObybqadfNl8h1Zt0i dRgSHJcuHVOJrrIqsfzoNP2788lZ7PAw4KIht5qlNGS4zF/m9JTIEfK2Ume7aVH1deSw8mVO5Yt 3Cik83f0+ X-Gm-Gg: AfdE7ckgtMXVoBTOvDG++0Dgcjmp9LBrxRyFp8PFi3OsKGTx0TUiLa+jRIbrbbc6rcP jOz/ZuvOY+2lZvBB87Xyyemt6dfFV7hvxdl/1swc1bsafbAcgCZHvOGkxOZzltHUqdOJ5bhFwlD hXF+LVHVYxKkr1NvXB4In1K7V6cSpgwJ7s951h8tq/1VcJsZxLbXJw5WlBJU6mrOeYTF7YD/SSA ZFQYhtG+lylG5bK22gc0Q0GD9u/WxV9tDshxLhzE4dqym9cwaQvflMGdEtho9/TFAPxnc9YYPDy RSZTIBfAifflh+7+iLqWW4Dza+02ppwqChFSNm08n+DnnrV/nIyHtUDZVm+cnzATgd+7qa0+fjs wdbzb3QPWm6PV+uBtAH8SwPrQ10X19FglsIaoQ7yni+nyrRZKYneXv0ZmifXqg2w2TlHUgFMMHM BGJKwmd/P4OA5zy2zuHw5i37yDT5HgJCQqM2WtNIcxvU0BsmVGGRyUVr7vkOML3jJDnrz3aHW7l bMnKXw0Ow0TyPR9mWgf26dBal28igz7E0ciASq9WNETeg== X-Received: by 2002:a05:600c:8718:b0:493:c1a1:68f0 with SMTP id 5b1f17b1804b1-493f881f0f1mr96584005e9.20.1783963834676; Mon, 13 Jul 2026 10:30:34 -0700 (PDT) Received: from PeakBook-Mini.tail8e484.ts.net ([178.197.218.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f3a60404sm260075855e9.1.2026.07.13.10.30.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 13 Jul 2026 10:30:34 -0700 (PDT) From: Doruk Tan Ozturk To: Min Ma , Lizhi Hou , Oded Gabbay Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Doruk Tan Ozturk , stable@vger.kernel.org Subject: [PATCH 2/2] accel/amdxdna: reject command submission on devices without a submit op Date: Mon, 13 Jul 2026 19:30:29 +0200 Message-ID: <20260713173030.87541-3-doruk@0sec.ai> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260713173030.87541-1-doruk@0sec.ai> References: <20260713173030.87541-1-doruk@0sec.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit amdxdna_cmd_submit() calls xdna->dev_info->ops->cmd_submit() unconditionally, but only aie2_dev_ops defines that callback. aie4_vf_ops (the AIE4 SR-IOV virtual function) does not, so a user AMDXDNA_EXEC_CMD ioctl on an AIE4 device reaches a NULL function-pointer call and oopses the kernel. AIE4 submits work through a mapped user queue and doorbell, not this ioctl path. Reject the submission early with -EOPNOTSUPP when the device provides no cmd_submit op, so the shared EXEC ioctl is a clean no-op on such devices. Fixes: aac243092b70 ("accel/amdxdna: Add command execution") Cc: stable@vger.kernel.org Found by 0sec automated security-research tooling (https://0sec.ai). Assisted-by: 0sec:claude-opus-4-8 Signed-off-by: Doruk Tan Ozturk --- drivers/accel/amdxdna/amdxdna_ctx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/accel/amdxdna/amdxdna_ctx.c b/drivers/accel/amdxdna/amdxdna_ctx.c index a5c8c2c4de6d..bdbd3db12a6c 100644 --- a/drivers/accel/amdxdna/amdxdna_ctx.c +++ b/drivers/accel/amdxdna/amdxdna_ctx.c @@ -590,6 +590,10 @@ int amdxdna_cmd_submit(struct amdxdna_client *client, int ret, idx; XDNA_DBG(xdna, "Command BO hdl %d, Arg BO count %d", cmd_bo_hdl, arg_bo_cnt); + + if (!xdna->dev_info->ops->cmd_submit) + return -EOPNOTSUPP; + job = kzalloc_flex(*job, bos, arg_bo_cnt); if (!job) return -ENOMEM; -- 2.43.0