From: Andrew Morton <akpm@linux-foundation.org>
To: 王翊嘉 <wangyijia.yeah@bytedance.com>
Cc: <shuah@kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<muchun.song@linux.dev>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH RESEND v4] selftests: mincore: count file-mmap readahead on both sides
Date: Mon, 13 Jul 2026 17:53:57 -0700 [thread overview]
Message-ID: <20260713175357.02fb4b78c6a22c17e2001035@linux-foundation.org> (raw)
In-Reply-To: <20260713094319.771550-1-wangyijia.yeah@bytedance.com>
On Mon, 13 Jul 2026 17:43:19 +0800 王翊嘉 <wangyijia.yeah@bytedance.com> wrote:
> From: Yijia Wang <wangyijia.yeah@bytedance.com>
>
> check_file_mmap() faults a page in the middle of a file mapping and
> expects the mmap read-around path to make neighbouring pages resident.
> The test currently counts only pages after the faulted page.
>
> That misses valid read-around on systems with large base page sizes. On
> arm64 with 64K pages and the default 128K readahead setting, the
> read-around window is two pages wide and centred on the faulting page.
> Faulting page 32 makes pages 31 and 32 resident, so the forward-only
> scan from page 33 reports ra_pages == 0 even though a neighbouring page
> was brought in.
>
> Keep the existing readahead assertion, but count resident neighbouring
> pages on both sides of the faulted page. This fixes the 64K-page false
> failure without teaching the selftest to compute the expected readahead
> window from sysfs or other implementation details.
>
Thanks.
I continue to have bad feelings about this sefltest - checking on
internal and undocumented(?) behaviors of kernel-of-the-day.
Pretending that these behaviors are ABI.
But oh well, if it causes problems we'll fix them. And if we're to
test this at all, we may as well be more complete about it.
> --- a/tools/testing/selftests/mincore/mincore_selftest.c
> +++ b/tools/testing/selftests/mincore/mincore_selftest.c
> @@ -243,8 +243,10 @@ TEST(check_file_mmap)
> }
>
> /*
> - * Touch a page in the middle of the mapping. We expect the next
> - * few pages (the readahead window) to be populated too.
> + * Touch a page in the middle of the mapping. We expect some
> + * surrounding pages (the readahead window) to be populated too.
> + * Depending on the page size and readahead setting, the pages may
> + * land before the faulted page rather than after it.
> */
> addr[FILE_SIZE / 2] = 1;
> retval = mincore(addr, FILE_SIZE, vec);
> @@ -253,6 +255,12 @@ TEST(check_file_mmap)
> TH_LOG("Page not found in memory after use");
> }
>
> + i = FILE_SIZE / 2 / page_size - 1;
> + while (i >= 0 && vec[i]) {
> + ra_pages++;
> + i--;
> + }
> +
> i = FILE_SIZE / 2 / page_size + 1;
> while (i < vec_size && vec[i]) {
> ra_pages++;
> --
> 2.43.0
prev parent reply other threads:[~2026-07-14 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 9:43 王翊嘉
2026-07-14 0:53 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713175357.02fb4b78c6a22c17e2001035@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=shuah@kernel.org \
--cc=wangyijia.yeah@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®