From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E71A34CFD0 for ; Mon, 13 Jul 2026 17:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783965380; cv=none; b=PFksa22ZxjSLRWGDIqwHWxotY7zutHvLTcV8ZyfA/7FHNeKJoUvnuf1o8Z3M/2doB/RJvymFo/3LxgUvfPgcgWh8WBZgKutMV5eoQWdxPGA+m3RE1ZrHyFUKjHbGrpIKAvVsRu3wVpTjbWfBWoiBBMpAAtXMbBjv4xvpZOt02Gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783965380; c=relaxed/simple; bh=HZlJhE5yEawTWMpR2br1LMTc0/ct1LglVKv1a4251Ho=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VBV6eKhCXnK5kXH5CxJu1NuSqQ+JbsoKEuHl5BteDAZFmjUDzVyZa5Z5AAxF6agT9Ow0WVJUTvETiIkzpdOlJO6lE/w8s9Y4ofSvfZHBRyNDZbvR7hbcWh8LrJY8+ae23FBwIsRTGQJddfZSpy6qn8E1oUoGkLv4RZZp1Cb2Rq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=NESxXD2j; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="NESxXD2j" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-51bfb91795eso28148851cf.1 for ; Mon, 13 Jul 2026 10:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783965378; x=1784570178; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=C/wrHcKHA68TkDcKIgsJLD5FCo0DNb4FA5MINQ+2Q20=; b=NESxXD2jr50NXEdpf3bfSO4izmiFSGEGphusmfAyjRRbphMy+VeUUKqz5zeqdVZUPV sNs0YqgRypVu4DP4I07ygdORQtZhA5Koe7nrM4LM00wq9mOV/cPJ2syk/F37v5CYOnPX 1TgRQXC8jjy2GW5EOomeF1n8qgAAzrc3UssO8mUyvXHyHr+iTaZgtrr42RNBrZ4DrWSL p1VXMo4AFqxV1USeCR19qWJ9NN2WTk41HK2BsC2OMdeXL7ObmZ6FVF7qAPfETBaXjdPQ qJ8zQ1kn9F5Pv9LboizRGuR4jJlg83BqwYdamwZoxM0kVcnCEjn5owH40P8cqHGJ7GF0 guig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783965378; x=1784570178; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C/wrHcKHA68TkDcKIgsJLD5FCo0DNb4FA5MINQ+2Q20=; b=BuG2DwhXcJgD6odlgTwZcttiPvdMDOHgMa/X3NxY1MuXNNOa4G6/THb4CAHtMVTy1m t4/OsNfidUZy4hGxOP7WhcIjKsUBPfbNZd4K6ljfNvwTYJ3FOREocW7QbUCLXSPr2cgD B0C6SEDkV3B+T7mkvrmmt5bBSLoKYG97QEl+TL2Wh4Wad20UGq4tFXWZUwRpWZ1wUtbo OpEb6SlNsn9qvvA3iR1Ux1H18WJ4G7Q9dP4YRkCFLt3KUbpnduoyiqO5thqaFDp/g3Qj nfd8rl0V5G0a3ZtBBxD47dPYOmFu0+v7Hdp9XnuMrh36zVfHYbD1PbebAISfwLWNuSm7 E5ig== X-Forwarded-Encrypted: i=1; AHgh+RpdGlpoKvh/ciceG2bU7HM94TisbUZzIYWXxBk8agW0QfsAartX+mpDCt66HOC8LULeQvuroM3xT242CLI=@vger.kernel.org X-Gm-Message-State: AOJu0YybNekjrh4hJ4/yHzM8BokZpAZTDorX1ippkfFXpvHVl48LOSt+ +AaU1r10Ibx+MraaBeteZfkCzgY9ug9d/tTKwHVtmC0aSFpgXka4AAV6wU6gbntvCnk= X-Gm-Gg: AfdE7ckfibObv3gl4XU92LJoeO6X/Kel+tgEGfxUvvXmWjALKXhsF5k5Tmu7CP0fXm0 F5p4DiVhp3LMYYGie7RTSyp9sBEDe001HgZ4c0vudJcjIUdPWJBnSqLcaV3Y2K59kgmLDnrgOBr PitPPuoqgrL/Z1gS4sbgClNaZoCrI3ZLAEV+5TuXVBFW+fKlWgdbIQV3C+c8PilaHqnXl62XhCG HD667yAKaJJ26GW4hzI9asflWFNTnr82QfLSEPxZS1dXbsdVcfZmFJWzVNIFHn4pDo+nCa2ntNC YD5lihNXlDHNZVeevV8JQd8W9eMPeOpZC+QTtHDfDOWQsHDKWezAfKixkY3T/cU1TzjGHlBUu6Y UDlDEGeD3bRR2VWBg+jHo0B6nScO4qn9+lZPXtMO9hLqXzaBtaEVjQIMRx405 X-Received: by 2002:ac8:584d:0:b0:51a:8945:3141 with SMTP id d75a77b69052e-51cbf1faa3dmr98217881cf.55.1783965378189; Mon, 13 Jul 2026 10:56:18 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51caaf5f61csm91065131cf.22.2026.07.13.10.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 10:56:17 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wjKt6-0000000Dx9V-2ddz; Mon, 13 Jul 2026 14:56:16 -0300 Date: Mon, 13 Jul 2026 14:56:16 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Mostafa Saleh , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, Jiri Pirko , Michael Kelley Subject: Re: [PATCH v7 11/22] dma-pool: track decrypted atomic pools and select them via attrs Message-ID: <20260713175616.GJ3133966@ziepe.ca> References: <20260701054926.825925-1-aneesh.kumar@kernel.org> <20260701054926.825925-12-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701054926.825925-12-aneesh.kumar@kernel.org> On Wed, Jul 01, 2026 at 11:19:15AM +0530, Aneesh Kumar K.V (Arm) wrote: > -static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size, > +static int atomic_pool_expand(struct dma_gen_pool *dma_pool, size_t pool_size, > gfp_t gfp) > { > unsigned int order; > @@ -114,14 +120,17 @@ static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size, > * Memory in the atomic DMA pools must be unencrypted, the pools do not > * shrink so no re-encryption occurs in dma_direct_free(). > */ > - ret = set_memory_decrypted((unsigned long)page_to_virt(page), > - 1 << order); > - if (ret) { > - leak_pages = true; > - goto remove_mapping; > + if (dma_pool->cc_shared) { > + ret = set_memory_decrypted((unsigned long)page_to_virt(page), > + 1 << order); > + if (ret) { > + leak_pages = true; > + goto remove_mapping; > + } > } > - ret = gen_pool_add_virt(pool, (unsigned long)addr, page_to_phys(page), > - pool_size, NUMA_NO_NODE); > + > + ret = gen_pool_add_virt(dma_pool->pool, (unsigned long)addr, > + page_to_phys(page), pool_size, NUMA_NO_NODE); > if (ret) > goto encrypt_mapping; > > @@ -129,12 +138,10 @@ static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size, > return 0; > > encrypt_mapping: > - ret = set_memory_encrypted((unsigned long)page_to_virt(page), > - 1 << order); > - if (WARN_ON_ONCE(ret)) { > - /* Decrypt succeeded but encrypt failed, purposely leak */ > + if (dma_pool->cc_shared && > + set_memory_encrypted((unsigned long)page_to_virt(page), 1 << order)) > leak_pages = true; > - } > + Was it intentional to remove the WARN_ON and comment ? Jason