From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E964C34CFC3 for ; Mon, 13 Jul 2026 17:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783965438; cv=none; b=RE3XokpiGR0XBtAZM9Yya2FJgH+OEdhSgwVo0rcBbxyMYRBfJ3Vwbed6UNpJI3zDRw+19axfWk5OQ2Pb5czt+jOtJrfAYMx6fXJmXRfoeuECFZPJIbb9Nni49ifORbrtQ7Qif2SCOAUzsjuJWCgpfCtSQq8ly/lo9/aXD2VrZhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783965438; c=relaxed/simple; bh=/p42+HpNsjMWY1GT2uoeKq2/f492YfHBxuTyaBrOVBw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZojeFhgybZGqvaE82YXo0sy74WRb/VrXbjaCIocPpvX0Bxe3OtciQIUN8Wdy2sxNH1Laz2VOCVEKeGwM2f6f47yezXFWGtbDDLwVVOYDgD7L9j5Kz9AUWifJ3y9ivWTTP7SBdhrBmZq9fR3EhObbf0cH6Si+eAIGkvdrxMtUQWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=lgPjF6ZV; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="lgPjF6ZV" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-8efbafa1bacso28265226d6.1 for ; Mon, 13 Jul 2026 10:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783965435; x=1784570235; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YGHI47Uk7ivYjDw6pJp4pRueuEDSB7hHUc7Dm7encu0=; b=lgPjF6ZVxbMDJg0tWwfH7PZN5SECceDZGHPsWNqHsaUt/EzMKhWGSZzZdGiKPM2kY+ onblgJU5hApPT/O0xgM+RpuEmYrbw8a0TQi9NKsWhXb+itmJBsRDAXUK45AXQ8Qo5Xh6 V1x6FF2+S3debIsb3hDaFnwMEdKHIyIe4tYvZ8Bvw7WYpw8zgUJVgB8fntgtI4e6Bgsg Cep4Z7d4HtgKVzlfCP+LpAoYYnnvazknuEofog2E7V7+CcVypzYIB5WHGhVvkM9jnKhH CWkYdtDiGYOK4tBh+xehYPSg1ORre4KeHWeDJ1VCajbxsOiPaFjbvK7y4Qjl5gtFphyN OqOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783965435; x=1784570235; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YGHI47Uk7ivYjDw6pJp4pRueuEDSB7hHUc7Dm7encu0=; b=VCC8bqh7RKhVhA8/zAmIdYfDbQxUW+O8WHnqE1rUWScp5C5o2RojZmQPXd2e/U43ln YqENEsGkyDFb84rigOUIwNqf4/ksqdFxJjqhZhUIXrjzfxGb8f0JliFnmfeC9suW3h9U xr8JV4Oun2uDi3pEXLKxAwNEbIZmVMyzd3U2sGoEvqGkARUadCIzzSlnwlf+HW5zn9qO OvmDCi2ydodxSZzWBG+97rNx+hfSXceZYfxCHHQyb98RxAstg41sW3RWI+7ABeabhxlx aEX6jmF3TdpDVcR10Xz/sl2PvZg5C+zxNnYG4i48gjrcXtXoHxIDfx6gM1myj4xPSsis v2kQ== X-Forwarded-Encrypted: i=1; AHgh+RrUfz/8auIJAZlH/KA4GwV0JhkcUAwguhqOTiilXUzjBBSnxpLjm/2fVZcUBTUfQSmk6aFZ4BnjJNKmuY4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0xsOJ0URPZew790rtqXKou5Yc+mjrCu8LOJYVwgtA8sHvfUTR krJX6e7GuEg2zYP8kw3lj3bCCRblmofzTiLP0McTP2vJdYcAG4mCiimB9p6v508XYkg= X-Gm-Gg: AfdE7ckquTBpRkBgPQGTjLPVMGnUMIgM00SaXDj/AWNme6kP3Xq1QmQClAarj4fP8gB BaE7qq2Rv11Cu2t2AnSOyuXJnJS6x7amVtcdSk0oNE3G+S4K4IcaTh6Hs3ECgbyYPwESAMM8Jwq ep1WiJQ38GTYwv7btscgLBKSH4G/IcT3nkJlVS3iYUOV/uv0KrE8mnfMRud8qFjKApgZkGC/VdF 3S3npNK1XbyYtMDkd5ZQuo5KvLFoXBrGGnF4NO40hojFc3nwBfQx2MsZLx6TsxD1hsI4gTNmuYS pBK8NnzHQCeZQrMpKTLA8lpiO7+WQcvRF4Z8uehQPUcaMFkpDdvSn6wu6Xb5KfY++lww1BhWUyZ ZbBfEZ7CoaQg79GdVkKPvSM6MAHnn4BJEFO7cT9t7BDHCAGsLNLU0crTJ6YD2 X-Received: by 2002:a05:6214:5012:b0:8ff:60cd:8174 with SMTP id 6a1803df08f44-904053d8c92mr120238636d6.60.1783965434905; Mon, 13 Jul 2026 10:57:14 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd50e082csm149305496d6.5.2026.07.13.10.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 10:57:14 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wjKu1-0000000DxAz-2t49; Mon, 13 Jul 2026 14:57:13 -0300 Date: Mon, 13 Jul 2026 14:57:13 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Mostafa Saleh , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, Michael Kelley Subject: Re: [PATCH v7 03/22] iommu/dma: Check atomic pool allocation result directly Message-ID: <20260713175713.GK3133966@ziepe.ca> References: <20260701054926.825925-1-aneesh.kumar@kernel.org> <20260701054926.825925-4-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701054926.825925-4-aneesh.kumar@kernel.org> On Wed, Jul 01, 2026 at 11:19:07AM +0530, Aneesh Kumar K.V (Arm) wrote: > The non-blocking, non-coherent allocation path uses dma_alloc_from_pool(), > which returns the allocated page and fills cpu_addr only on success. > > Do not rely on cpu_addr to detect allocation failure in this path. Check > the returned page directly before using it for the IOMMU mapping. > > Fixes: 9420139f516d ("dma-pool: fix coherent pool allocations for IOMMU mappings") > Tested-by: Michael Kelley > Tested-by: Mostafa Saleh > Reviewed-by: Petr Tesarik > Signed-off-by: Aneesh Kumar K.V (Arm) > --- > drivers/iommu/dma-iommu.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) Reviewed-by: Jason Gunthorpe Jason