From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A00E353A88 for ; Mon, 13 Jul 2026 19:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971158; cv=none; b=eeHVQsJNrHjuziz2Y4hfxlvJ+S3Wqe+Cx4qb1/WmsrDOpxPsWBznls6JUz9lDwMDa6BSZBqhy4YPwcVQvNvMc7fq81WA4A5XNaicd2DBs0EtQG0BXG4uny2NaKgUnQu8ZGHWzUUJZQeKOC/UmqC+1hB4PuJUE4pyXn7EBjbxBOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971158; c=relaxed/simple; bh=dY77Qv0+81lzwLVi7S75dyv+70oXXvgqRD8f0qnW9jI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F+jok26kOFJyuQ1x402Nj6XZbZ0yaAuX5uxnmixZd0lb/iefX9kfDKf7mnd5E835fua6G8oK4S2KBcoGTFmzNN4pRG+HJxfKO01JUDrvm9+WPMWOw4v4ckELRzOYBFNJmUXi8o1tv87f1rtxtbVgFGir0KUjNiuY0j4txrgVIiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=inMOxye9; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="inMOxye9" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-51a868b6962so33558071cf.2 for ; Mon, 13 Jul 2026 12:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783971155; x=1784575955; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hGsZNW66zFo4mTPQ6ULtWG3KXt/fdlFbCgUmJIue0mw=; b=inMOxye9VtNDwffxWsKVp4mhSB13/q2dGQtDHN0OO3t7T9o86yNp+XAS28wm2nHWMr u+cgwVdVR9XpgiXRbB40jlB+pRIKzrXFpVliDM1r8TVg8r6qvkZMr/2V1rxVQkux91Ln kjyylpJe1sOtKC2PglhEFJvachqt9PuHn7wHkZGshuKZrvaq2x5cWZHk/aInNzRMc+ol Xxk/U+0Ta4OU/1QFYJf/k5svCBT/w9tPZ97ngPhYxru2j/EQn/+MEIfkrpeySimj++cy ZVesCYW3fTDTjuS3ZBy/KoO+CfVN6cQECq0eA4qsjmshk2nwuwcp1c3Wg7I+btS4DZgn 5Y0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783971155; x=1784575955; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hGsZNW66zFo4mTPQ6ULtWG3KXt/fdlFbCgUmJIue0mw=; b=eQYU0TUL3EBoMcdBdGHU0A8sni7iP9P5f9uz9X7KNMbFoKxqXsRd8DOFjCFAW7MC42 O7zq/pcNYPkSaX6+l32MitAAQv/JHKX0Giqp+NnAUjhfdjV27+KDhqZXIeojmEENBR9m 9FfAQfOKAHntyf+7psSRYJmCm+RSsvqTRSMe4lXbl2MFMHTUjQTNPpffHanIQW4mpFqP /6U0q0Ilc8W5mOKL7sNAMndccdGpDmUzu6o3GgAm6u/ofq7+DAfHCjlqzL9fK11tUNUM bcetD5slkX4Xjmad2ZpjzIpd5Qg3FU+iwkwmkDl2jmlYkQZYPyej/GK1PKjvCaqpLjWt v8IQ== X-Forwarded-Encrypted: i=1; AHgh+RrX+DFkp734zgwET/VZh9a45nRt8HbmvehxJNpcj6fiIa7meMYKBlknha5glMtMceLiydMpeAxUOIaurBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzVCfqRht4gfu/OwU6iNBxLQm/UuQql9j9v/wNOIExzCVUawxB+ I/kxDv/rmNCn4lX/4V3fV66AMo+udEti9mjrrnW0lQyXAyAtskO5hBThljV+Aiyb3p0= X-Gm-Gg: AfdE7cmuS/W9H+mhActLf0E1VHsIHsgCM7kmNSymZhyy0SPZj+U11TDz8XQhiMJfn1U qjZmB0UFZRcmr6N2Wg3pWaZCaesIaj58oWmuFfqfqR8dqilBfCUHCsOqejeeKOvQEaZVvfEgkyF C2UGjzLkz0Cqo0wtj4L+tIF4B82x0SLTM9k61w+GikxOFvuVGf9oIfyCt8blEfG3IFcibPRYiFS 2o1vnYXyJxcKWN5O7ppKw/GhxI7evVZaf1mVvHlJHJ6nO0MSE37QOnp9UJ5qzlcsAgmZS3Mtu0S UnZqb22RKuaJrU0UKrnrBwvD17am9sw3sEA+nAsqe/3mok9eOWb2iFcYfd11O3KIPN5l2iND35x uFQsRtuzt5s4gTpC6Fx+DKWGS67aRXICE7n8y2Ip76vt1udpnBs1BowSpFsLX X-Received: by 2002:a05:622a:1b22:b0:51c:18e4:38ab with SMTP id d75a77b69052e-51cbf2ee945mr103155851cf.66.1783971155509; Mon, 13 Jul 2026 12:32:35 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd7c1ec84sm138505026d6.29.2026.07.13.12.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 12:32:35 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wjMOI-0000000E5wx-1usj; Mon, 13 Jul 2026 16:32:34 -0300 Date: Mon, 13 Jul 2026 16:32:34 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Mostafa Saleh , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, Jiri Pirko , Michael Kelley Subject: Re: [PATCH v7 16/22] dma-direct: make dma_direct_map_phys() honor DMA_ATTR_CC_SHARED Message-ID: <20260713193234.GV3133966@ziepe.ca> References: <20260701054926.825925-1-aneesh.kumar@kernel.org> <20260701054926.825925-17-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701054926.825925-17-aneesh.kumar@kernel.org> On Wed, Jul 01, 2026 at 11:19:20AM +0530, Aneesh Kumar K.V (Arm) wrote: > @@ -88,37 +88,40 @@ static inline dma_addr_t dma_direct_map_phys(struct device *dev, > { > dma_addr_t dma_addr; > > + /* > + * For a device requiring unencrypted DMA, MMIO memory is treated > + * as shared by default. > + */ > + if (force_dma_unencrypted(dev) && (attrs & DMA_ATTR_MMIO)) > + attrs |= DMA_ATTR_CC_SHARED; > + > if (is_swiotlb_force_bounce(dev)) { > - if (!(attrs & DMA_ATTR_CC_SHARED)) { > - if (attrs & (DMA_ATTR_MMIO | DMA_ATTR_REQUIRE_COHERENT)) > - return DMA_MAPPING_ERROR; > + if (attrs & (DMA_ATTR_MMIO | DMA_ATTR_REQUIRE_COHERENT)) > + return DMA_MAPPING_ERROR; > > - return swiotlb_map(dev, phys, size, dir, attrs); > - } > - } else if (attrs & DMA_ATTR_CC_SHARED) { > - return DMA_MAPPING_ERROR; > + return swiotlb_map(dev, phys, size, dir, attrs); > } > > - if (attrs & DMA_ATTR_MMIO) { > - dma_addr = phys; > - if (unlikely(!dma_capable(dev, dma_addr, size, false, attrs))) > - goto err_overflow; > - } else if (attrs & DMA_ATTR_CC_SHARED) { > + if (attrs & DMA_ATTR_CC_SHARED) > dma_addr = phys_to_dma_unencrypted(dev, phys); > + else > + dma_addr = phys_to_dma_encrypted(dev, phys); Maybe things should be adjusted so this can be phys_to_dma_direct(dev, phys, (attrs & DMA_ATTR_CC_SHARED) ? It would also be nice if swiotlb.c could do the same Stated another way, maybe we should get rid of phys_to_dma_unencrypted/encrypted() entirely and just have the bool variation since that seems to be what everyone wants. Jason