From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313C53B42E9; Tue, 14 Jul 2026 12:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784033100; cv=none; b=lorElCS5IPxN6JvImh9S4bZXgcH1eFYJPUw9ZmVT0WneF/3oPAsDy0eRAeLORiIJioMhwXN0aoT0ZiOuLO2MJfIlF3+HO64jGNdgXpIrITsnH7OfTKgwpms3vXi6pIxuq9wkEgmzcTvDoF9HxR0x/6wd6NK3CnaeyLVGKwNseTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784033100; c=relaxed/simple; bh=HQi9+WXJ36H1mtRwYsG6NMNnHpxUitC2EHPxgWZq3AY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WFQehVfPhe5fV+nA3mUfuxwtK5Hg2Rc73Nx3Aq/Tr/p1ux7Gbj8EeqVzLXm82Ew+/bdpRyuhssNBmOT5vp+VjPFxoP/lp2CMbJow0LkD1zLbuB/LZNU+mXaGmYEdZgE3H/qTeN7/Ikp9WSLIPRK/vvN0j2rsnLL9eUUMVXHjlb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A8JRblj/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A8JRblj/" Received: by smtp.kernel.org (Postfix) with ESMTPS id C45F4C2BCF6; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784033099; bh=HQi9+WXJ36H1mtRwYsG6NMNnHpxUitC2EHPxgWZq3AY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=A8JRblj/x+s1q5n5/JejuGtCGZsckUvQRe1Isxa1NOqMM10mVKCnEmBAqDc71hNBl 4bL/YhG/5brV5QQL41/bFsdAvyMG3Ojke+Q5tQin3Oelk1zuc8PxMnjgLC/JAWQL9C 76foVJLDT0FeyCtauTQNjT9COC3Ys4ETdUprFx/2oSPjNdsH76h7V5UPb/7pW6iIp4 vLQXb6yX9DEd2cUFiBcE9YAJXrWSTiB0N5rUGnD5QH289/MAuU8Vx4UPFuD8A5+2jM dXLRqErDTS+3ZVJQY8bTRcyllwC1jG0okdEgzOGx3Z/eqxyiA2MM/n6VI0vsCTo9qm Vuidqw1GB3o5g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A47D8C44508; Tue, 14 Jul 2026 12:44:59 +0000 (UTC) From: Roman Vivchar via B4 Relay Date: Tue, 14 Jul 2026 15:42:04 +0300 Subject: [PATCH 2/3] soc: mediatek: pwrap: use correct log level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260714-6572-pwrap-v1-2-d8e5a39cf7ef@protonmail.com> References: <20260714-6572-pwrap-v1-0-d8e5a39cf7ef@protonmail.com> In-Reply-To: <20260714-6572-pwrap-v1-0-d8e5a39cf7ef@protonmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Flora Fu , Alexandre Mergnat Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Roman Vivchar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784033096; l=3474; i=rva333@protonmail.com; s=20260510; h=from:subject:message-id; bh=xCzQlof4bTy3lyfGICVenLAtisdpBRuoLhm9lj1xxcA=; b=tFPaWcSgTeyrtuEKazGDhaavw7PSk/bmCsLQdhVZBvGV60I/L96kMUtY7FDNlZ51cFwraAJTe zaElgfCUqgoByKgIGVoz7g00W3aKLxuExk3ZylCMiu0hmVBVVerT5h1 X-Developer-Key: i=rva333@protonmail.com; a=ed25519; pk=zww/nWjBGoQ4POXCG0BV6fx2iuXK6jx77rsKPA5YK5Y= X-Endpoint-Received: by B4 Relay for rva333@protonmail.com/20260510 with auth_id=777 X-Original-From: Roman Vivchar Reply-To: rva333@protonmail.com From: Roman Vivchar Errors paths should be dev_err, not dev_dbg. Replace all dev_dbg in error branches to have the correct log level. Also simplify dev_err and return with dev_err_probe. Signed-off-by: Roman Vivchar --- drivers/soc/mediatek/mtk-pmic-wrap.c | 45 ++++++++++++++---------------------- 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index 0bcd85826375..a4b10b0a97cb 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2475,10 +2475,9 @@ static int pwrap_probe(struct platform_device *pdev) if (np->child) of_slave_id = of_match_node(of_slave_match_tbl, np->child); - if (!of_slave_id) { - dev_dbg(&pdev->dev, "slave pmic should be defined in dts\n"); - return -EINVAL; - } + if (!of_slave_id) + return dev_err_probe(&pdev->dev, -EINVAL, + "slave pmic should be defined in dts\n"); wrp = devm_kzalloc(&pdev->dev, sizeof(*wrp), GFP_KERNEL); if (!wrp) @@ -2496,11 +2495,9 @@ static int pwrap_probe(struct platform_device *pdev) if (HAS_CAP(wrp->master->caps, PWRAP_CAP_RESET)) { wrp->rstc = devm_reset_control_get(wrp->dev, "pwrap"); - if (IS_ERR(wrp->rstc)) { - ret = PTR_ERR(wrp->rstc); - dev_dbg(wrp->dev, "cannot get pwrap reset: %d\n", ret); - return ret; - } + if (IS_ERR(wrp->rstc)) + return dev_err_probe(wrp->dev, PTR_ERR(wrp->rstc), + "cannot get pwrap reset\n"); } if (HAS_CAP(wrp->master->caps, PWRAP_CAP_BRIDGE)) { @@ -2510,12 +2507,9 @@ static int pwrap_probe(struct platform_device *pdev) wrp->rstc_bridge = devm_reset_control_get(wrp->dev, "pwrap-bridge"); - if (IS_ERR(wrp->rstc_bridge)) { - ret = PTR_ERR(wrp->rstc_bridge); - dev_dbg(wrp->dev, - "cannot get pwrap-bridge reset: %d\n", ret); - return ret; - } + if (IS_ERR(wrp->rstc_bridge)) + return dev_err_probe(wrp->dev, PTR_ERR(wrp->rstc_bridge), + "cannot get pwrap-bridge reset\n"); } ret = devm_clk_bulk_get_all_enabled(wrp->dev, &clk); @@ -2535,10 +2529,8 @@ static int pwrap_probe(struct platform_device *pdev) */ if (!pwrap_readl(wrp, PWRAP_INIT_DONE2)) { ret = pwrap_init(wrp); - if (ret) { - dev_dbg(wrp->dev, "init failed with %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(wrp->dev, ret, "init failed\n"); } if (HAS_CAP(wrp->master->caps, PWRAP_CAP_ARB)) @@ -2548,10 +2540,9 @@ static int pwrap_probe(struct platform_device *pdev) else mask_done = PWRAP_STATE_INIT_DONE0; - if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & mask_done)) { - dev_dbg(wrp->dev, "initialization isn't finished\n"); - return -ENODEV; - } + if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & mask_done)) + return dev_err_probe(wrp->dev, -ENODEV, + "initialization isn't finished\n"); /* Initialize watchdog, may not be done by the bootloader */ if (!HAS_CAP(wrp->master->caps, PWRAP_CAP_ARB)) @@ -2593,11 +2584,9 @@ static int pwrap_probe(struct platform_device *pdev) return PTR_ERR(wrp->regmap); ret = of_platform_populate(np, NULL, NULL, wrp->dev); - if (ret) { - dev_dbg(wrp->dev, "failed to create child devices at %pOF\n", - np); - return ret; - } + if (ret) + return dev_err_probe(wrp->dev, ret, + "failed to create child devices at %pOF\n", np); return 0; } -- 2.54.0