From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE8893845A2 for ; Tue, 14 Jul 2026 11:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784029334; cv=none; b=K7XBW+gOcWtZq05TgW4gp5WjVVQ4ICJXDdx3+vKV6EeeqKgnb5vRxKGorl5Yl/h2Y8/aCovjUxF9Rf+JYn1QsZLOmEK+B6gjO0Vxpqn269ESrtMzmNcl7ugeqbntjPyRzLvOQLhFRs5FfNgBU13h4TQkXQk7Tm3xLKy0qGzXbNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784029334; c=relaxed/simple; bh=Ci/F+btcp36I+3z2i1o5BD4BDvCN0o1CTvBe8N/qwOI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TeeQVP2+D7Cj5y8L2Ujvrht34AfNUZHFm2CskmpP4SmktJyS8Fi77X0AAgreEttaBfO1yPqZSFPwH0Pr3lX/JkpXJvvm+eWJLcr2ulzGsU+3rcS6YrFvdl7KhG7EbLeYsY9G4Lx4ksNMwq9/sMoOVS8KKCXwDF/gLlNHqOBrpXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=bL2Z1Evi; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="bL2Z1Evi" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=vxB4o+e47F8wE78A9xaCMTbiYexwMX39O+F4unlip3s=; b=bL2Z1EviKMFYaz7ryYvdXwUcem VlQo3NmkZa+P+oVHaX+mK4Qdnxdr1XJaSSuL3A+MUU4QYGgDg/KdoeaqbZsf6fS0qM/sran8UmFVM ZEDdA1F+5jtfapxXYTRFy8INuXUO2kA+w0u4RX/0CvkCCSNWMJ4Ux5qcOyiVuQ+DkNmvLBFTELtjD g/S+muaWh6qMRCxzsdjynYx2CQfd0X33HEQTpPq3SGcf0BuML6h/1BrLdxLmNg0l0uFvZwgMI/FVF aPaivtFwACPo9J/Mhdoz8XOjUoATyrF7dlVRQHs0rQ8/xJKB+SfifPmuWU8iagl0EVRPVITf0CHkr f/aS3fDA==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wjbWR-002FZK-2j; Tue, 14 Jul 2026 11:42:00 +0000 From: Breno Leitao Date: Tue, 14 Jul 2026 04:41:48 -0700 Subject: [PATCH RFC 2/3] workqueue: allocate percpu pwqs through alloc_pwq() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260714-tejun1-v1-2-024d59241386@debian.org> References: <20260714-tejun1-v1-0-024d59241386@debian.org> In-Reply-To: <20260714-tejun1-v1-0-024d59241386@debian.org> To: Tejun Heo , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, marco.crivellari@suse.com, frederic@kernel.org, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.16-dev-d5d98 X-Developer-Signature: v=1; a=openpgp-sha256; l=1358; i=leitao@debian.org; h=from:subject:message-id; bh=Ci/F+btcp36I+3z2i1o5BD4BDvCN0o1CTvBe8N/qwOI=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBqViB9A25NhlKR1BNHpMi9EfTPxMJxNTzO7Z34M WXHuui83eeJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCalYgfQAKCRA1o5Of/Hh3 bToGD/4n/ImUjcnV+zps6QvV/tYqGjHSIip3W2rg6KttA76jZHwSQCWyRAKOxwklxCdTzVCHnm1 j/ytJY+tc5vFxeel/9NqW4AZawQRiwhrOmJHsYTQEcOaTkzngublBiOflG4lsSKvqTPkY1JlaBD aDEeZp6EkTCJstpBwZzRUef8Z3RZrrhcJ4b0vDLAXcFXjOshAzclEiDPCAD3xdEh+16v4ITLBbH L3ZTSP+NrIxk0e/v/eSJnxMbGjs6TfZth2AttCCHvc5PN9OiudNLII+S+r7hWWp6pWk6ianiNEn v5acHVscVy6sTrloa9Kagy4SBi27vuEtopGgTz6djwNwM3aAa10qePLKIP8LK/H5aZn32w23PWR QiU2sG22bX7LfZ5BU0hOdp4Xrk+n5QBeYZkmJ1FxkSQQz0hsQb8y79IySaLGfV6ykpU4DjYtuPg 7Fs04ScgdiYz0u0yoqnYRbT3YjVg98QUDP9Hp48AZULCd9sTvNwIQk8fmLTKlZDDewe8wFNbTvB TaI7YwP4xy8mfGpUUi6ePkBv9GnX1FHYcvWyiyJFEZIEaPA0V6rfFBv2kMVCz/IVEWWDOJDTyJ8 eTi+YDniZtYzLQPRg7W3LKChnWQeFQBJxlpeNgLOqLV/RYprtpUpp8zLaPMhWKEIivPARRkSiim FYNAnFLj85bLQug== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Route the per-cpu pwq allocation loop in alloc_and_link_pwqs() through the common alloc_pwq() instead of open-coding get_percpu_pool() + pwq allocation + init_pwq(). alloc_pwq() is now the single entry point for both percpu and unbound pwq allocation, and its percpu branch is exercised for every percpu workqueue created. No functional change: alloc_pwq(wq, cpu, NULL) on a percpu workqueue selects the static per-cpu pool for @cpu, exactly as the open-coded path did. Signed-off-by: Breno Leitao --- kernel/workqueue.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index c32e173af2335..50baf4fe5fcf5 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5703,15 +5703,11 @@ static int alloc_and_link_pwqs(struct workqueue_struct *wq) if (!(wq->flags & WQ_UNBOUND)) { for_each_possible_cpu(cpu) { struct pool_workqueue **pwq_p = per_cpu_ptr(wq->cpu_pwq, cpu); - struct worker_pool *pool = get_percpu_pool(wq, cpu); - *pwq_p = kmem_cache_alloc_node(pwq_cache, GFP_KERNEL, - pool->node); + *pwq_p = alloc_pwq(wq, cpu, NULL); if (!*pwq_p) goto enomem; - init_pwq(*pwq_p, wq, pool); - mutex_lock(&wq->mutex); link_pwq(*pwq_p); mutex_unlock(&wq->mutex); -- 2.53.0-Meta