From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAA8D2F8EA6 for ; Tue, 14 Jul 2026 02:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783996158; cv=none; b=orGU5th53/wFU1AV20DCEkJEpoV+O+EVaQgNZ79jbbP0wwvEaF3atE5LnSJObXKoPwYN/Qge+f9+apiWOBDLm1BkqHDdSdJqxun9rIthGIN2tMc7i3jWbclFVphUvwIf4VqD1Uv/cYaMMOQm5PiEX9XoiQONiFh4h2FvZ12Bg7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783996158; c=relaxed/simple; bh=Ogf0c96gmvFtj7+Kg/2HQ2FnTL8f6Vlo1YUm+lu9MPk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=q6FHqxeBu0XvZIwHCbJoiigrC6h8xs/le1QktubPjAu834fk83UQMp6/WymMEAAuSpzm7cqXHTHetsbTmJKbfpw2QPYSebLDi4IF5YAm/1xu9Jv/79J8P+4ynp9AnKMrWnBJhB9wnEVL4U5HBuNj5YV6gzvSrbmkpUyBjDRKtRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X2IenEL6; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X2IenEL6" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8487b7b3fc8so3214353b3a.3 for ; Mon, 13 Jul 2026 19:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783996156; x=1784600956; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=u5bPrUfoJACi9BYyW8xq/jkNYTvoED+3Sp0FVeU/kPo=; b=X2IenEL6rOnBCMe76aNVjAf0lPtXZKyRuO6SqQCI+m1Sf6jY7gYYl+qMgYFSK4NQul sENfPtVcQf+9QHlf2LX2yynU1D6FUH5eUoCPJfBQg8D5LTcXfFsomPcqdF/Yu71CAgiZ YbFjDI3gavQbAFHO3W+6Tv80URMX67MsRT4vP06rUvauT+mn3UweQUCqbC4PFSd4A5VP bxtKulGcnqeiiSlJjap57i2W+vfU5UhnFf05pIm3w36iq578S6ma+gDQsq5azAKYleye HB3BwRHhe662RVWkSSnB+6A9oSPBh+8hbAL55FSxisrMXgXJQpLUUHl938uEtjrVYOrP tEYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783996156; x=1784600956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=u5bPrUfoJACi9BYyW8xq/jkNYTvoED+3Sp0FVeU/kPo=; b=CXvYK5Q+oe1ViUF3KEt013QHvCodVyac14YLMytMxpnW2d/BGXdpz/H8GaOhwp5nCa OO6itBCeuxuwu83glWipz86+Uo4ku3z78Ga4DPY/zfnyO+pZ31t6I85wJdkhZgPv0Dkr iLwm8KT7q84kyL2GOIhLVyNIO9DItkT8QEyiakrdu8dwM/8f6qbdSuRHTWcd8BlJpSGO pVk8b9KB+fENvxuY4cziNNTvhqtzImbw6r6baUX39Be4DtHr+YpfOgdthEgTMbiUf4fR xkmLurUZ2yxyiUZgudEwMQqBmWfyuMy1IMn8QnAoy46siObyyFjN4PVkuZFzAMd8wZhU eDLQ== X-Forwarded-Encrypted: i=1; AHgh+RomF7xt8jt5cbW8lIS6mPghgrsDm2wV9vKzSSrC18XpOcwaBi/9Y5aYAgGnX35UUQMeeobthRMC0kfzcB8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8kwQMJaiUrCMOLskqe5yN0E5PmdkN7n1vHu9NW4M/3TTROyxm +g4dK4ZVB7oTcEu4162SzdNjGWBGkikXTLXc3Tw9eIkgdqM9x3pXu8Il X-Gm-Gg: AfdE7cl1ZpzGHBx/bloCBUxTDhP1Q1e67KRRl7zOuatqoTZskDQzdAq9L5RbWvBWKrN 8KI/gDycHknWsLCeAX1WiqAwx0p43CEq7NqTBG3tBOxiUIarTtqHQG2jij/40WV10UGAXMv4klB zLCDr99MYZMynE6meT3sfYh2gTqinhU4WXpFRP/uTw8e3i5EQ62/C/6d0xjjcyDEoLZDoHp4EcY zEclokfkCAN2bFQLscblNBTTe6c+AS/pXODf9lYSSTMoZlDZnN/skgYuewUCZQfhIAD1MCjBUOB Re4kgQdmgdZ0bYmHHtmA1AkleamGEGjMnKIchORbS7B5O6Xs2F45q865nzB8FxzjcwieijUgOR7 0ywoE1wBrTUF3vXAaHxg4Zr1s9Y7mwRFOqi+JhDl4BGDcm2CHyi07tc61XyFQK+NXCv0IdxHjLy kfmvHreysJ9uzKPVjUKuAiOQ1/38rYubzR1u/540nbQf5rh4ZlLihoCuZ1way9ScPZpK+tt5TnG tM5hkhb6Lyue73+Js79vb/0 X-Received: by 2002:a05:6a00:4f8c:b0:848:7835:bbac with SMTP id d2e1a72fcca58-84a516307aemr1475965b3a.65.1783996156182; Mon, 13 Jul 2026 19:29:16 -0700 (PDT) Received: from lcwang-Precision-3630-Tower.. (211-23-39-77.hinet-ip.hinet.net. [211.23.39.77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f238f75sm664039b3a.9.2026.07.13.19.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 19:29:15 -0700 (PDT) From: LiangCheng Wang To: Arend van Spriel , Gokul Sivakumar Cc: LiangCheng Wang , Kalle Valo , Angus Ainslie , Wig Cheng , linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, wlan-kernel-dev-list@infineon.com Subject: Re: [PATCH] wifi: brcmfmac: set F2 blocksize to 256 for BCM43752 Date: Tue, 14 Jul 2026 10:28:59 +0800 Message-Id: <20260714022859.1849447-1-zaq14760@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <36f4388a-b856-438c-8ef4-795a7b1eda3e@broadcom.com> References: <20260713-b43752-f2-blksz-v1-1-8697fcfeaef4@gmail.com> <36f4388a-b856-438c-8ef4-795a7b1eda3e@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Arend, On 13/07/2026 12:51, Arend van Spriel wrote: > Looks good to me but the stable instruction looks confusion. What do you > mean. If there is no 43752 support there is no need for this patch, right? Thank you for the review, and thanks Gokul for the detailed explanation - that is exactly what I meant, and sorry the annotation was not clearer. To summarize: 43752 support has been present since v5.15 (commit d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and initialization")), under the SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752 id name. Commit 74e2ef72bd4b ("wifi: brcmfmac: fix 43752 SDIO FWVID incorrectly labelled as Cypress (CYW)"), which landed in v6.18, renamed it to SDIO_DEVICE_ID_BROADCOM_43752. I also have to correct myself here: the boundary in the annotation should have been "<= 6.17" rather than "<= 6.16", since the rename only landed in v6.18. Apologies for the extra confusion. Gokul's suggestion of cherry-picking the rename patch together with this one into the stable trees sounds cleaner to me than editing the id name while backporting, so I would be glad to go with that. If it helps, I would be happy to send a v2 with the stable annotation in the prerequisite format from Documentation/process/stable-kernel-rules.rst: Cc: # 74e2ef72bd4b: wifi: brcmfmac: fix 43752 SDIO FWVID incorrectly labelled as Cypress (CYW) Please let me know if you would prefer that, or if the patch is fine to take as is. Best regards, LiangCheng