From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F003739F162 for ; Tue, 14 Jul 2026 02:59:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783997993; cv=none; b=BY3iqJ/kXWG+FqjVEqh75dOLEMEkA2sxKgeBCAhf/S36yGFQWEgob1WNucr8sKBm/owNL2LJqvZOdo0Ie3NR5SuuGTzskRoVhv42lc+Hn0LiuFO0zUoe0GWKnDNEB3TNs9mPUrOWBY75G7skyU7O0vMTFEjtlZgxZ2g666is6r0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783997993; c=relaxed/simple; bh=rVhO9deu1bdk3yb64ULoUPj80nzZOzHqnrMXjqgLQVk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JOxt7WCxvAZXgX2atxAuhb/WvhWw5PDLuXjgyXqqfP8yDdfXrb6KLqJJQGtkN3bS2dHZ0q84RFM5Ous2S0fTGj0h+rLohiXRsus+ADWV05L1AlNMcw+jxJp8IUE2pVHY9pUC20cJ8JFLRJXcOa0FaraipynYM2fTlPfASDYXmKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=qVjxkOLj; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="qVjxkOLj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=Lh NrACahs4ufRrQbVXxlco155SnB1aDDsdao2QJJ0wI=; b=qVjxkOLjKsrN3LSBiF hi6KCcMKYQJ2s4ZoTzR695HWG8NgUgL37ONGKn/7K5PCxW4WvG+xKVk6Qxh5DBCI QZQgB/FX0YiB+P7mkBiDqmDPUsUY5pYHewte/DYNOj/bR1aiMBf7ExkwlODOIL8f w5kRuB2OozT5lnTA3VnJE4aCs= Received: from xwm-TianYi510Pro-14IMB.. (unknown []) by gzga-smtp-mtada-g0-1 (Coremail) with SMTP id _____wD3b_8CplVqBxNXJA--.48351S4; Tue, 14 Jul 2026 10:59:22 +0800 (CST) From: weimin xiong <15927021679@163.com> To: Jean-Philippe Brucker , Joerg Roedel , Will Deacon Cc: Robin Murphy , virtualization@lists.linux.dev, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Xiong Weimin Subject: [PATCH v1 2/2] iommu/virtio: Reject short event buffers Date: Tue, 14 Jul 2026 10:59:14 +0800 Message-ID: <20260714025914.193580-3-15927021679@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260714025914.193580-1-15927021679@163.com> References: <20260714025914.193580-1-15927021679@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD3b_8CplVqBxNXJA--.48351S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr1UXw4fWry7Ary7CrW5Awb_yoWDZFc_ur yvvr9rJr1UZFZ0yryUKr1I9r9aka90vrn3uFWFgrWrJ348Xws7Cryvqrs5GFW7Wr4vkFnI yws0y3WrXryfWjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0fwIDUUUUU== X-CM-SenderInfo: jprvmjixqsilmxzbiqqrwthudrp/xtbC0QqbJGpVpgqTpgAA3C From: Xiong Weimin viommu_event_handler() only rejects event buffers that are larger than struct viommu_event. A short buffer is also invalid, but the handler would still read evt->head and, for fault events, the rest of evt->fault. Require the used length to match the event buffer size before looking at the event contents. Signed-off-by: Xiong Weimin --- drivers/iommu/virtio-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c index 4c91a82d2..4b7f0dcfa 100644 --- a/drivers/iommu/virtio-iommu.c +++ b/drivers/iommu/virtio-iommu.c @@ -635,7 +635,7 @@ static void viommu_event_handler(struct virtqueue *vq) struct viommu_dev *viommu = vq->vdev->priv; while ((evt = virtqueue_get_buf(vq, &len)) != NULL) { - if (len > sizeof(*evt)) { + if (len != sizeof(*evt)) { dev_err(viommu->dev, "invalid event buffer (len %u != %zu)\n", len, sizeof(*evt)); -- 2.43.0