From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83F9235BDC7 for ; Tue, 14 Jul 2026 11:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028719; cv=none; b=aGruK0BV3EcPaFpoFyHQDFXGLWFRzCuft2vc8hB/Un3YZeYzY6SUkS5ugUfzYxlGJetfNPDiGhsMVwGLkS7F5h6o6gCyhWeOEjIuFNXoBr/NmtxoIGY1k2IFzuWxvRQNt3fmPpXbre/pbRuPwKfDvDbn7j3koSf6wFhvqxmQnfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028719; c=relaxed/simple; bh=ztaah7FswqrBKYufRFLu9xEbQVZRkHu40mWNK3sBTbE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K7ep9TRFnMCX1IMjOPD38x3GaUalQw0jK8XDZWJUgQqLmci6pVWsYK79JIFz8Rvs91Bw1rB8ZLVhoN5Ee0Jrh7avEe8nEeNfnQMBBe7qcgReNFExXmfGT5oofhCAV+Dx95NMoHCbSrbM+Lf3qe4xhvhM9cCXCpuDlbw11bqgKVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QYdyPkWC; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QYdyPkWC" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-84a2dcec51cso2485027b3a.3 for ; Tue, 14 Jul 2026 04:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784028718; x=1784633518; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QVTvsPo5yWPdElSCJe1QICilasV5G2rwHI+ghLjXid4=; b=QYdyPkWCfU+VkIUOvccwunwakrCONF2LwAWXiUaMSFOvySe+VZAZrYcNIigmaiPq5f +gPkiaE+kbqQezOJZEIR2lFJm5OOlrIjrYjNkG3HuU985zpVpA0aBCiOyIZbdVoAWlkt ZH6401kNEWuRdwRFL3TRocP7awRlB61R4TD0vFg0jxNLkImZPTggeHQt4j4BiuehHQ3i S7YPfWetgnkTRhKxNLRDZuqL9GlzoSuCfY4nysJa7jssjjmraqfofogLuVoG7nyAeYfz wdCpV/w2m+cI3LxrU3vvehiT8d2lXdBp/GjQlgVCXoPnMOild04KmeBnNjjJyswYkVwc 9C8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784028718; x=1784633518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QVTvsPo5yWPdElSCJe1QICilasV5G2rwHI+ghLjXid4=; b=UKfS5GSyN0+46g+m6fYLh58lrIaaw/9W6a6+ZA1M7w2Uv6dF0QQMh1YaB9DCQL9/zY l4CWawu22xWYPGkFugWMUxKf4brg+ko0RHDCC9xhUkCmajsG7acV0+gEs3DrK2kYa9fR Yndt14XitgXzwNcpIYW4qboy7UAdPCRhrfSOEJ7Z/GjrmVzHCIDfiV8dkhyhvi1ocHxU PbhnmOHKyDMucUqG8UCrDv958zNKEVXlhBZtZRIflkKlVM+RUfo8yQWckaAKrk1vQpGc VwktBZ4db2RTGYEwk1CZ+jeV1GuJv2F1fX8Uo0FXaBZdp1t+LsgFqH9TKRGMUD8QyI+k vwsQ== X-Forwarded-Encrypted: i=1; AHgh+RpUIuKLQVVG2el0fpfQCo5b1qqPIMx/EI3KctDbokAndeuI9BE1d1Zyq/xuVCzfQJeIux1HIj0f8XYdOoo=@vger.kernel.org X-Gm-Message-State: AOJu0YygsBJm2SHZphT7d8BEPRp/+FqSPk2w2Yk58QzJWnojG6GncU5J OVVlODEtD2p99THfgp2ti0s0cS81AOLnS9WM60vYJmrVW/4CiRHDx0c= X-Gm-Gg: AfdE7cl3brZyVicm7+0nSB/WTx/S3VqeMYGg4NI9qYaVP5y3OrTmF0Ewzk9DzYQ/BGW eYjlZoL8QkumOa/ly+4uzHa/Q3Liq0RHGhdwwn2iZG1AwyXY5+/9NRhCsU6b961q4xsgETHs7pA fXtX7vbIBH501J3fQ3VGOkyisEt9Qi/GAXlLgGBImvMZvTrIq7jlcPysrYGt+3TXZHdNjA48Mhn T0Brmh2mjdh/JUnuePQ0fscy2Ug/WNWiENgjZrEOtkWdGiCQJJdxJDQuK+x8q/qMu/Eh/ew6Yah c9J62haAjSqRYbWSuh456dGIDvOVQ329K9pH9sSoLExTel1vdvWbs5zANIhXQCYyCs2V52iQvc9 6at8tm7t5cyDSPKsMTcBAGsaakmJTU0sfmjgapa1Uc7oXQL+aQ15ioRwBuzBgmIRqvmu4ymuMGH XdIR1247JrCrw/coSC54ZLoBfjwGWX3+T0ijm5IBF7xbkrVYvWbcJv X-Received: by 2002:a05:6a21:7a8b:b0:3bf:9aa9:b2a4 with SMTP id adf61e73a8af0-3c357395a06mr2281496637.20.1784028717926; Tue, 14 Jul 2026 04:31:57 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f72a6sm95357368eec.1.2026.07.14.04.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 04:31:57 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v3 4/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask Date: Tue, 14 Jul 2026 17:01:34 +0530 Message-Id: <20260714113134.3445-5-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260714113134.3445-1-nikhilgtr@gmail.com> References: <20260714113134.3445-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit GENMASK(h, l) requires h >= l, but OPT4001_CTRL_FAULT_COUNT is defined as GENMASK(0, 1). The define is currently unused so there is no functional impact, but fix it before anyone builds on it, and add the _MASK suffix for consistency with the neighbouring definitions. Fixes: 9a9608418292 ("iio: light: Add support for TI OPT4001 light sensor") Signed-off-by: Nikhil Gautam --- drivers/iio/light/opt4001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c index bb4be6384e4c..731eb8d7326a 100644 --- a/drivers/iio/light/opt4001.c +++ b/drivers/iio/light/opt4001.c @@ -39,7 +39,7 @@ #define OPT4001_CTRL_OPER_MODE_MASK GENMASK(5, 4) #define OPT4001_CTRL_LATCH_MASK GENMASK(3, 3) #define OPT4001_CTRL_INT_POL_MASK GENMASK(2, 2) -#define OPT4001_CTRL_FAULT_COUNT GENMASK(0, 1) +#define OPT4001_CTRL_FAULT_COUNT_MASK GENMASK(1, 0) /* OPT4001 constants */ #define OPT4001_DEVICE_ID_VAL 0x121 -- 2.39.5