From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010069.outbound.protection.outlook.com [40.93.198.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBCB6389106 for ; Tue, 14 Jul 2026 13:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.69 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784034626; cv=fail; b=M/OsjrK9os5eG69aEW4SfPATrQEauLNAMAhfYXvuUYFcNUIYAGHSJNBa1Gwf4n69E5ZfQ3tjgXzvM2iOb5myg0jAfaeMnct9jFpckRyI/TFjFVgk4Lt62K94l7jXsk0PGSjIWFXizHOBS/ZwIz9cDk4IqAQNKalGAsXvVCSbR5Q= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784034626; c=relaxed/simple; bh=czz989N2Hy67VS4/KEPErF+jPJaGYlooKf8+VBB/D3M=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=A6dX7IOuSpdLDHfNV5DT2FwYYGkod6vbDhfmwf/AI8TK3wEAMIzg5VT3s/4ho5MXrkpj2pO5QLfMgdZCPE6JxJgjvN66uhNdRXAsNy2NDW0tRm4eGl+F9RhKXT9hSQk3Lui+MogjNgJGgK9NRI+8c19UwtgnN5DIbK+pyQvT7TI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=EDLd0QV0; arc=fail smtp.client-ip=40.93.198.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="EDLd0QV0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AMCBLUtBm2yGikPkdznHRViT0sQm+wLANhreQ6rAewJSuYG/DHu+6D7nFVTSKQWeV16ZvlDQUXW7EbwRKhBovrMfK/DGUKPe4nDOlZVvUdkA2lpcmie7Oetiib7pBzlNvcYpKixFGWWXRmNLwA6TVd7TWRrDl+4JH1NLXXAz0I6D+PQeVeYPdugXF/K//46+qDW8eSmFyrVdHpc7+7m4liW5/cvGLfyXW1S/sEVrROdgNyViCJOyqSbS4r3d7mbct3ysURPvX+t39lwtN51xB99gGk5tFPQZReLCCqYed9sQw9KQMJvBBleYP+R1FYz2thieUKTPDaekoYlrHaXicg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=31hqY1IVYcQ7QODNmhl3sKMbZmb3TvjgQHo2jUzB53A=; b=UoenSXqhubndP7G1XN5aWaAnFriklcYKGMBiSrJLzicJ074QCQRTz839ugSnNM1uTsPdLBbb7/3DdQ4miv9wYHVk6xOHX/oD35oPPRw0ZqdFSLltNuz7u2JfOoJdyKnwgjGOfMK5MVApQtdx9B3akdmk0Y6+gK6rcBfy89jtt6/aOqS9mRBhO9AFmsMQEiY3VaWtNt9zsdVTpZUKUbtrchvjVChpNwSJMDAHhQRc1GzxJMKD1j/NKqGpZcMcIrO1Sw+XicxDgu5zjwkVBbekXiE7JHYBkq8LPa1gUnodpE4REbVo5Vk4/3apTOdoFojdMbJv1MwTczTdqMWonA1rpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=31hqY1IVYcQ7QODNmhl3sKMbZmb3TvjgQHo2jUzB53A=; b=EDLd0QV0Y6kFt3W1KKj9vyuHDF3UPZZ4QzDx8RSBFBmzLCUjQ653cSlN3bCya8kI+272QAS5rHFXI/1Lb6EpzVD3fVVMp8yxDUJbWYt4lYmf+uwHnqnUCoMZtJRF9hOFxf0lP59paS9BBjDqOGJbEW6WWkTYX91Q9U8TQqDQDoE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6374.namprd12.prod.outlook.com (2603:10b6:8:a3::18) by DS2PR12MB9591.namprd12.prod.outlook.com (2603:10b6:8:27c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Tue, 14 Jul 2026 13:10:20 +0000 Received: from DM4PR12MB6374.namprd12.prod.outlook.com ([fe80::af35:a7a6:6ca:7fcf]) by DM4PR12MB6374.namprd12.prod.outlook.com ([fe80::af35:a7a6:6ca:7fcf%3]) with mapi id 15.21.0202.014; Tue, 14 Jul 2026 13:10:18 +0000 Date: Tue, 14 Jul 2026 09:10:14 -0400 From: Yazen Ghannam To: Lin Wang Cc: mario.limonciello@amd.com, Borislav Petkov , tglx@kernel.org, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/6] x86/amd_nb: Restrict NB framework init to AMD vendor Message-ID: <20260714131014.GC364094@yaz-khff2.amd.com> References: <20260709075549.626095-1-wanglin@open-hieco.net> <20260709075549.626095-3-wanglin@open-hieco.net> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260709075549.626095-3-wanglin@open-hieco.net> X-ClientProxiedBy: CH0PR07CA0002.namprd07.prod.outlook.com (2603:10b6:610:32::7) To DM4PR12MB6374.namprd12.prod.outlook.com (2603:10b6:8:a3::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6374:EE_|DS2PR12MB9591:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f7deaea-8ed7-413e-b46b-08dee1a940aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|366016|6133799003|11063799006|4143699003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: CMKJb+ZaajmrTrJEVCMVOAci3E6cPmg5CxO/WdDJn+thU6O9NpkOOIQirCIbJutnRwO86BufzjkBXL2pLSx2f2ITuyVPXQqf2SWaNnw9XVKY5dcU/ai2GhBae/MHxP1M+lkQ0hosRc4iX+5Ks0SOrKD6hiPAi3hOkFv7ZBWaWWMfHehJP50/6I9e1xz1ecabPN7L5kGC3PlWW0Wu1GixAsRz7TA9MYzd/iskMOB/QFefVjybR1vpx6eiib8PxBxxiPCteeAsPPuFlIcKL4z5jtZ31G4aa7VITsciarkjjhozONO8wH39pn89Ccb/8/PzZcrO+DRhYb3kVdTr1q+Lk+UP6ckuvKWMbuW8R76HuPjWpOVhWCO8oVMzV5Y47M7DvkjM4K6kCNDu3ej8crrVqskTbr7BwXGVZqekBsHzRgRS7iRMfmanGKpKoWJlWrPsbmzQd3AkzkhRjkp8aQmLHCoOotcBvzxEBc+1FVsA3oTjprgKtmdnA7akwV4Okxp/zk8aPK8hCRlDW0zxrHK9RvY88+NdkS496QTqGEz4anIe8Z6FtR90YQFgj0yng6VUisMLRNzqIweYMoJ4kYHVYMF0NYZPVXuBaonsU2e3/gUS2mP6jKNv7OdxQNC94aMRzMT7nuZ73KLIabkWxX62rNXJOm88MCeo9DlRevkWXmc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(366016)(6133799003)(11063799006)(4143699003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WdPUov9xMI+g2X/fSEEtZzDfRtL2qpuJ2oMGSYTtrz2ocBO7uIY7uXKBwJUQ?= =?us-ascii?Q?ytK1FHGaa7DD1klHVhUW9l84PXfgnpU+ymer3/HIeec4CXmN+BlayT5Ke4bv?= =?us-ascii?Q?kzscuIeLElyNAJI15g1ZNXeTAz7HpIkz3i/yC6OcDUfDIr/0kyYjyTEVFPf3?= =?us-ascii?Q?dDcPFDWpIdgWIkJrgKE5kJHJcvMTIEhrvlP5bMHChPzWC/A65YZesmTCDG5H?= =?us-ascii?Q?D5g/dAc7J6lMznwgNxRae3MigdtTMky4N6kDQVA2XgkzVOXidedwCtWHdTfM?= =?us-ascii?Q?AxbazVfJBYpGPVg1U0pCFmKEQGA1mNUdi+d4h0L4SN/EebwXbRO5OrmMhJhc?= =?us-ascii?Q?8XcDdBtQkReZLFE2Z88oMBV2LU9Mrcu8PDU+oUGrbM6nNFklxOHxdO34fopB?= =?us-ascii?Q?0Y/5YhegGOo+ldA/v9FL3w81NwVHlrDOzKJv7LgWoy3rbxvtwO3C02NvWIQY?= =?us-ascii?Q?6yeTOdYG5SMFy257EJBk6aZ0v+mcc+gFdTvmIbVXd8mWlfybvTcU8rKKm18f?= =?us-ascii?Q?+OtFp5gUCTuM/E9hII582Rp5lNwwIQWJw6qmCIVGNxIC5T34MAWK5OFGoHpJ?= =?us-ascii?Q?9Qx3hgAYoppBpittfNhp+lruPK4aoZCCfCag0DIUQN48ktvgzBy89A3GMnb+?= =?us-ascii?Q?HQh79bELD4KJ1Yagv3RICnrCb/8dlS0CfCW0U6m1hEp4frnefAzF3JI+fr7Q?= =?us-ascii?Q?Xl/7xUgUTtX8CnHXGzbsqEa+d3PWzWjU2zRzJ0GITrJr/QS3vdaXFwZ42hHH?= =?us-ascii?Q?yd6sHvycnFXqPhSGyFnxg4r+UdWrG/DcczzHTtuyfXH/LD7lQ1A3QvZisYOU?= =?us-ascii?Q?rGlsv5SOwghHmaRRUtDSXpxK14E7svpQqhdDFe/r94Eivv0ZA+9iCC+gfW7h?= =?us-ascii?Q?+UeCNRhb4GrSXmWdxXfr+vcIgSYdr6xfMMl6PDcL5nzp5h+E/uWsdajJIeU/?= =?us-ascii?Q?Gom1xEehnn2dQ8aRn2c5p6+JazFlJMdhHFCpFIUC5EPOEmeEZMAOM8SQzMl6?= =?us-ascii?Q?yUaj7+T588Viq8BvMRRjnqRrcrW4xmwMhJl8uuFEH0PMU3EU9WZnnACupePy?= =?us-ascii?Q?nayOzsG/lolqKAPtZqov0W6DKvLVS/ntnrP9O4GX3yvpTPA5ylfBBeAOY3DB?= =?us-ascii?Q?dQkokXyQM9dWtVTgyUyYK3+A1vkknIS1ZlpCyM+mqEi4o4SjbSF9wyZ/7eSi?= =?us-ascii?Q?G7vcHfwbLCzLIaiAqNUKwh7gEMku7naXMQTKOxDikKcT/x4HrVSkH+1EBTKQ?= =?us-ascii?Q?f4vJTEo9IyHBdRHiMiRVM5KzHGFt2D4xlDikOPGMj1JJqlZ4oN9agg4iVhEZ?= =?us-ascii?Q?PV3wwmSMCGWcrjZ5Nn6/6uGQKzsU3DnoQ33/oAl232YujeeTwWHNkCi8VZiw?= =?us-ascii?Q?nGvCVa3rxvQ08/Ckw0J6Q5SumsQIHOGQCLaL2UsOwJ1VtMwH3fMTJPahHQ2/?= =?us-ascii?Q?AtSupJC2VPDcMnPKe33N31YRDed79OGdjst4DPTRMK/eT/68XcpUGBC9Y5/q?= =?us-ascii?Q?OFr3j7murL4EN/msmvKTkMdJnx6rStlBEPtktEpeWf4+6PNyEZgU55MuShhh?= =?us-ascii?Q?hE6fgwZoGCAYTbq65QDD+197v+/CfEdz4b651Q4w++CtaUBFj8IpB5NGHHk0?= =?us-ascii?Q?WdaEZFj6KkFiMPmvZqvOCsmbUoe8d6U28jqD4RkZ6ZC8y2QJ30Uxf2phXVe6?= =?us-ascii?Q?4/wQMvo3teRCqbVKuP2a+dsimsssdOG06m6KDp44BcAAdT9Z?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7deaea-8ed7-413e-b46b-08dee1a940aa X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2026 13:10:18.5945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q3nrOwfuhPkU1y4UbRCBbKNULJMJJMBB5gr3MYkZ35ay/WBEcfQXF1CR5ouYrM2vHLJ5uFz7rR8MGrPXqFUFcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9591 On Thu, Jul 09, 2026 at 03:55:45PM +0800, Lin Wang wrote: > Drop the X86_VENDOR_HYGON branch from init_amd_nbs() and > early_is_amd_nb(). Both functions are entry points to the AMD NB > framework, which uses the legacy fixed-slot PCI enumeration model > (slot 0x18+i for node i) and the AMD-only amd_nb_misc_ids[] device-ID > table. > > On Hygon Family 0x18, these paths do not find usable AMD NB entries: > amd_cache_northbridges() probes the AMD fixed slots, while > early_is_amd_nb() matches only AMD IDs from amd_nb_misc_ids[]. > > Restrict these AMD framework entry points to AMD vendor. Hygon DF > enumeration is added separately in arch/x86/kernel/hygon_node.c. > > No user-visible functional regression on Hygon Fam18h. > > amd_get_mmconfig_range() is intentionally left unchanged: it reads > the MSR_FAM10H_MMIO_CONF_BASE shared CPU MSR and serves > arch/x86/pci/amd_bus.c and drivers/pnp/quirks.c on Hygon platforms. > > Signed-off-by: Lin Wang Reviewed-by: Yazen Ghannam Thanks, Yazen