From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5394156CF for ; Tue, 14 Jul 2026 17:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784050885; cv=none; b=LxK8+pcz4uVXMdbJ8QZ7gBn3wyzw3KETVRSWx8g4G4kylzS90HsSKSUKLUR0GeV9CvyvNEtZSbHVU9NkJ8gSzBJSOAEf72/v3GvG2gcpI1oT3VvTOwPheDSyR4GCZxuIZ03qtHUcgEJyQrjLZqieN+cdHlrpM0S0P+9IQgAOshY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784050885; c=relaxed/simple; bh=uwYEAAseGuiIqJKLvH0j4d0K5nxF8ikHm9QDZEG7tls=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=im8zINB8eJGL2R8PmguqhcVXRophXmfwH5ud0Wkb+GFGPRSC6gsaaY3zAoiXVUp8UAD9aCdVE96iEayqsbLGwREMsVV/mmt4aWHdRji7LUJdoxC68J8aYhNbcNx17jVBtPCYK/DfvV6URBqPk34M4lFRdTe0PwCDVXsnOeHuUAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Es1qqCFz; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Es1qqCFz" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cab973140bso52517355ad.3 for ; Tue, 14 Jul 2026 10:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784050881; x=1784655681; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YtAAp1v2R1o5+64p5FOI9tTm+W9MNlFWebATHzuqp8E=; b=Es1qqCFzTZa+y9cY4OP1PWSnjIwDi/N0ORq2RyugmEOm4IEP6Myk3dcY6cBAzJH8Lt A6ZHjfyM8Up0KwYLqVm55m3y3X2bPIByrR8+j0g+118aUGREd9gHFufNoiHWGcwmPkKU XeYtH/UDXOwbGg9zalz6n0fjz1J/8umotVZ0UTNlYxNTuSBYTuiv46QttH/uy/TCjQgx CygQEYz330DFJtJH9pikqMkkT+Gzzr71f8ZxXVR+YgtqLou5IdR/NCNAjmD0Y+NDUhJC 39PemLbZMWfvcsxtPmD28LwD0e0p51TkP9H76mR7np8NPCwEHNxZ4xpFQ0fwS9C9UFJV eslw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784050881; x=1784655681; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YtAAp1v2R1o5+64p5FOI9tTm+W9MNlFWebATHzuqp8E=; b=a7JYEql+r9gt/6hyRDrb7zYOcSkE9lXOoo/yDkmnezPAsrnKNUAM4brtNs1F0R55HX e1z2uVbZA6N0Jxty6Lbd2BUurzJh7xUOTIfEFLbQajZvAT/a6lhvOZj4O6dt9PpRaHNg KYq7k43DWbK0U0IDZz6dFrKQsn+7NdsUwIgtV/ONUO0d0UT4MgxsOTGOUQa0JTpbyrk2 mayolzJ+4F7stqWwYx4x+h6Au8ifuI/YYSQAmlsDjG0yRHLho/STbno224tDVZ9cYWC5 W93QAqikHSNP+hrXPDwLvNebS2sk2ItQWxebVdqTr+0g26tRL/6bSfyl6yygzyNl1oc8 WpVA== X-Forwarded-Encrypted: i=1; AHgh+RrroGcs2iY3d5MjB+uxWkIjVbkPiPNj9HehRvUUr3xZEHvz9OFa9pfs7UfLPIer1flEGzOkIQOLaKB1ASg=@vger.kernel.org X-Gm-Message-State: AOJu0YzmnSvaa5/z5oUcMeZsRk79sroRoRnvDEwhyoTE+1slUzuzj9JW FfXok89iwN3A5dCPI2k20Xyw4FVijPo7lzroexpcYrf/mxzysbPXnhUd X-Gm-Gg: AfdE7cnS/J8fZsIg07xM2oABmPqKJM7caxkDx8NP5URhb1vbeDArdSX4DWyCF+9GnIL NTVL8HeuKFaP/u0CmJqyt9pXGlCkOf1nrNMtX5wAx3dnU7ImtVjWcUhFw+N8TWMb4wrSz2HDXyy hfiTBYAVfef4QP7SgZdgeA1XUFVRlT2tMgnQEsmxz7o4DefM5fcM3U1V8PnTy241RZof/IvSlxO FfMIevjrw/iWv3EBaPTbqJCCQ9bOdU7HOctP7DLCUfE54i1Yz1GhbEAZhH4X7mvELEYNuZU4Utp AZNIroB0MzE17O4W16dNYuvmBkedjuW7rcQSxW5mDpqb/ocF1724coZOecPtcZ12sdCLQVmBsTJ 1FzrSF1UZm0eAilczDcl+PQjiiEhCS+yCNyZXZwCCCUJ6U0XPuCRR6Ac8KOfKRX7xEwxViNaLfG sRJqq3zZ54ZSTFywW/SA32ZyAqh5PHJwBANai2l6Iha8ytRt5pVoI5RE5l5g== X-Received: by 2002:a05:6a21:730c:b0:3bf:6c08:fb94 with SMTP id adf61e73a8af0-3c110a207b0mr17047615637.54.1784050881193; Tue, 14 Jul 2026 10:41:21 -0700 (PDT) Received: from fx.tailc0aff1.ts.net ([206.206.192.132]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b87b92b27sm38055954c88.6.2026.07.14.10.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 10:41:20 -0700 (PDT) From: Weiming Shi To: Jon Maloy , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Hoang Huu Le , Xiang Mei , Tung Quang Nguyen , linux-kernel@vger.kernel.org, Weiming Shi Subject: [PATCH net v3 1/2] tipc: guard against empty list in tipc_node_xmit() Date: Tue, 14 Jul 2026 10:41:09 -0700 Message-ID: <20260714174110.1571033-2-bestswngs@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260714174110.1571033-1-bestswngs@gmail.com> References: <20260714174110.1571033-1-bestswngs@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tipc_node_xmit() passes @list to tipc_lxc_xmit(), which dereferences buf_msg(skb_peek(list)) without checking, so an empty list causes a NULL pointer dereference. named_distribute() can hand it an empty list when a bulk allocation fails. tipc_link_xmit() was already guarded in commit b77413446408 ("tipc: fix NULL deref in tipc_link_xmit()"); guard tipc_node_xmit() itself so the tipc_lxc_xmit() path is covered too. Fixes: f73b12812a3d ("tipc: improve throughput between nodes in netns") Reported-by: Xiang Mei Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Weiming Shi --- net/tipc/node.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/tipc/node.c b/net/tipc/node.c index 97aa970a0d83..fc241e7b0c1f 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -1695,6 +1695,9 @@ int tipc_node_xmit(struct net *net, struct sk_buff_head *list, int bearer_id; int rc; + if (skb_queue_empty(list)) + return 0; + if (in_own_node(net, dnode)) { tipc_loopback_trace(net, list); spin_lock_init(&list->lock); -- 2.43.0