From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1AED328616 for ; Tue, 14 Jul 2026 19:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784057068; cv=none; b=Dd5auV4OiqS49bPoUZGbiTMjQaUw0k2vJsK9KI9L9YHMSbRsKZoqlZhXme93ZsB3cNXKAwyMGnoKJKRx2fjEre1ZlW2ntO7nGB6SYhHV1JsfaXGe/08aDeGiKWcNCR33wFtLJKpHBwKE31L4U65L833AP/iPlWH42NqhQHUsfjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784057068; c=relaxed/simple; bh=LS5H5BIMkkbis3RT2WUSmYP2ZWYwer8rWqk98FrAJ44=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Gu6RbHwLfFmJAKYHwZ/tGQVGMghtsD4X4B/FrLRGGJ/S42qFcY22pvW6lIYosVs7OaNYQdaPQuBKRAtcwA4R47jp+PI/1yZ5RuxuKC7LxhbZWXej37Iz/ctbMgtnd6WMq+xtTjUhI4prI/QtfXFKLfQnvDVusbSb9Ep0LltIaqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=koik85DV; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="koik85DV" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cca0c5799eso17499635ad.0 for ; Tue, 14 Jul 2026 12:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784057067; x=1784661867; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jMDExVgbOXk0VFPubyBaAIODXmgYxAMyHC4myKb7xfk=; b=koik85DVENOy7sobpsPICYXkanI3DIQilHLBM5nv2g4G449LrMl3Nt57N673zVNQ7A I4hDjySyDKy78pbXkrl61EaJyb/Tq6DJOeEN2HvtCoBpQAQqZ3iQn1JJGELKVyz8D6Pp 2E4TPuR+In7V/hXVhaPSXQPmYlgK1+ZstJ71p32GruuXjc851kRwmF5eTuEPNiDKXUIr W0eLwsLGQYIBzUy71/i9toZRY1Btz36sMA6DaAolOgMvebRE5BsS1N91peEsqo65PdJL VYEs564cGGSPBS+WIt/X5ztIiCrq2z/06ilvxwIuVwt7q0SgqfPWvsQoCPbepWEBO5tp CJuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784057067; x=1784661867; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jMDExVgbOXk0VFPubyBaAIODXmgYxAMyHC4myKb7xfk=; b=iPRcNqf+Y0tgNZqTjkcVVaOiiYoUteaKWJfgp4vyzCPkxnotda/nILXSndGF/VsFcx a7h6+0Z8MElkp1g2j8pXMJgD1rV9Ssr6FQtQ8bu5zH5C4/eIqcm1gp/zzd+l3x1gDG4O XwCQGwu0wgABfR1goNcqz+e7yTRLi/f7A5Nv0GeSeHM75dEpJGq5PHQYAufrk/nF9InC 38grqlO1MW8lJkqKPMoDLorANvQ7yWGJk3wr8SqM+Vd0lrkOfRDl4PARgJ4OsqY0hz74 94Ob6gSdduZuJU/sP///Ib78HUu3a6+N+Nwb0wXV4oFCN435JUHu+v+VL2hAjHRcAg05 X4BA== X-Forwarded-Encrypted: i=1; AHgh+RqgmAEpMqILkv7UtiQgemvsZv5li6WJdwIyhVOlO1HjIioSHeg2LbO6Z1TIXJNtD78kM8r/WLJTY6YvFu8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/FC1D2rz9jlqUAdgdB3UjJCWu8UwNzX09Vov9ei3dMs+ic+1W 5D3ysiawFuVRBD5NHP/dcVx5i1sf4c3nBacXQBSQB7iL5pBCJu/B6HP8 X-Gm-Gg: AfdE7ckNrUEaSJ07h7Y4w+9YraJWK33tpXqG2gir+JlsHiaMuT5qSgdHCIn3RptzooA k8uJHFrhjsIJnSdz/SSLqMAcM/fG3VpptQ/NApWvNBnAQIPE7HsGB4S2fCZipy3Jt+0cnx2yTjb YH5tGr+s4vmCV7XlMgYzkZJstXBstwYRry9eYzG9YakIB40zV2UJFHTce1lHMU2lryH0nbq8Tq1 tN49rwKTB6nSEn5/nSxbq/g/ExRmD2FAVDwCLjptPi0xjcDdghLGY9plx8H01WebUpjRQ748jhx 7YiXJrk1ii2sBzWmI9a3qlZOsYqK2YegjCgoKF20x+i/O9MkFovGHnAK5xrXzlLB1TknJiRHQG8 q5WSl2fa/TK4y7q6BOyZ2lG7BCg0/4TrIbk4wMYZ+aYvlbEOYP6wPuLee6UVrpEw/URpT+64dV6 WZu0yxghIoaJ23ra3ooH07ICeRGzO1uyND4hKKF0sOPiK7vw6pAhAgqcxWdGbZe4U4He2clJd4j wr0ekFgBbxpfsEMqwBzw7XvSUlj X-Received: by 2002:a05:6a20:9150:b0:3aa:c93b:6266 with SMTP id adf61e73a8af0-3c11060a51bmr16770901637.19.1784057066941; Tue, 14 Jul 2026 12:24:26 -0700 (PDT) Received: from fedora ([202.179.95.46]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b8fc7c088sm31983224c88.2.2026.07.14.12.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 12:24:26 -0700 (PDT) From: Ninad Naik To: claudiu.beznea@tuxon.dev, andrei.simion@microchip.com, lgirdwood@gmail.com, broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, me@brighamcampbell.com, Ninad Naik Subject: [PATCH] regulator: mcp16502: Convert to dev_err_probe() in mcp16502_probe() Date: Wed, 15 Jul 2026 00:52:28 +0530 Message-ID: <20260714192228.1639768-1-ninadnaik07@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The mcp16502_probe() currently uses dev_err() for logging errors. However, functions like devm_regmap_init_i2c, devm_gpiod_get_optional and devm_regulator_register can return -EPROBE_DEFER. Using dev_err() in these situations can cause unnecessary error spam in dmesg. As a result, convert to dev_err_probe(). It also simplifies the print and return operations into single statement. The 'ret' variable is no longer required and has been removed. Originally detected by Coccinelle with this warning "Consider using %pe to print PTR_ERR()" Compile-tested only. Signed-off-by: Ninad Naik --- drivers/regulator/mcp16502.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c index b34ae0bbba6f..fea0f6a2f21b 100644 --- a/drivers/regulator/mcp16502.c +++ b/drivers/regulator/mcp16502.c @@ -508,7 +508,7 @@ static int mcp16502_probe(struct i2c_client *client) struct device *dev; struct mcp16502 *mcp; struct regmap *rmap; - int i, ret; + int i; dev = &client->dev; config.dev = dev; @@ -518,30 +518,23 @@ static int mcp16502_probe(struct i2c_client *client) return -ENOMEM; rmap = devm_regmap_init_i2c(client, &mcp16502_regmap_config); - if (IS_ERR(rmap)) { - ret = PTR_ERR(rmap); - dev_err(dev, "regmap init failed: %d\n", ret); - return ret; - } + if (IS_ERR(rmap)) + return dev_err_probe(dev, PTR_ERR(rmap), "regmap init failed\n"); i2c_set_clientdata(client, mcp); config.regmap = rmap; config.driver_data = mcp; mcp->lpm = devm_gpiod_get_optional(dev, "lpm", GPIOD_OUT_LOW); - if (IS_ERR(mcp->lpm)) { - dev_err(dev, "failed to get lpm pin: %ld\n", PTR_ERR(mcp->lpm)); - return PTR_ERR(mcp->lpm); - } + if (IS_ERR(mcp->lpm)) + return dev_err_probe(dev, PTR_ERR(mcp->lpm), "failed to get lpm pin\n"); for (i = 0; i < NUM_REGULATORS; i++) { rdev = devm_regulator_register(dev, &mcp16502_desc[i], &config); - if (IS_ERR(rdev)) { - dev_err(dev, - "failed to register %s regulator %ld\n", - mcp16502_desc[i].name, PTR_ERR(rdev)); - return PTR_ERR(rdev); - } + if (IS_ERR(rdev)) + return dev_err_probe(dev, PTR_ERR(rdev), + "failed to register %s regulator\n", + mcp16502_desc[i].name); } mcp16502_gpio_set_mode(mcp, MCP16502_OPMODE_ACTIVE); -- 2.55.0