From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B19A142BC5D for ; Tue, 14 Jul 2026 21:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784063334; cv=none; b=U5uT/78rzmbNt21Sxeq0HyuwRg2dIDN6wO+Uk+kgLH4Ng/4VJ8yjXxJlXNXKg2tG8eAv6VcRnhKRyKO8n9UZTezYs9QCBXe+FPq5+TY6Af8RoxfCVKEFwa8HNCXfO75yf5iKxGM+wk8rlr/5D0D8+yQ8V7ryfP73zQTbG3ASKY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784063334; c=relaxed/simple; bh=rTkqe32vdpp3NuE6rtgVM93dRS4mF4Oc9eRIub6FXuE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m3ZwfUGds8KYQ81wGOEiQUsT0TICrb6mHubgYC/EpT6njW0lUAbKPuejDBLlRgskrcrR6ftgqYYNp9KOY+LiTwQgqXA1z67hc/aeL/aEkRgRh/qSy/ZdlQ09x+XSSzwI0G8kK9tzoeE1bwDK5MUNa2K3yEfhmgP4ZhVFc+o1Jkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jfDuA9vk; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jfDuA9vk" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7eb3865ea6fso3211884a34.2 for ; Tue, 14 Jul 2026 14:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784063331; x=1784668131; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cYbi+xyIz+ex++QixYBeThzkR5VqVZi07DDBFPRxtBM=; b=jfDuA9vkyuNaWeZKOMVL6YGBjULJ04nVeU19DU96OQneRfGPTI2/9kU9AB4La42Wb/ iR0HCTZxMsnIfguUg1IT6N1i8W2Fp3wt9o4RJ+5i+dYFXHV1hoel+505Zx0Ma3P3nZlP 47lkMaehY/cn96UUbL2/v16DXBCyZl9mWGOsEebQkF9ojBDjLIFrbegASvGuOaAlYxRw +1Y1vTWgdPitLnO2+Ooxex0F4Ns9Ykb1uDwxVjspUCpTePL9LRJpgK6kRiZTpz17bGpQ +olUMfemdlYkVsota1bBFMD2TXAPk+rH3J8ZoiDL5Li4maGntai82ZM3DnWtdG74ZjK9 cwLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784063331; x=1784668131; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cYbi+xyIz+ex++QixYBeThzkR5VqVZi07DDBFPRxtBM=; b=gHMvvEELUIt2ixtnE+YKVUvhWDuxdiePj7ltgg39DVubZX22Go+X1B4YUdlI9zSSv3 EC6Xs+Jjp4CKmxNSVxOwW3sKUj6S2/8PzdhWdVE/O4iJxwDETrrWdHA6cPN5fmSfPydW CsTD8N8nGZNX9veYbusI5bojV+PR3IfM0GfymUZkpP08VmpqCf48D9hACHoQ3dfPoCZ1 Y6O65YUKHBdSJuUc39vqCPhbPOX11UOV4iZLEtYUNmUsarR5gga3A8l1V4miQQuF4Vig huG39LieolZqA+zEoRvxY9dGksrd2KTTtqb4ykNnEkW7DVUqM5iQXqIeJnsmrsH27ziy F5cA== X-Forwarded-Encrypted: i=1; AFNElJ9jcKB5k+zXFJ59vvQ4XlDkpscixOM6SMSZjeYr6xxQTUmdZ2B94fL39a/8oLln2j8OB77zTqI4nePtbtM=@vger.kernel.org X-Gm-Message-State: AOJu0YyR5yINE+9wG19kwFD0il1KgmFGks1pLgh7jZPq4xIdPA8wKRXx pKWtdyTCBVK5xUuoBmgVyTgUIzjT2ziDDif/I5u9M3UpHfNFGgUiUBb5 X-Gm-Gg: AfdE7clD9+NHvoTkrbR/pcD7LpLbMYJhcb9lEIcCpKFmN0lek9MvZ8upSqx8doqpOhl mch/wTKEZPEFG4RTosbqmITghUQ4tvt/rHo1+XXsWrAI54ZAjkl4Gw1c29tAHYOygqgErPgzQ8M 9QwCZaibMIaOlaKykBFguinxeboAH3F0suAsyXIksnoNLZJ5Pg+aM1eypl49R7c+HSRGNTUoFdW +T6+RZKcSLS7ht09Ue7nOAhp4LLrsL9Hqq1tsm6ZZbDmjflKYOKhUio+ge/sNHWsGJeylI95J71 NU4FG2bf5Vg4di5sy+yddNrk64bBQndY1dWpefdFz7ZBR3JfrLDH7ZMlrr6jcJzwh7QW+gVpgdH NwfYXsekAWSeWRAJFe/2d2+CojqKcCWBD5pq+9fUbmblmV2ryAMRH44k6X8BueBqQQMLZv1C9+g V76r6cwwyCW4BudAsJChrnv2zPcflpuyhjwCjKMG+RT5kve5Y= X-Received: by 2002:a05:6830:2a11:b0:7e3:d29b:fea4 with SMTP id 46e09a7af769-7ec423642f7mr3103535a34.22.1784063331427; Tue, 14 Jul 2026 14:08:51 -0700 (PDT) Received: from archslayer ([72.174.138.11]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ec2183a32csm6906825a34.23.2026.07.14.14.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 14:08:51 -0700 (PDT) From: William Elder To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, William Elder Subject: [PATCH v4] staging: rtl8723bs: remove comparisons to boolean literals Date: Tue, 14 Jul 2026 15:08:43 -0600 Message-ID: <20260714210843.72848-1-williamxelder@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <2026070738-usual-rinse-7c52@gregkh> References: <2026070738-usual-rinse-7c52@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove comparisons to true and false as they are error prone. Use the idiomatic C forms instead. Removed a stray blank line Signed-off-by: William Elder --- v4: Per Greg's request, included all patch revisions and moved the version notes below the --- line v3: Fix inverted logic for ht_option checks v2: No changes, resent v1 as a mistake v1: Fix redundant boolean comparisons and introduce inverted logic on false conditions and removed a stray blank line drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4cd9..1f7f24dc8f7c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -236,7 +236,7 @@ void Restore_DM_Func_Flag(struct adapter *padapter) void Switch_DM_Func(struct adapter *padapter, u32 mode, u8 enable) { - if (enable == true) + if (enable) rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_SET, (u8 *)(&mode)); else rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_CLR, (u8 *)(&mode)); @@ -340,7 +340,6 @@ void set_channel_bwmode(struct adapter *padapter, unsigned char channel, unsigne center_ch = rtw_get_center_ch(channel, bwmode, channel_offset); - /* set Channel */ if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex))) return; @@ -847,7 +846,7 @@ static void bwmode_update_check(struct adapter *padapter, struct ndis_80211_var_ if (!pIE) return; - if (phtpriv->ht_option == false) + if (!phtpriv->ht_option) return; if (pIE->length > sizeof(struct HT_info_element)) @@ -892,7 +891,7 @@ static void bwmode_update_check(struct adapter *padapter, struct ndis_80211_var_ pmlmeinfo->bwmode_updated = false; } - if (true == pmlmeinfo->bwmode_updated) { + if (pmlmeinfo->bwmode_updated) { struct sta_info *psta; struct wlan_bssid_ex *cur_network = &(pmlmeinfo->network); struct sta_priv *pstapriv = &padapter->stapriv; @@ -931,7 +930,7 @@ void HT_caps_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE) if (!pIE) return; - if (phtpriv->ht_option == false) + if (!phtpriv->ht_option) return; pmlmeinfo->HT_caps_enable = 1; @@ -994,7 +993,7 @@ void HT_info_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE) if (!pIE) return; - if (phtpriv->ht_option == false) + if (!phtpriv->ht_option) return; if (pIE->length > sizeof(struct HT_info_element)) @@ -1689,7 +1688,7 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len) pmlmeext->bcn_delay_cnt[delay_ms]++; /* pmlmeext->bcn_delay_ratio[delay_ms] = (pmlmeext->bcn_delay_cnt[delay_ms] * 100) /pmlmeext->bcn_cnt; */ /* dump for adaptive_early_32k */ - if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done == true)) { + if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done)) { u8 ratio_20_delay, ratio_80_delay; u8 DrvBcnEarly, DrvBcnTimeOut; @@ -1737,7 +1736,7 @@ void rtw_alloc_macid(struct adapter *padapter, struct sta_info *psta) spin_lock_bh(&pdvobj->lock); for (i = 0; i < NUM_STA; i++) { - if (pdvobj->macid[i] == false) { + if (!pdvobj->macid[i]) { pdvobj->macid[i] = true; break; } @@ -1762,7 +1761,7 @@ void rtw_release_macid(struct adapter *padapter, struct sta_info *psta) spin_lock_bh(&pdvobj->lock); if (psta->mac_id < NUM_STA && psta->mac_id != 1) { - if (pdvobj->macid[psta->mac_id] == true) { + if (pdvobj->macid[psta->mac_id]) { pdvobj->macid[psta->mac_id] = false; psta->mac_id = NUM_STA; } -- 2.54.0