From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96ACC36A004 for ; Tue, 14 Jul 2026 22:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784069565; cv=none; b=MEw6kLZ6gDlcISjIQ4tQXm4a/iEUEuzM60GTFwXfpdPi+Yn5u+kjw5bfLqFpiHXJbpRkrxg9W0nANYKcjN90eWK1lVeot8hgrJvNU/eU2gJWRkzUl+frQYHUSxwSwNDT7Lh9p5iLz/3N1tRU/xP0qz2buOXKYxP2LWKIY7aAsqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784069565; c=relaxed/simple; bh=hII1+EpO76dP+zuiHl33FQnNw3xAMPFb+8sWj3r6nIc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FMBSL7QHCTy8vFbZO8mewJT0F+3c06aLWELLA2uEfn2G9RSeLm6F8VPBa5AJgGBZqNYHYvTH9kMpCmMZVWcTDzaK0H+H+yGMQZX7B3NLUFxt26Sr7WtciWjd/PSduJ3QdyGenrtdvjhsIabMJx1Yoysbz5VZZnPlwlisE04OJh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IJCQHvoi; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IJCQHvoi" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-81e6f2ee60bso856277b3.1 for ; Tue, 14 Jul 2026 15:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784069562; x=1784674362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XaVrA3HODxV67MqxZaxfvdN/jDJhMYGWIyIOq2g23Ic=; b=IJCQHvoigLuyjsFz9VUYrSjTzd+AZYsHDAl8+Ve1zB/24Xm7zhZk7sIyvFbjM7yrPm oz/HOgHbQR7BVrqhWfpdy6UFsKNic2wtqxoQUgAgGwXS2vTNWogR+KrV8jwT1QHjAVHq D7MtuaXgPH0xVs1q9/bhcaPWSvrwORNKxfhkZ2zKTR8/pvtqsXZex8zsELb+YIlwK3Nn +5NO9skrd2QTIU4/tAzkfK3bkAJifantv1MuL024RiqYvyIvxAJl2G+GMVj6YXmqKrUN n4EAhMbXA2s6Zod3gCOq3SKcYYi7m/ytviR524+hD+/AzKG/JuH1gIzOqLBNe3nOEHyD N/9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784069562; x=1784674362; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XaVrA3HODxV67MqxZaxfvdN/jDJhMYGWIyIOq2g23Ic=; b=XMvaVsntvyLfjxw040DDh/QH4e+qo8jM94J1ZWqqbtrWlu20P+RTc/R1QRiB1BuxCo 78bt2O0XYfJF39j+FXMjKkaoVJMxeIXYpehnEIEal2hoPoh6aZC1hepgMlx01AsN8BDH jPk92Jl1roX7XtDzP5mCqvQwJp3w2st46kmQRwFh1ptSXWKo4t7XNJB7t76+axGdFVpF 9si4QIZ43EtwXvtIhgL3cbkAwA8uZeaFZFbUCR5ySM+4vHglCD5pV6Obmer8ks9MIPRe UyPFT/9S6/KqGNsnkjXiIuVsoNkoUeL2YxJmSpdiG24I/DqhkUFR4AblyJ0jgAfDPvXY Qb2g== X-Forwarded-Encrypted: i=1; AHgh+RqBOv1qtxMtFM0Z7fdM1FwqjefF8ChG4jA4yP9/uAmvMnJII5cE7HKk0uuRNI7JP7bxRmouakEbVbrEj5c=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4SLNBnJfdHRCDHCPtyLwucIaeqh7jsOgoHh/Q3KL6KWLk9Jht 2uGjO+Mw4wjg9O02VLlwqPj/FyeK0pzWeVvabXHTDz5PPzwLIuOKnfXJ X-Gm-Gg: AfdE7cmwwQ1i5kwKfWEonSC3t7JkrCjVJWAMQEzDZ+hVJGWeROeiQ9LHv9itAikn89p GLFe2Fdo2rsIlLvMbPQGVRx///4pX/rMOkcQSQTeBtAel8dTbdqaOzg4D9cL3HiyJUXCoSTAGce cujvaycE5+NM4YN2Of+kMkTMdOC7/M8qWgM6JoebtKOndIvVYchVX+NOnd9kpytQ71WhG4UUyvP RKq6snFZ3x1f184VnlxreIUedVniW85+efdTI5iPLTaLm4/c4ez8P4Q032nQOIcNsZALKW+GNi5 9/ilAnFo33p4B26qEN2LjHIeNpyElxynyGRbnfQG1TK2f/FAk9KslZMeBLNv6UyWndoHzsMh0CK dqEEdfJIBUAsO1TCeXZSU7cXt1xRRF3KO0HZ+Nt2LJnBYMeNKIvm3r1LIAaJtDKFI23Uitt+OSu qFxNRiHWiPpM8nWpHmG6C/wXq70dRjquBhhFMZ69KYvWm+qnSqUiraSB3RdoiHMKTaDA== X-Received: by 2002:a05:690c:399:b0:7ef:e7ec:b6e7 with SMTP id 00721157ae682-81e7bc9497cmr150082747b3.27.1784069562556; Tue, 14 Jul 2026 15:52:42 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:4c64:82a2:a510:f4e7:1a8:cf71]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81e6c249b87sm153446897b3.49.2026.07.14.15.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 15:52:42 -0700 (PDT) From: Rodrigo Gobbi To: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, feng@innora.ai Cc: ~lkcamp/patches@lists.sr.ht, linux-kernel-mentees@lists.linux.dev, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v4 0/3] staging: media: atomisp: use kvmalloc_objs() and drop redundant OOM messages Date: Tue, 14 Jul 2026 19:48:59 -0300 Message-ID: <20260714225235.47134-1-rodrigo.gobbi.7@gmail.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Several allocations in the atomisp driver still size their buffers with open-coded multiplication, e.g. width * height * sizeof(*p). When the dimensions are large the product can silently wrap, causing kvmalloc() to allocate an undersized buffer. Convert the remaining sites to kvmalloc_objs() with array_size(), which saturate to SIZE_MAX on overflow so kvmalloc() returns NULL instead of allocating too few bytes. This continues the work started in commit [2], and picks up the stalled sites from [1], unifying with [3]. While here, drop the redundant IA_CSS_ERROR("out of memory") messages on the touched allocation paths: the memory management core already emits a far more detailed warning on allocation failure as raised at [1]. [1] https://lore.kernel.org/all/20260413112904.98864-1-feng@innora.ai/ [2] d178c7ca8fef ("staging: media: atomisp: use array3_size() for overflow-safe allocation") [3] https://lore.kernel.org/all/20260609215110.118860-1-rodrigo.gobbi.7@gmail.com/ --- Changelog: v4: 0002: use the full commit reference form for d178c7ca8fef (Media CI checkpatch); collect Andy's Reviewed-by; v3: https://lore.kernel.org/all/20260623221028.40238-1-rodrigo.gobbi.7@gmail.com/#t v2: https://lore.kernel.org/all/20260622224402.34001-1-rodrigo.gobbi.7@gmail.com/ v1: https://lore.kernel.org/all/20260609215110.118860-1-rodrigo.gobbi.7@gmail.com/ Feng Ning (1): staging: media: atomisp: use kvmalloc_objs() for overflow-safe allocation Rodrigo Gobbi (2): staging: media: atomisp: use kvmalloc_objs() in make_histogram() staging: media: atomisp: drop redundant out-of-memory messages .../media/atomisp/pci/sh_css_metrics.c | 11 +- .../media/atomisp/pci/sh_css_param_dvs.c | 5 - .../staging/media/atomisp/pci/sh_css_params.c | 101 +++++++----------- 3 files changed, 41 insertions(+), 76 deletions(-) -- 2.48.1