From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAC07451076 for ; Wed, 15 Jul 2026 11:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115861; cv=none; b=tChwvBVxjDFTk7+oEjtG/upIeNg+HyUBW72i+O/a6OqtOckKfZaJiiWfVRmvDzjc4SEyMZ7xgV0L0fpR1YL64+42kDGh5LpO57zXncsF+JwWHrwBrJTFqpa71Dy5VhVvVThTdbdDkOyNqmnNiAxEfd5Ks6gj1gsEc4WjZbgM8hI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115861; c=relaxed/simple; bh=aZ8n57U1j2jY+o1haOa0aouu6Bwg3e2b0NapU1cYUUA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MChqoX6jLAJL9Y0G7PKdtB/0nrAwd03VpzTYFsbwr4zAKlsdxtuCqP73kLDL6uTK4kdHGr5rPB/4HKOZgvIUv5DYE0FVrfQiEnnA7FU1OEiYmuAsTCHR1qVWGVdbOB90cwYZsKX800QEUVlzdZl9vSpHxjxSY43AVoMpVhBe2CE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=kQOJ5zpT; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="kQOJ5zpT" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-47f3e6cc44aso2855527f8f.3 for ; Wed, 15 Jul 2026 04:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1784115857; x=1784720657; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LaA0Iag3STAJeBMnk4x8b7GHaELfh57GksWF24FaP5Q=; b=kQOJ5zpTjh7puS+qtU9Sj5Wnu8A16H104rTHRtkn4s6HRZfI05hJ1X1weMV+bTjRuG MDiQ/ZzffBqg6dqADY2Hbc+E8vmvcSjfhNwsz8P6EoJvzSJ0T08z9xemw6dJq+X8Gp46 423WIwYAeyvelk4N6naI6lFCvnEv/9BBy/Yv7mMTrkQ4unU9aa0b2IbSiDqnBba18L4S 1c6gaMeHYkP9lx277uFmTQ4Fl7KVj1LqDK2RgPdWttIEkTjEpWqkeQp9fthyD60dWh4k KM1soToXx0s1OtbEcy2XyQ/hu3guw1NjcVQHBniGLQQovhF/spQWZ9QkB36M77g8hElB sMHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784115857; x=1784720657; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LaA0Iag3STAJeBMnk4x8b7GHaELfh57GksWF24FaP5Q=; b=Qj/Rvq4AbONAwPRfUUw0L5V4MCkPgutOUN3QhuHUTLORJuoJlVBT1dgSF/rJnRRj8e qH9oQ1DKl6xUGAkBigiiPF6Y9b39wz++iM0qzQw2266KgMIqr/VyylNd3YB2tqPBAPvH j5YbaTGRudCGeq/r6M7qBGPyuHe9F1vrvEXkhq8X10K4yPyV7T1wWihACK/vj5Cp66n2 zJwbBC2H16nFJKhA1km4HhzlIKzGz91r6hjt8G/+XizW5ztqIqRgwru/aSj2bnyWEe1A kYpdqGhoXyCmmfyiWsEbfyYTOjsW5oLEXw5Aa60SWyyekP856abyMQ8FMtg4Kh2rXUPI eWpQ== X-Forwarded-Encrypted: i=1; AHgh+RoHjQW12F65Lmhu7cp4NKx8Num646+EYTqmTMdTy5tOVOEzz3X8ry8Veyvzn8wKOlUOGwsj5+767pNlJBA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo89/j+1YqBStWi3cNY0mQMrmJNk4XpXUIcWCtSOqIp8ep+rKa 1rExbsKxBuYXHl76Z3TkJ52iFJfyTk+rbPAphw5us3bP7m6ePALEhJ2qD+VKZ+dJovc= X-Gm-Gg: AfdE7cmcJV3KU1CP9De8atj5hDPia3RT995OSxli3YX62JdeWST2H7a+JhmV2edyuK0 clbhjUejIe1uahpVaoGf9L4xUBgK4RsIEbUDESK3ZPQ4BdCF45MK6xRrDX/7y3qOIjUucjWXNw/ SmC+L9geTfxPAxYt1fEQG7xcmanDjLvZytSiCVyT9UYh5e4fIgw+qAtP1pt/cL/ufJ51dxtCIIK Vp5U8FapNhTIqbqUsge1BXz4vHDqNbEEQT1Oongve6O0CXm7FjiCq2v6tX4nyGMCS7hfKMmzj8L BHA+0rRzEen70VqcxeF59JC0xcXyD/Ww7fQZHzjRw0zrAOL/opIpwzcIXFJHHpwNqOMecj3TYo5 ZOwxEiN4/MCpsLoSWik2KaaKjBVLocR7MZe6HJT5y0/0EEZcKR949/0z0BjQ84XOmR2c/A4B1HC xisRtOhw461UHOPAuRu4JCwseII3PV191AbFLgTIZwKYmNkg1uo9sMMwB5nxVBtQ5U X-Received: by 2002:a05:6000:4602:b0:47d:fb9e:c3f6 with SMTP id ffacd0b85a97d-47f488573eamr6671556f8f.20.1784115857101; Wed, 15 Jul 2026 04:44:17 -0700 (PDT) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47f4829896asm14005425f8f.23.2026.07.15.04.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 04:44:16 -0700 (PDT) From: Dave Stevenson Date: Wed, 15 Jul 2026 12:43:21 +0100 Subject: [PATCH v4 08/21] media: imx355: Set binning mode registers programmatically Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260715-media-imx355-v4-8-f7f966fb9ffd@raspberrypi.com> References: <20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com> In-Reply-To: <20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com> To: Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Acayan Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg , Jacopo Mondi , devicetree@vger.kernel.org, Dave Stevenson X-Mailer: b4 0.14.1 Compute the binning registers based on the difference between the mode width/height vs the crop width/height. Signed-off-by: Dave Stevenson --- drivers/media/i2c/imx355.c | 61 +++++++++++++++------------------------------- 1 file changed, 19 insertions(+), 42 deletions(-) diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index e9f4bea67d3a..95487b12939d 100644 --- a/drivers/media/i2c/imx355.c +++ b/drivers/media/i2c/imx355.c @@ -72,6 +72,10 @@ #define IMX355_TEST_PATTERN_GRAY_COLOR_BARS 3 #define IMX355_TEST_PATTERN_PN9 4 +#define IMX355_REG_BINNING_MODE 0x0900 +#define IMX355_REG_BINNING_TYPE 0x0901 +#define IMX355_REG_BINNING_WEIGHTING 0x0902 + /* Flip Control */ #define IMX355_REG_ORIENTATION 0x0101 @@ -263,113 +267,71 @@ static const struct imx355_reg_list imx355_global_setting = { }; static const struct imx355_reg mode_3268x2448_regs[] = { - { 0x0900, 0x00 }, - { 0x0901, 0x11 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_3264x2448_regs[] = { - { 0x0900, 0x00 }, - { 0x0901, 0x11 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_3280x2464_regs[] = { - { 0x0900, 0x00 }, - { 0x0901, 0x11 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1940x1096_regs[] = { - { 0x0900, 0x00 }, - { 0x0901, 0x11 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1936x1096_regs[] = { - { 0x0900, 0x00 }, - { 0x0901, 0x11 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1924x1080_regs[] = { - { 0x0900, 0x00 }, - { 0x0901, 0x11 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1920x1080_regs[] = { - { 0x0900, 0x00 }, - { 0x0901, 0x11 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1640x1232_regs[] = { - { 0x0900, 0x01 }, - { 0x0901, 0x22 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1640x922_regs[] = { - { 0x0900, 0x01 }, - { 0x0901, 0x22 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1300x736_regs[] = { - { 0x0900, 0x01 }, - { 0x0901, 0x22 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1296x736_regs[] = { - { 0x0900, 0x01 }, - { 0x0901, 0x22 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1284x720_regs[] = { - { 0x0900, 0x01 }, - { 0x0901, 0x22 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_1280x720_regs[] = { - { 0x0900, 0x01 }, - { 0x0901, 0x22 }, - { 0x0902, 0x00 }, { 0x0700, 0x00 }, { 0x0701, 0x10 }, }; static const struct imx355_reg mode_820x616_regs[] = { - { 0x0900, 0x01 }, - { 0x0901, 0x44 }, - { 0x0902, 0x00 }, { 0x0700, 0x02 }, { 0x0701, 0x78 }, }; @@ -974,6 +936,7 @@ static int imx355_start_streaming(struct imx355 *imx355) { const struct imx355_reg_list *reg_list; const struct imx355_mode *mode; + u8 binning_mode; int ret; /* Global Setting */ @@ -1019,6 +982,20 @@ static int imx355_start_streaming(struct imx355 *imx355) if (ret) return ret; + binning_mode = ((mode->crop.width / mode->width) << 4) | + (mode->crop.height / mode->height); + ret = imx355_write_reg(imx355, IMX355_REG_BINNING_MODE, 1, + binning_mode == 0x11 ? 0x00 : 0x01); + if (ret) + return ret; + ret = imx355_write_reg(imx355, IMX355_REG_BINNING_TYPE, 1, + binning_mode); + if (ret) + return ret; + ret = imx355_write_reg(imx355, IMX355_REG_BINNING_WEIGHTING, 1, 0x00); + if (ret) + return ret; + /* Set PLL registers for the external clock frequency */ ret = imx355_write_reg(imx355, IMX355_REG_EXTCLK_FREQ, 2, imx355->clk_params->extclk_freq); -- 2.34.1