From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 771A43B0AD3 for ; Wed, 15 Jul 2026 03:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086740; cv=none; b=bS2LRTlxfkw+mbNSLbsBhCAs3FNlB3Nwz9jdqzOkEbBWaovl+gYcbG+HYgVUXYrGmiSs4bAmWYPajSghUsxlWf29PVXFjO1VkdqSYoBqqOG4HlDSEKbKDOI0WVXCp/ygniIot4RcjXRusBw7Qy8VUlgbhXfK1TQnu87dXXp1RpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086740; c=relaxed/simple; bh=1OJ+icYvEUWlm8+gkxpBRGkF6MURV1kBnpa24faYVyg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W1DNKVghf4JvR6zWukusYAhT392X0ReQminjoYUXULVSK/Gn9Jtti9Nzcig2URLymfOIZ73To+TGcJu3BDpPg1PHE/f9tW6j0IRfsJGFyQM0o3msHCx8YgDpPDgWniSbL2UY0cogs3X3ZEXVIduvatPZdfY/8hMOG9Ln6eJKqQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=muQJv+Fw; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="muQJv+Fw" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c9e607d81fcso1075772a12.2 for ; Tue, 14 Jul 2026 20:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784086727; x=1784691527; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EyiROYORTtKO75BwiwBGsAV70dzUHKAaS+4RZHI8OfY=; b=muQJv+FwmyEyf4CGxc6bvKPltLNf3UQVrcPU1cm2wAIjj3Q7uT6bNjwQKcr+7IVcLx mesGok9Hf29WPNHVZI11Rni3hzWW6SqTZCzY93ESHnOfD6wMb6+RfFPZjWZ94NuKo7hd VX84LH9BQwyM8misfB7NHZD3wHw7LikBFfbSUzJNfOXrK77Fj2/NGcqKjExtrXXADoLa tS3wtaf6va3KYzJs5Ifxin0mzP1C9iN+4HAGHqSGUNLYlcAQRpWqIZfs7MZ0AIJ35ldM 0nIb6lFymitpDAHRvWQmYkj6m7acmT20cXn+kxGoi9bIDJHrqx7T6T9Zik4jb3w0ifVq T1pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086727; x=1784691527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EyiROYORTtKO75BwiwBGsAV70dzUHKAaS+4RZHI8OfY=; b=rqwodFTcynMeOLNVFkbWlJ81wwlPCHHj0JbwL4H/CrHY5C/lSFuUyTlYkptqTVkiIz hD5zlSR8L0VhPUvyhxJvNvDgm9apHWPA7gsNcir5/YnsHqk7KllXBEdfsjB2QFZG2TaR resxtMdORJljeew/yOtxtPBC+PpE/gRV7fl+5Sn/JLXZXbdT9hheAB42rv6N+sVjMXyj KPkHQWanLPn/367xYPjZfxDe8hxFTHJ6FkNkcjekXyiMBCjDejIOdYZfJBoWug4+zBSM LhSprgBU+73AHAukc3bEoO0vgcurcYtDYLIRgY+yTwTKL6xsUhpFFbVMpdE0RfiOIjdU 1yFg== X-Forwarded-Encrypted: i=1; AHgh+Rrx0AkKgZH/M7BoYfX1BCU4yxYqdX7LGtCIg/2HFm0itUkWJgbpw2jw0+GpIKXac6tHDS0AGkexqxk45/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2NXw4AewPDF0upuTMSIxxHLp4QA1g6hrO79fExrOouR88DHxJ x/k5HNrG8msa1lN4hoklhL/Yiy2dhS7Xv4ifkWd+V1vvutndnLaJ8ZIX X-Gm-Gg: AfdE7cmPozVwUdk2kjC+YO4Bt2ZdRfDuVNEvy7+uvNFSyEPKKiQCspq9WMjY2knHPD5 8yfAg5hlKOa3LFi+5Y31ZMurPlPgtBVWXq9G3VdpAom2GbbQr6KVDYEt9bnEWLK9CDJOfNGN/tI 0ddcXoy/X6nU7XCD/n8gxqw4YfT5eCvH27+CMuKD8FWUlx/+//wVhy6lhPVLWYOBJvFngQ/M2Si 4OoPdCwDrnxb50pHns9CaoU8s34hADPRI94mYPMbWkKoLxpqIJj2MhE4nnXKST4p07Ofqt2OGsm usLEzTmXKzDmZdSUnWljeLlu+vauARDyfOmbYwTETVgPTGH52QJXOopQNPwmIryGT2HE4TR7dn7 oo4EKvIPREowdFYFNeSJb83fzL724QtMbzzAPnBHPYCJjnep0zfcycU9//xLz5Y9bBmA2/UJNY4 T7rBltadQvwrRLHwVeT0kr4LxMoUZ8gR2cQ0RpWor9hgE= X-Received: by 2002:a05:6a21:9d91:b0:3b3:241f:66c6 with SMTP id adf61e73a8af0-3c1108c1a5fmr15396434637.26.1784086727117; Tue, 14 Jul 2026 20:38:47 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a583bcsm91977889eec.19.2026.07.14.20.38.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 20:38:46 -0700 (PDT) From: Biren Pandya To: mchehab@kernel.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v2 5/5] media: i2c: saa7115: Add missing media_entity_cleanup() Date: Wed, 15 Jul 2026 09:08:24 +0530 Message-ID: <20260715033818.10967-12-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260715033818.10967-7-birenpandya@gmail.com> References: <20260715033818.10967-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The remove function is missing a call to media_entity_cleanup(). Add it. Signed-off-by: Biren Pandya --- drivers/media/i2c/saa7115.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c index 48d6730d9271..64adfff3001b 100644 --- a/drivers/media/i2c/saa7115.c +++ b/drivers/media/i2c/saa7115.c @@ -1867,6 +1867,7 @@ static int saa711x_probe(struct i2c_client *client) int err = hdl->error; v4l2_ctrl_handler_free(hdl); + media_entity_cleanup(&sd->entity); return err; } v4l2_ctrl_auto_cluster(2, &state->agc, 0, true); @@ -1925,6 +1926,7 @@ static void saa711x_remove(struct i2c_client *client) v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(sd->ctrl_handler); + media_entity_cleanup(&sd->entity); } static const struct i2c_device_id saa711x_id[] = { -- 2.50.1 (Apple Git-155)