From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B141C35AC03 for ; Wed, 15 Jul 2026 03:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086722; cv=none; b=N5csvSnKfbocTc+WsYVdxSduyuhX2ullw8OG0UfpD5KlBVW3ne4l9CdX8dCHuTRs9+xUPDL0rIApYTHglk6iaRwJZKJOfkOPehuQlCd3o8QXvI+OcEDQvS4Jzb/kI60+TNzmkshF5ZDMHhht7b4qY0V25WShOUUzai3NfxZerbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086722; c=relaxed/simple; bh=kTxcJHE6iVe6RfB49bXDbrA6ICjAjhcYetRvA3pBtHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A9BDmQ3p7f7Km8oIxv2UyCopbEGV+xxisjLPa0BmvXNH8+8LjnCXAHavB0EDrXatlVyZR2Wx67Wn+IjjYdGffnizg5QNL7/c3L6VILGuT72GYVEBMcAs1e1lO+/K5/wYcihH9iqVIboZaHQxmyipu3f1QkxAygch5f076g8eD5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eM4XG/Dd; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eM4XG/Dd" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c96b08cdd1cso3358102a12.0 for ; Tue, 14 Jul 2026 20:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784086711; x=1784691511; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ctC2FHVouwwXy6nRKJZij8fpoFOJxlyQsKFiZ9amI48=; b=eM4XG/DdGe7oHi5H9Hm0gIE3o1of1KlMBb91W+35xPJgGJyBbCz5oVEl0ulZhEQAFh 36kX+UBv0VM5ccgbw7XbbYKqyNCPL6FDba2ZMApJX63fk/BOQ7KQ8RPuguiNf72tZZqq sQr4WTTf2aK7aA0kGkaoQNZ2H6MVEy/Ykfwk/J+rBHKIW6TaWsLHjlGK23k2om19L+vT K6cF9Xcuz/CWBIEJN4ud+O4SFlPvygOPtgyIk2t7pnpMryii0gu4mRMzBwnT5Nil1wwR MZLw+OT/+Et9l73Zso4bI+cpYBjCOmPvVUnHTThe0NzdV3ggzEMhOuZyTrsZaO91ed+d +eEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086711; x=1784691511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ctC2FHVouwwXy6nRKJZij8fpoFOJxlyQsKFiZ9amI48=; b=MIOOVsESLdI3Z60kKjzny2k7DKazD7jyBEj+AJMLwUgkvUp2hE5TrM+ET/12HmbzH2 IqF7CGL20hwKMLxzhecGsd9vX6apM10wgqlrTFe/f7tn9yAU/RM3iOQZ2KJ6oerSdAei HUd4cFcrbf9b/Glw4ZTKmrJhtgvyIJmidhi7e6gU9/ETIY9fxBrlboZgGrST5iI/lyZ5 rrhEAaHfKPdgBt9KD89eg8zi+wooGyfREOE4QKQJZ33GFLcrtSF3v5rse5j3gHqblH0Y e59dDDTjqapwWRmBvIU+7nPtKRgqofHOa02ToUN9hLV7U41ybjbctg2TdKHUz6pVh2Vh lGzw== X-Forwarded-Encrypted: i=1; AHgh+Rrkw7dDatULSX6z+3v/YCIhszhpbJfe/0k96N+rq+7314wZhLKexATO7OPAA5U/qoa8DSj4gRh3fW/3GVA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa8QUlHTHpAwKKvgiY9CoOjXgGMT9sOpufwHmzm4xPAPnHHoDt h32BJ/RahnnKSslNS0I+/Q+GuXpUW0k/lMnH09Ihr1NdyHfvj+2G5Qfh X-Gm-Gg: AfdE7clRgYsefp/wIA+j6VGQm3sEyACnDz+02AwPrMGNVxgnObMovius3kdqi2NQXvr cUmu/vv0AUPFKPg8iXGg08Sr8IXRAJtfx6AeCPU1DHQRhH+XEk0BcvAzT1be+xNjNkQN293KAyU We8tTEW4Noe5IVJVEm2gd5KlTOJ2kc+9oOIbAwEiKFjcWxBNmxTZ+lJuPzRRg9UsepP43GzS6hf h2dqLC7q+n92Rpkeb1elkJj06EkJSjLHtFwpnVh3bfT7/8MNciYrJ0uQ9Qu4v9dA6vjfiVv0YVb dulYU7AO2bDg72rhL9ghbJVWhhcEZqLLg0SrRhAADkTXztuoFUj3GSNijioA13lcp4JRgWzBKJN loKjZVvvv2694cjHvYUj/W0OP5NKbPJCtsm9bIPb9TxUb7158JpF++22y1Dg6rbxX+CrZG+KYKM dR6WDjnDwuRdnDmp1XH0xBSCEIWEQfwvwuKCWAQyvVr3Q= X-Received: by 2002:a05:6a21:101:b0:3c0:cb82:508c with SMTP id adf61e73a8af0-3c36c371b85mr1287451637.49.1784086710623; Tue, 14 Jul 2026 20:38:30 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a583bcsm91977889eec.19.2026.07.14.20.38.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 20:38:30 -0700 (PDT) From: Biren Pandya To: mchehab@kernel.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v2 1/5] media: i2c: cx25840-core: Add missing media_entity_cleanup() Date: Wed, 15 Jul 2026 09:08:20 +0530 Message-ID: <20260715033818.10967-8-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260715033818.10967-7-birenpandya@gmail.com> References: <20260715033818.10967-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The remove function is missing a call to media_entity_cleanup(). Add it. Signed-off-by: Biren Pandya --- drivers/media/i2c/cx25840/cx25840-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c index 69d5cc648c0f..a3d7473854a3 100644 --- a/drivers/media/i2c/cx25840/cx25840-core.c +++ b/drivers/media/i2c/cx25840/cx25840-core.c @@ -3962,6 +3962,7 @@ static int cx25840_probe(struct i2c_client *client) int err = state->hdl.error; v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&sd->entity); return err; } if (!is_cx2583x(state)) @@ -3986,6 +3987,7 @@ static void cx25840_remove(struct i2c_client *client) cx25840_ir_remove(sd); v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(&state->hdl); + media_entity_cleanup(&sd->entity); } static const struct i2c_device_id cx25840_id[] = { -- 2.50.1 (Apple Git-155)