From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C675A3B1ED7 for ; Wed, 15 Jul 2026 03:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086726; cv=none; b=mMDfJrpCgkDp/QoCAATaFEOjrgUh7ANemcHf0wkJ5ZjXFpE6kmcxLMywKZodRCX2cu9JmfphXdvST4ANAcYey0BOKuScFJbi7KIatC5+WUiN2dIjiRHAZQI6xDOaaGJjh4rIv0kdNWzy1G74xe28xq9cJbtD2LCMW6kDrUyl1Mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086726; c=relaxed/simple; bh=JzjOso7/wwynAxHjmTNccaM/1TFx/LTbSs5RRtSmy/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CgWb+5hOWw6g4nz/rYmIMzi0vXM9wGjb3Zzd4ZXBbQWg149mWTbvj/vBzgVSA3/gT+W2nxKeenJEZz6srNhDcuju4qPj5mY9m42TVs9U6Jtj8yXMyYVoDXg7ZZ3QqILe9Kciu04cxAP6ZmhMTFLSv9kK34EMW+0t5v+ODQj32BE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UCJeeoXZ; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UCJeeoXZ" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-384c94c9414so1409170a91.3 for ; Tue, 14 Jul 2026 20:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784086715; x=1784691515; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NC0uBNFhos9Xnquc35vsABLKrcnqiNY5ZuQAYS1JZAo=; b=UCJeeoXZulm7k2Vr0CmjdyLODF+j1B+eZUoPiEQtO2AcTB5/pw8FTcBDiiOgzEeY/U ySt9elHtO3yU0jKF1QNBtkG188kub93MpGgG6PO06NxlE2whonlX8y8aqT+T2pHTkEUx OCQY3bYMZcfr4gw56oJeC56ynSZz7vgmohpSTgxBC2QXrMEUVweWBkgsTrPCGmHi4qhJ s+dAvbL5IajU492goTTiZ9BHIjn4qlUzhh8b6KEDZ3O97b3BwkQozv5bFo8FR5ZLY3ob CtfxO+BMyE0CKPPexL/UUkHWFUiu1YrddmeHmm6dToGyp6V6EvY9SHfKW3pSAxE8gw5q PE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086715; x=1784691515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NC0uBNFhos9Xnquc35vsABLKrcnqiNY5ZuQAYS1JZAo=; b=ZVBA1BRjth+lnisTczE4YRvqzYIV57nJpnfCfUWJgZuKayC0Ej8fxEVE53ulqF3RNu wW9lN3q1o35ZzJLa04WN4+DRBxiDxzyirM+HJfzsodx6ZXMK9JoLdnKW0AwnJ3N6mwXY 2gfxpy9ms89dSNAX7yMkintSeRkhgTYMDESHR4WqkHHyRyIVZS2Cm7Oq13W+A/XiokEp HYaaOk6iVqZ5xBkY9aFLjimE9WI3VfQWH3vP85TmqzpOttx5asWZZtYme5opK2phZzM2 pNI9D9LKWJCUXJiPwM21P3CqtrDBKVFaGdVtgK6tbMWmh8W0x+MRhIXQl46O8p9NEmEo /aKg== X-Forwarded-Encrypted: i=1; AHgh+RrNrFNd3/9JAcDezAIB7wFOwVbk8EjSXJn0pYo4HlzFooHyhBi1xsL+hOTKDxAoVnxna2eRTfU76aNZNQk=@vger.kernel.org X-Gm-Message-State: AOJu0YzKwWZOzv3hTsXkXRvXS0hGUQTtM9HjkTNY54ewa39HDfk4i1yr 1e97LKW77pwhL8MNpZOf2NuL8NsSKSAD+r2rwIg9CLUbEtty5T1PE9uQ X-Gm-Gg: AfdE7cnGmEpf8xCd9DKekoGPQ/7/dKXHezB/kwaXYjblApijQ/xtBKzaSkklbSQ5Tx9 Vm/fuMgPr4eEtx5ycRIlVa8yaAwqoa9cy4zyUPmyDIDAF9OzdHir9JftjLIVzHUZvq3s8a0d6SL Beme+bCsv6rippTzxZztE20EInbONt1YMMMzSnYfveKwqYxy5fKGYa2zf8JYrG3HS1JXW3FOlCC UBKXBsdtRX/sSlth2pxTcUnzuL417L3Ds1J++kBEEK8lhZ7V6F2cx/LSUe1hhW2J0MyM7nXJLP6 qoLNLSXwXzCE3c1Qcif2fGvtXBn3TWo5OJpWBYQLpOnjZm/wQj9QuOhDGBd1qYy4wBkbHwLpfgu cfrCnI4+IU3oXRhIFUIPTUjAaashf0Bq6DYg59O8luPIL6hu/6j6v3bucM10aWKpNoKeOw8Sn90 LGT/CbA3Cw5fI+VHgmkLpmkBQOeEmvHsFQhRghUt+R8gE= X-Received: by 2002:a17:90b:1fc8:b0:37e:2005:6507 with SMTP id 98e67ed59e1d1-38dc75f4cf5mr14387980a91.15.1784086714915; Tue, 14 Jul 2026 20:38:34 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174a583bcsm91977889eec.19.2026.07.14.20.38.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 20:38:34 -0700 (PDT) From: Biren Pandya To: mchehab@kernel.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, =?UTF-8?q?Niklas=20S=C3=B6derlund?= , sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya , Jacopo Mondi Subject: [PATCH v2 2/5] media: i2c: max9286: Add missing media_entity_cleanup() Date: Wed, 15 Jul 2026 09:08:21 +0530 Message-ID: <20260715033818.10967-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260715033818.10967-7-birenpandya@gmail.com> References: <20260715033818.10967-7-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The remove function is missing a call to media_entity_cleanup(). Add it. Reviewed-by: Jacopo Mondi Signed-off-by: Biren Pandya --- drivers/media/i2c/max9286.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index ac0712ce1e65..79eab9045e24 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1062,7 +1062,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv) priv->sd.state_lock = priv->ctrls.lock; ret = v4l2_subdev_init_finalize(&priv->sd); if (ret) - goto err_async; + goto err_entity; ret = v4l2_async_register_subdev(&priv->sd); if (ret < 0) { @@ -1074,6 +1074,8 @@ static int max9286_v4l2_register(struct max9286_priv *priv) err_subdev: v4l2_subdev_cleanup(&priv->sd); +err_entity: + media_entity_cleanup(&priv->sd.entity); err_async: v4l2_ctrl_handler_free(&priv->ctrls); max9286_v4l2_notifier_unregister(priv); @@ -1084,6 +1086,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv) static void max9286_v4l2_unregister(struct max9286_priv *priv) { v4l2_subdev_cleanup(&priv->sd); + media_entity_cleanup(&priv->sd.entity); v4l2_ctrl_handler_free(&priv->ctrls); v4l2_async_unregister_subdev(&priv->sd); max9286_v4l2_notifier_unregister(priv); -- 2.50.1 (Apple Git-155)