mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pankaj Gupta <pankaj.gupta@amd.com>
To: <seanjc@google.com>, <pbonzini@redhat.com>, <tglx@kernel.org>,
	<bp@alien8.de>, <mingo@redhat.com>, <dave.hansen@linux.intel.com>
Cc: <x86@kernel.org>, <thomas.lendacky@amd.com>, <hpa@zytor.com>,
	<david@kernel.org>, <yangge1116@126.com>, <ljs@kernel.org>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<pankaj.gupta@amd.com>, <stable@vger.kernel.org>
Subject: [PATCH v2] KVM: SEV: drop FOLL_WRITE for encrypted region registration
Date: Wed, 15 Jul 2026 01:36:26 -0500	[thread overview]
Message-ID: <20260715063626.65899-1-pankaj.gupta@amd.com> (raw)

Commit 7e066cb9b71a ("KVM: SEV: Use long-term pin when registering
encrypted memory regions") added FOLL_LONGTERM to
sev_mem_enc_register_region() so anonymous guest RAM is migrated out of
MIGRATE_CMA/ZONE_MOVABLE before a long term pin. It also kept
FOLL_WRITE on the pin.

Combining FOLL_WRITE with FOLL_LONGTERM breaks registration of file-backed
guest memory, such as virtio-pmem host memory-backend-file mappings
(MAP_SHARED). GUP rejects long-term writable pins on dirty tracked file
mappings since:

commit 8ac268436e6d ("mm/gup: disallow FOLL_LONGTERM GUP-nonfast writing to file-backed mappings")
commit a6e79df92e4a ("mm/gup: disallow FOLL_LONGTERM GUP-fast writing to file-backed mappings").

Region registration only requires long-term pin to prevent page migration and
does not write through this GUP pin.

Drop FOLL_WRITE and pin guest memory only with FOLL_LONGTERM.

Fixes: 7e066cb9b71a ("KVM: SEV: Use long-term pin when registering encrypted memory regions")
Cc: stable@vger.kernel.org
Suggested-by: "David Hildenbrand (Arm)" <david@kernel.org>
Link: https://lore.kernel.org/all/ad784f05-b36c-4e91-9f17-4c5b826735d0@kernel.org/
Signed-off-by: Pankaj Gupta <pankaj.gupta@amd.com>
---
v1 -> v2
- Remove FOLL_WRITE when the pin is not used for host writes

v1: https://lore.kernel.org/all/20260701144543.39582-1-pankaj.gupta@amd.com/

 arch/x86/kvm/svm/sev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
index 427229347876..5f2998761462 100644
--- a/arch/x86/kvm/svm/sev.c
+++ b/arch/x86/kvm/svm/sev.c
@@ -2752,7 +2752,7 @@ int sev_mem_enc_register_region(struct kvm *kvm,
 		return -ENOMEM;
 
 	region->pages = sev_pin_memory(kvm, range->addr, range->size, &region->npages,
-				       FOLL_WRITE | FOLL_LONGTERM);
+				       FOLL_LONGTERM);
 	if (IS_ERR(region->pages)) {
 		ret = PTR_ERR(region->pages);
 		goto e_free;
-- 
2.34.1


             reply	other threads:[~2026-07-15  6:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15  6:36 Pankaj Gupta [this message]
2026-07-15  7:35 ` Lorenzo Stoakes (ARM)
2026-07-15  9:49 ` David Hildenbrand (Arm)
2026-07-15 14:09   ` Gupta, Pankaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260715063626.65899-1-pankaj.gupta@amd.com \
    --to=pankaj.gupta@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@kernel.org \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    --cc=yangge1116@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox