mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Popa <stefan.popa@analog.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sa" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Siratul Islam" <siratul.islam@linux.dev>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Ciprian Hegbeli" <ciprian.hegbeli@analog.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Stefan Popa" <stefan.popa@analog.com>
Subject: [PATCH v3 0/2] iio: adc: add MAX40080 current-sense amplifier driver
Date: Wed, 15 Jul 2026 09:36:15 +0300	[thread overview]
Message-ID: <20260715063652.368501-1-stefan.popa@analog.com> (raw)

This series adds support for the Maxim MAX40080, a bidirectional
current-sense amplifier with an integrated 12-bit ADC and an I2C/SMBus
interface. It measures the voltage across an external shunt resistor and
the input bus voltage.

The driver operates in direct (INDIO_DIRECT_MODE) mode. Each raw read
triggers a single on-demand conversion (SMBus Quick Command) and reads
back the matched current/voltage pair, so results are always fresh. It
exposes the current and voltage channels with raw and scale attributes,
a configurable oversampling (digital averaging) ratio, and PEC-protected
register access. The two selectable current-sense ranges are exposed
through scale/scale_available; the current scale is derived from the
shunt-resistor-micro-ohms device-tree property.

Tested on hardware with four MAX40080 devices on an I2C bus.

Regarding Andy's question about *iv being updated even on error in
read_poll_timeout: yes, this is intentional. The poll loop must update
*iv on each iteration to check the valid bit. On timeout (conversion
never completes), *iv contains the last-read value with the valid bit
still clear, but the caller always checks the return value first —
"if (ret) return ret;" prevents any use of the stale data.

Changes in v3:
  - Remove mod_devicetable.h include (Andy, Uwe's rework)
  - Use lowercase _mV suffix for unit defines: MAX40080_INTER_VREF_mV,
    MAX40080_CSA_50mV_GAIN, MAX40080_CSA_10mV_GAIN (Andy)
  - Remove MAX40080_NUM_RANGES macro, use ARRAY_SIZE() directly (Andy)
  - Fix reversed xmas tree ordering in get_oversampling_ratio() (Andy)
  - Split semantically different variable declarations in
    set_oversampling_ratio() and max40080_init() (Andy)
  - Join *val, *val2, long mask on same line in read_raw signature (Andy)
  - Use const int * cast in read_avail (Andy)
  - Join FIFO_CFG write onto single line in max40080_init() (Andy)
  - Return i2c_smbus_write_word_data() directly at end of
    max40080_init() (Andy)
  - Use device_property_present() pattern for optional shunt-resistor
    property (Andy)
  - Make vdd-supply required in DT bindings (Conor)
  - Restore i2c_set_clientdata() needed for PM resume (Sashiko)
  - Add bounds check in get_oversampling_ratio() for hardware register
    values outside expected range (Sashiko)

Changes in v2:
  - Add vdd-supply and interrupts properties to the binding (David)
  - Add types.h and time.h includes (Andy)
  - Use USEC_PER_MSEC for poll timeout readability (Andy)
  - Use 1 * MICRO for default shunt resistor (Andy)
  - Rename field macros to include register name, e.g. MAX40080_CFG_MODE_MSK
    (Jonathan, David)
  - Add indexed defines for RANGE field values and use in gain array
    (Jonathan)
  - Use array lookup in get_oversampling_ratio instead of formula (Andy)
  - Use switch statement for chan->type in read_raw (David)
  - Simplify update_bits: one-liner RMW, return write directly (Andy)
  - Add local client variable in trigger_measurement (Andy)
  - Add braces to for loops and use C99 loop variables (Siratul, Andy)
  - Flip if/else in reg_access, separate declaration from assignment (Andy)
  - Add .name= in i2c_device_id (David, Siratul)
  - Reorder declarations to reverse christmas tree (Siratul)
  - Return directly from oversampling case in write_raw (Andy)
  - Add blank lines before return in read_avail (Siratul)
  - Add Co-developed-by tag for Ciprian (Andy)
  - Use Link: tag for datasheet URL in commit message

Stefan Popa (2):
  dt-bindings: iio: adc: add maxim,max40080
  iio: adc: add MAX40080 current-sense amplifier driver

 .../bindings/iio/adc/maxim,max40080.yaml      |  64 ++
 MAINTAINERS                                   |   9 +
 drivers/iio/adc/Kconfig                       |  11 +
 drivers/iio/adc/Makefile                      |   1 +
 drivers/iio/adc/max40080.c                    | 630 ++++++++++++++++++
 5 files changed, 715 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max40080.yaml
 create mode 100644 drivers/iio/adc/max40080.c

--
2.53.0


             reply	other threads:[~2026-07-15  6:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15  6:36 Stefan Popa [this message]
2026-07-15  6:36 ` [PATCH v3 1/2] dt-bindings: iio: adc: add maxim,max40080 Stefan Popa
2026-07-15  6:36 ` [PATCH v3 2/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-07-15  8:34   ` Andy Shevchenko
2026-07-15 13:41     ` Nuno Sá
2026-07-15 13:58       ` Andy Shevchenko
2026-07-15 15:09         ` Nuno Sá
2026-07-15 14:23   ` Nuno Sá
2026-07-17 23:41     ` Jonathan Cameron
2026-07-15  6:51 ` [PATCH v3 0/2] " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260715063652.368501-1-stefan.popa@analog.com \
    --to=stefan.popa@analog.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ciprian.hegbeli@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=siratul.islam@linux.dev \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox