From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6CFD3C584F for ; Wed, 15 Jul 2026 07:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784102177; cv=none; b=SAIwdUmzEM7KFRxq2bNPNqTSDtlxl734/uzb26z4owEq2p7S8KMePDp4MchzcgzcdzddVw6ufI2fNFiowKhfRMSnRTdvkrPoYQfFfR4wWib8BoPTTxmEhYYhalCIzFwPKnFcOOYA66Gje3KViTjFj0lcom7uBvQnZ5P0uqp9qHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784102177; c=relaxed/simple; bh=o1UOI4x9Sdti9Rwq7LDBhzWmbP5Y8aCqgX8jrlL8EbQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Y5+MUXavuivJMuqMTN+YeH7sg0A+EDDXWA1DST9Co5BRuUszO9WUj5GwT0rKNxG92Mz63o8kKtd5jfF9GOaccsWMilPJa0kwfvE89HXFKaXI+7cI9Hf+r92/KZa+9D+jShZLSS0ExI0fqcMef4cd6w4IlkMVDLLqX9XfhZF8+xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHGx5lg7; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHGx5lg7" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8485ef63b68so4652400b3a.1 for ; Wed, 15 Jul 2026 00:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784102175; x=1784706975; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FgB1QNokjBQfrUZXlrBy1dE0OfERYD7fnTE5ODO13eU=; b=dHGx5lg7ABZGp0Wxx8plPVGZ5RYJAHPSkOiikzIMbQP+bL4xCJJA6MZKG4szIk4VeT iNfy74Lzr87i1NouoWjv1Pcfge0vqFF/AWfEeSLu4UuBH3tJMPJba4pMBuxQZ2bqH2DG OtdJ7PrAym/VDaRMkemXGqh5FQJIJJ7owupUmu+eswDZkDsjJuNd0bkbTOK1/bWfX5IW azKo4mzkjQDDAj0D/2gNz4V35b2CMPpTkzhEp+JA1VRUv7d+GItsRmfDuLIWYUCfmnDt p+ueVjTHjXIeius7MFJArgcSrsPqOXZfL5oIBUolAxOsSwbyUGtgmI4ilN8b727ICtoI kBzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784102175; x=1784706975; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FgB1QNokjBQfrUZXlrBy1dE0OfERYD7fnTE5ODO13eU=; b=Lc+TCDiR/P1w62KMRMQMrqlzM3tTl0aiExO/t8/15nSfOgWT8G1P4YU+t4xCfv0vF5 5L/EO2ThpY0ljcgklzYQnEpCoB8jKV743e1cH5FFTr8szmJSHCY424WKVF0mUPU2P0I0 TiK9zK6uRW++oxqKzyHRCL8j/KlR6FtjVlrB2xie8lVgE9P1AORGlC2LfGRgZGQiONtv KMeOzCSaOkf+4//mQGcTsFmEL8ht8NgW3l2DJne1Pj4Lv3IxJwFIqvRlI4mtbiNsx5Y8 CUY+OuMl1oYX4FYSnAh9CEiq99yAYaASruBsrx+gDGxNP3YdmviYo3Ewa+zRUp/cIof+ +QCQ== X-Forwarded-Encrypted: i=1; AHgh+RobCaX5g1wBPXmqgFezNGCtY6kfGC8KpgDdbCpvFbDcs06PaE8O+/gkyDNkLh6bLyQu3rR5RPStucF9JTI=@vger.kernel.org X-Gm-Message-State: AOJu0YxRSTZABiF6vsAKmToW7FRfysX6x51A34+Ej7FvM5Es1nKXZUYn DH+NwA6T0/y2NRQRtGedfEIq2JqZ/mI0SM4P97JqkqxXUYm0BvexeoU= X-Gm-Gg: AfdE7ckHuXsR6nIR+yKZfBBlNhVxbDf3Ka4jA7pC7KLMe0ZvBsCbiXFiPkQNxHNJn8K nGDaPn4byQWjmyPz4GDa+m84QVrI2Lf34bswSKpdv/KUmt2hbHEfadRI2x3+HGFQpSHqNOPI/ER cHCD1Jg0dJfpilaMfQ4YoDhwJguEd7wVQabid6sftBy0Bb7EIbNRro4WPM60YrOI5RZ94zVxqH8 U6boU4K91HR46LH8v2VP/ayht9ZKRYL5zbBmtsCYD7Vh5XoZE1fUheXJkJQZRC7wWoEuxhlZt+/ Rvb1x+4p20LLY5bGldlLm/vGd1Swpq3DVzIaBbX0zRsZ0wF58/HZ74LG3/htXI79ySC3yjppxRs 3Nlhpnq+IAUvfmFDyBaWoK2kp1lqbnHRs1D0aySsslRv673HdOP1vJgflk2MOq3iKojIfHm+sy2 boU9dfI9bUvsrzS8aDTHHAJeNM8OdHKKo9WEw9p8jHmb45F6UeUr+V0qUVA5w9MYUCENysaF/uS qQfaVz61TENYF0sPMstThYZ+HT4aPrF7J2/y6EZBc8ATZ7PHIThk2Z/vfMt X-Received: by 2002:a05:6a00:4612:b0:848:2f6e:e52e with SMTP id d2e1a72fcca58-84a5587a0a1mr5492855b3a.66.1784102175283; Wed, 15 Jul 2026 00:56:15 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f7ea31csm2738303b3a.51.2026.07.15.00.56.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Jul 2026 00:56:14 -0700 (PDT) From: Myeonghun Pak To: Yong Zhi , Sakari Ailus , Bingbu Cao , Dan Scally Cc: Tianshu Qiu , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] media: ipu3-cio2: disable MSI on probe failure and remove Date: Wed, 15 Jul 2026 16:56:07 +0900 Message-Id: <20260715075607.62277-1-mhun512@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit cio2_pci_probe() enables MSI with pci_enable_msi() but pci_disable_msi() is never called, so MSI is left enabled on the probe error paths and on normal removal in cio2_pci_remove(). The IRQ is requested with devm_request_irq() and freed by devres only after remove() (or a failed probe) returns, so a plain pci_disable_msi() in remove() would tear the MSI vector down before free_irq() runs. Register it with devm_add_action_or_reset() right after pci_enable_msi() instead: devres releases in reverse order, so the IRQ is freed before MSI is disabled, on every error path and on remove. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c index 986b9afd7c..3f738ca681 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c @@ -1654,6 +1654,13 @@ static void cio2_queues_exit(struct cio2_device *cio2) /**************** PCI interface ****************/ +static void cio2_disable_msi(void *data) +{ + struct pci_dev *pci_dev = data; + + pci_disable_msi(pci_dev); +} + static int cio2_pci_probe(struct pci_dev *pci_dev, const struct pci_device_id *id) { @@ -1707,6 +1714,10 @@ static int cio2_pci_probe(struct pci_dev *pci_dev, return r; } + r = devm_add_action_or_reset(dev, cio2_disable_msi, pci_dev); + if (r) + return r; + r = cio2_fbpt_init_dummy(cio2); if (r) return r; -- 2.47.1