From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 862753DFC99 for ; Wed, 15 Jul 2026 08:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784105705; cv=none; b=XjhQ/jrjMkqGrkRBW+N8Vc53CAkDIWKe5rqBFtvPp3YbBzCiTocQv1SqBgPbf3eb3icHBbpuq68rwMxrwaObOyZA9Lc9UbrAc+wE84dMRZB1doF8R1tV24596dtQTGuWzjCQOn/sBDE7aI6hjeYBAh/FTqm1XvwohtimMELIOKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784105705; c=relaxed/simple; bh=y3WhF+SuyleAojl6FwQNCSw5fjhd9v1zDhHyaW9zvKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OBH5ER2fTGUU5aAUQuW/8K/gvYj4FvMQ/6OmE7lddVaBtI7yM6qINDFKsgMwPIlRtgkdcxYp3OkujSBux4aoPRubFA6y1tVokjbj27/tinZc9XyQn8W5VsZNiCh4SGteXbEBsAFf0JQSIQRCEwuJvnHhejKazY/wk7wRTw0JyE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=U4KiaC8Z; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="U4KiaC8Z" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-8486ac3f347so445489b3a.1 for ; Wed, 15 Jul 2026 01:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784105700; x=1784710500; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jC877lcIipbzPO12i6mSRmQx7EEzSrLJZiMLFWRppMI=; b=U4KiaC8ZHcotD1jLJItMvlRs1LXy3siwlGpuWwcVjaYsH2uPgbxhrljMsmmnnTdrr1 7RfAyNcwK2WRn6W4J6jlrEh23rCKQsvuExVUc6LwyJLCH9L3hkelsyQsM7v+GW89vtSy VOPwlU3gDFh+6S1Id18vmddoN/2FGNbbNfknI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784105700; x=1784710500; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jC877lcIipbzPO12i6mSRmQx7EEzSrLJZiMLFWRppMI=; b=MH92ygfXz3V2OLF0oc71lbn5Ik1c/K60KrOUAcfDQhu1mN8U67g6nLBE/GXXdCFf2d t6OxQQtJo0vBR2cQIG84Qaysw9VqN5V+VfSxPX4qVWdwkn2B5EBzcjS2DkRvztl1ukJX O3Ke+IlrRtUeElPXYc1qdLx76nLlpSC9W7IzNemCWtRME7D/H1bnB4rnbze4EhLt+W4z nxsOGehWeTYqh0MAV2ASzqDzEahFeezOmEVb0jomAnmK+kIZEpsvMufNutt89EaPgyLq z4qpI8ElmcygpzKQfz64JnIi1lmhGgQJp9CqXYK8UiirO9dXtqB83vPNHRqfG2gJ496u egrg== X-Forwarded-Encrypted: i=1; AHgh+Rrh+ZhCBZk6A/iO0stkyixnQ3Q68w8rwBseW31v6k40uupgf4SZ/GueeinCyW2DMGMBRwx4vlDVmgSWLPA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/F2+qVkSqyj3isscZzpbCCpGo6BZ+lzmYtSSucTPWn9exhqPU ZM+Tn1fMsiPcmAoZQPfgNIbO+vhUv/5AUsmTjQnRPhfK9GeoXABOjNykEKCwQO1YKA== X-Gm-Gg: AfdE7cl9Cc0MMlVS802Nzy+N1j6XBk2u36HwxB7oatl6EpLUXw4QsFzQpXb3uMoEB0O VScBBicx1RT85GpZfXwW0JpfUw7bSBrDjCsNUQePNNcDWBTisbnVad/UunvPrKS9VJYLiHswf4k r6c8l9EUZUcJxAqj/DQBZVCF72Ei0x09T7rynFeiAE+7GPJ2NF0tZq4O7WaPVYtlPZzjN7akWfc Y/A7n5f2cfJslhYnRgqDIcPpKTaay9R72yFagSwWtuBog7Xz3hmZ0Iq3ipdIDwqcV+Dm3+CbCUS e0uO+Cni8jpLjzbAUZk5r1QoZtcs33hRB/UDZvoVFdukAOWECxdq5tcf7a2uJU/ZC6ISEWhh0Lf e33h2MOjs8CTJTWhCUrrBBoI7XjeA2PtkcmPwrZdNApWmt+EwOg9D1enqDJ1MpqS8+kvzHjWpc0 F4ZdiYURb/3+00tegEkKGyJMa++H+kIkya/uIIbqCBM6q49102HJLmKyl9QPBQYnjuzxykEQ== X-Received: by 2002:a05:6a00:3928:b0:848:2f58:e1e9 with SMTP id d2e1a72fcca58-84870790b80mr18374319b3a.36.1784105700341; Wed, 15 Jul 2026 01:55:00 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:47d7:4aa5:a6f8:2279]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f819117sm2757491b3a.59.2026.07.15.01.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 01:55:00 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v5 09/16] usb: hub: Use usb_hub_set_port_power() to control port power everywhere Date: Wed, 15 Jul 2026 16:53:39 +0800 Message-ID: <20260715085348.3457359-10-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.141.g00534a21ce-goog In-Reply-To: <20260715085348.3457359-1-wenst@chromium.org> References: <20260715085348.3457359-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are still some instances in the USB hub driver where port power is directly controlled by toggling the USB_PORT_FEAT_POWER feature flag. Switch these instances over to usb_hub_set_port_power() so that only one unified function to do this exists. This makes adding external power control with the power sequencing API easier and consistently applied. Reviewed-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Changes since v2: - New patch --- drivers/usb/core/hub.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 40cdb63b5333..47010090d3b6 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -973,11 +973,8 @@ static void hub_power_on(struct usb_hub *hub, bool do_delay) dev_dbg(hub->intfdev, "trying to enable port power on " "non-switchable hub\n"); for (port1 = 1; port1 <= hub->hdev->maxchild; port1++) - if (test_bit(port1, hub->power_bits)) - set_port_feature(hub->hdev, port1, USB_PORT_FEAT_POWER); - else - usb_clear_port_feature(hub->hdev, port1, - USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hub->hdev, hub, port1, + test_bit(port1, hub->power_bits)); if (do_delay) msleep(hub_power_on_good_delay(hub)); } @@ -5434,7 +5431,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, if (hub_is_port_power_switchable(hub) && !usb_port_is_power_on(port_dev, portstatus) && !port_dev->port_owner) - set_port_feature(hdev, port1, USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hdev, hub, port1, true); if (portstatus & USB_PORT_STAT_ENABLE) goto done; -- 2.55.0.795.g602f6c329a-goog