From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C77353D9DAC for ; Wed, 15 Jul 2026 08:54:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784105678; cv=none; b=fzU6lzE3U08KLPxTvAqVZVlX3wQYkbkHFEEk++G6nTLXtMzAxqxFN4d5p64WUnHg69DO3GG2/+1iJZiGDdef/+l34WH9Ue3mK80jZh+zQ3OmIsHsn92QyXCj78gl+9DZc7/qVBNOGi1S8RiblkbMNuisd9l+ovPgR+yGZys9Srw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784105678; c=relaxed/simple; bh=OlqZwr18Cpifvs6/MASST22KmUKK2zb2fxpZOLeBWT0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KZKxnVk2DssIBr4OlUA9dW8NqiO7zVGz8OvIPEUvsP7LHV0TCjB/OrXGvBxZPP2Pot1lyXVIqbcbVNKa0LyRXoJIIFaV3poM1QSnLdcZUKNSr+rEOH0XrvxNy38NLofGqVIX6dwq0b6HAkMauUggDUAbed+OindkNjTKxVV1sOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VZgYdqBM; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VZgYdqBM" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso1822888b3a.1 for ; Wed, 15 Jul 2026 01:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784105676; x=1784710476; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dYICwpllA6REcHU83KV0EGKSQt2kKv+TAZuxEKEYalU=; b=VZgYdqBM9Bta0pcAAOAqBbcozTRYHYk57aR3CCuV4FYSSO4JxeTaLeOzu0Mpkt7PCU c4vU4T8TZ6DPuoPQ7wX5fWouPMzzxJ7aTFnDf+Ucl//tVoUCevXtg/Zi3zPLXN4SfZO6 KOJcR9CfC2XR4tZCmOUeRaGrFgodnGv1Yt2LE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784105676; x=1784710476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dYICwpllA6REcHU83KV0EGKSQt2kKv+TAZuxEKEYalU=; b=VSUSQNlKON1K08WwTSUMQeBLW50H6gv/67wn9GFvxq+R3Y8Qi+/iSyjdTbdVYle4xG Ez/1L2iQYQ9+103A/oGIvFPJ/xN0bxPfmD7kbQ/J4V4ISLaCHIqXrjctJgtLc3uuFtjg WFwoQdckKNKh74odpuVzwUm8J83W8rmRlXmx3QHUq23FzQLKvK/JVzbVNoUBY3YQGM/L cZAK58lR/Lx1HEoSaI5g8ZhQXGa0yxQF8R5h+nOvXaYmRq6GFetpFTJsaYvagq6OqmDh 4WP8tKZQesbPT6BTTBpXh8LLvRM7ZSE7vB/wnTCFmtvupBh+ugRaniUCWWs/qFQcVk+9 5i+A== X-Forwarded-Encrypted: i=1; AHgh+RqAZKEUmlRPFB8MBlZqck3LDTnR0UqslYGISVJDAORjgjiaRD4sl2ha423MqXUNYsdQQzfVewuORjEyq5A=@vger.kernel.org X-Gm-Message-State: AOJu0YxrlXsH1DbOoSLNtXgbnhNtoI2nHM5XBEN5cE0G0rv7YHBKfiT6 GL9IO1C30JVuhXycuedc0XIbTnywzm1/58jSxree4uwTTkWSQSYviED/5wrJYWbcZA== X-Gm-Gg: AfdE7cm8I9CffbH+QmP+fpjLHHCeZ9OZIS1PbwWYoZZs7yWl6FEF3vWVbkn1RSpU+7B /t6O8yWPWqIZWalR/gZ8HF/zWyClhNR7bfRi2izCiim8d9sUNqpn0X2ks0pFox5sr9dD4ZVXP75 6zWGatLqNJM+3+Xg9NoSw/bWgYkPXI6AL5A4WNBf3P1Z3NLAgH7U3QL3/jT6aZFp5Ui6ANdUaXm c9J9NPByAV1zxYBjLV2Q+BZEfqdqp4E0k+MpoEIXqfGFZcDwm+010duqkhGjIeY3+WurJ69dbsZ rtNhMiFFOAmzjyGea3cAbPPwPHt6/Oo0VIbeP52kU2Xty8HPivF8Ej6KvFfbCXw/Gues2fWnD53 IbrbSYN+0ukYg2qogYfjVgSsk5fA6B29xlasoNUNRXaybuJmCkmKA3W+5D1a4woZsnBaOcKq+K4 puS9x+ZH9HjQkpRWoeAW46e0+Lgf9rw/kOoI0+7vZhiTna4r9rQ01H5xx4XLE4i1YRAfSCkmjhf gR6R7Kp X-Received: by 2002:a05:6a00:17a4:b0:848:88e6:95d3 with SMTP id d2e1a72fcca58-84a673928d8mr1756444b3a.72.1784105676023; Wed, 15 Jul 2026 01:54:36 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:47d7:4aa5:a6f8:2279]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f819117sm2757491b3a.59.2026.07.15.01.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 01:54:35 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern Subject: [PATCH v5 04/16] usb: hub: Use assign_bit() in usb_hub_set_port_power() Date: Wed, 15 Jul 2026 16:53:34 +0800 Message-ID: <20260715085348.3457359-5-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.141.g00534a21ce-goog In-Reply-To: <20260715085348.3457359-1-wenst@chromium.org> References: <20260715085348.3457359-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit usb_hub_set_port_power() open-codes assign_bit(). Just use the assign_bit() macro instead. This makes subsequent additions to usb_hub_set_port_power() easier to read. This change does not introduce any functional changes. Suggested-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Attributing suggestion to Andy, since the change was originally requested as part of a review. Changes since v4: - New patch (split out from "usb: hub: Power on connected M.2 E-key connectors with power sequencing API") (Andy) --- drivers/usb/core/hub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 9b2bf608f9cc..36342c5718bb 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -10,6 +10,7 @@ * Released under the GPLv2 only. */ +#include #include #include #include @@ -896,10 +897,7 @@ int usb_hub_set_port_power(struct usb_device *hdev, struct usb_hub *hub, if (ret) return ret; - if (set) - set_bit(port1, hub->power_bits); - else - clear_bit(port1, hub->power_bits); + assign_bit(port1, hub->power_bits, set); return 0; } -- 2.55.0.795.g602f6c329a-goog