From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 394EE478842 for ; Wed, 15 Jul 2026 12:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784118579; cv=none; b=SXjEGi6cNAMkK6g7J+lusBZuiUi1SvYTdVGINOvgJ+3mO1ImmPBpa1Rm0VYEmyvdPkdEHpMDI1iYrHe8/c//nzSEJVMlUEefZIfgIxfBsgc2i6YzIlGpZQNqeiUL8ur4IHvGOKTmDVBjV0nF7Cfercnsk4B1GKfWX0b0XkBpADE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784118579; c=relaxed/simple; bh=7llQApEnqRUf+y2HW6MDlK9YjCFwPMY/ybzG2yeXDo0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TsEVhlhbY/ptphSGuiz1tdLyQIRRMOhHtuKyAECjWMv78EBOBBaqG4NPgXR0KVcFWibZx9bK6PTM+vApgoV7KomwbJrTePNJACGRT47J0vOvfW1Yv7RzuWuBE1s6IobPYU621X5BmTHf0bUMPVZkULn3valTfd//D0F57DGL2e0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g3LXj/0N; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g3LXj/0N" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-493c19bad03so48086305e9.2 for ; Wed, 15 Jul 2026 05:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784118575; x=1784723375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hGjJScr/bxpJuGG5Tma4ac3F09jinueH/67kipY/w2k=; b=g3LXj/0NCWmbARhwAEQZcK2gY0s1UZYCXc7wrAZfXdZnYKE3hmoGGGFlZ+mu98cEC7 ieRkYbUqynfgtIsSAW+3siQt/6dj+x724lzWamWhG1RlO7jToxoOcwDtsg7irBOe49h+ EBUlM6TNLPa3QF7shS2eFbcAUeWgxYoT2MLP3492uNljHeLMiPKj6AALcG9v7VDb0OoO jfSQH3kiL1sBlfar0e8TcEzZDjnk7EZYtAcTOztfiYdn03YM8YSh0w9Sb5lFk0y6skeB SbITDURaSYzlrVRkJVZLscDq6Y6h5+NsdzG6r6RAhkEIIMBhSLWHORkDS68hEPAtxFGP RuAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784118575; x=1784723375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hGjJScr/bxpJuGG5Tma4ac3F09jinueH/67kipY/w2k=; b=TldaY8Bfo8AOBtH4xFBpyJSPHUFr66GyBfVmK01HtKAYvCQKe9vVliaGfyRGE+F0qZ r0W3qwLGgPfSByvVf0ncHqucPZly1aETCGwcut8JnMJG7j/bjcaID5zPF3XSPL2XNVM0 IEkyTjtFGu2o85loLH30gqL0ClsheYfvBhz0CG346FT2LQoqJeL4AGYqhv44r60NihMH 8LhdB2+Y2xPqOiaAQXQ9D8EnhL0N6sJmNnkHjPpMKP7jOFTZz36ezUgHDYN1pugQYYyS esodKatCYTJped99gxppfIQF6/3DQBXu/mBC9nJoV1MItQuqg02c91SFS+zYooWxaG2l H3WQ== X-Forwarded-Encrypted: i=1; AHgh+Roxln51mMFiWr4tCxLXNOJpNYKkWycmDbsV2qsRIRzdt8NNomYU17rSHlK27ZtdtYvU2dwDkGAOXZQ/3ws=@vger.kernel.org X-Gm-Message-State: AOJu0YxIfojOCcPAgu3h5W3INaDUrGIp+AYbR+GLO4fKWm6mIXHYHVuW oulAIt0fECoVPOan8jF1+2+YVJYeNb14jNaZhB2/c2M176bCpx42btRr X-Gm-Gg: AfdE7clr2AyTx/3sfK4bs17SGEFH9wkK43YvN3GTaFCT2WMhbN7KJkwMuHRDnAzZrKn iREc7QwPHoLm5n8DZ6gWdTGefXGgbZyeUn5J8EpSpl9hbHNWQidjmG1Wxo2j5Ot1EqglA9k4IsK eTc92o5xiweOtUTMs7rHVXwB7u6OZZkqQQ8aKCaHIWzp9PZRHlvFxe39ttqZjFtSOSEIPcacWX7 KqaP7Lcsnb1J7EejUjoN5unkm9AG7SqJxbN/MjBiHbxaSTE1JWKa0cAoqXdlCJkXlmmLOzbRYTR Cgy9sJA8GUpR4GPT3F59z2PTgaDNevMVzVzOU4RkwkuaeqRglP3SdbgBnsixU/ZPUfzRp7JXZUr 9L2cy0jmOhWP/uVgaNWxxcqTfU/raiCUSEIgWazWVm/7mMGkDB9LRXE3rgncdj90VGP7u+1Nv+0 ObUYFkODfcdyJz3BuugfUyCzFObrCBt5Cp/g== X-Received: by 2002:a05:600c:3b20:b0:493:e974:41ac with SMTP id 5b1f17b1804b1-4953c168d09mr28802015e9.16.1784118574883; Wed, 15 Jul 2026 05:29:34 -0700 (PDT) Received: from taln60.nuvoton.co.il ([212.199.177.18]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4950a32a2casm216770715e9.12.2026.07.15.05.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:29:33 -0700 (PDT) From: Tomer Maimon To: andrew@codeconstruct.com.au, linusw@kernel.org, brgl@kernel.org Cc: openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com Subject: [PATCH v1 2/8] pinctrl: npcm8xx: enable RMII outputs from RMII groups Date: Wed, 15 Jul 2026 15:29:17 +0300 Message-Id: <20260715122923.1938327-3-tmaimon77@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260715122923.1938327-1-tmaimon77@gmail.com> References: <20260715122923.1938327-1-tmaimon77@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit NPCM8xx uses GCR_INTCR4 bits to release the R1, R2 and RMII3 transmit outputs from Hi-Z. Those bits need to follow the mandatory r1, r2 and rmii3 pin groups. The R1_OEn, R2_OEn and R3_OEn side groups are optional and should not be required just to enable RMII transmit outputs. Program the INTCR4 bits when the corresponding RMII groups are selected and clear them again when those pins switch back to GPIO or another shared function. Signed-off-by: Tomer Maimon --- drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 61 +++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c index c859dca4b..1d5b3c648 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c @@ -26,6 +26,7 @@ #define NPCM8XX_GCR_SRCNT 0x068 #define NPCM8XX_GCR_FLOCKR1 0x074 #define NPCM8XX_GCR_DSCNT 0x078 +#define NPCM8XX_GCR_INTCR4 0x0c0 #define NPCM8XX_GCR_I2CSEGSEL 0x0e0 #define NPCM8XX_GCR_MFSEL1 0x260 #define NPCM8XX_GCR_MFSEL2 0x264 @@ -78,6 +79,9 @@ #define NPCM8XX_GPIO_PER_BANK 32 #define NPCM8XX_GPIO_BANK_NUM 8 #define NPCM8XX_GCR_NONE 0 +#define NPCM8XX_INTCR4_R1_RMII_EN BIT(12) +#define NPCM8XX_INTCR4_R2_RMII_EN BIT(13) +#define NPCM8XX_INTCR4_RMII3_EN BIT(14) #define NPCM8XX_DEBOUNCE_MAX 4 #define NPCM8XX_DEBOUNCE_NSEC 40 @@ -1796,6 +1800,61 @@ static const struct pinctrl_pin_desc npcm8xx_pins[] = { PINCTRL_PIN(251, "JM2/CP1_GPIO"), }; +static u32 npcm8xx_rmii_output_enable_mask(unsigned int pin) +{ + switch (pin) { + case 178: + case 179: + case 180: + case 181: + case 182: + case 193: + case 201: + return NPCM8XX_INTCR4_R1_RMII_EN; + case 84: + case 85: + case 86: + case 87: + case 88: + case 89: + case 200: + return NPCM8XX_INTCR4_R2_RMII_EN; + case 110: + case 111: + case 209: + case 210: + case 211: + case 214: + case 215: + return NPCM8XX_INTCR4_RMII3_EN; + default: + return 0; + } +} + +static void npcm8xx_set_rmii_output_enable(struct regmap *gcr_regmap, + const unsigned int *pin, + int pin_number, int mode) +{ + u32 mask = 0; + u32 val = 0; + u32 bit; + int i; + + for (i = 0; i < pin_number; i++) { + bit = npcm8xx_rmii_output_enable_mask(pin[i]); + mask |= bit; + + if ((mode == fn_r1 && bit == NPCM8XX_INTCR4_R1_RMII_EN) || + (mode == fn_r2 && bit == NPCM8XX_INTCR4_R2_RMII_EN) || + (mode == fn_rmii3 && bit == NPCM8XX_INTCR4_RMII3_EN)) + val |= bit; + } + + if (mask) + regmap_update_bits(gcr_regmap, NPCM8XX_GCR_INTCR4, mask, val); +} + /* Enable mode in pin group */ static void npcm8xx_setfunc(struct regmap *gcr_regmap, const unsigned int *pin, int pin_number, int mode) @@ -1834,6 +1893,8 @@ static void npcm8xx_setfunc(struct regmap *gcr_regmap, const unsigned int *pin, BIT(cfg->bit4) : 0); } } + + npcm8xx_set_rmii_output_enable(gcr_regmap, pin, pin_number, mode); } static int npcm8xx_get_slew_rate(struct npcm8xx_gpio *bank, -- 2.34.1