From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 288CD494A1E for ; Wed, 15 Jul 2026 12:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119861; cv=none; b=I6rD082uGwrfVZaRLf7q72fKDbfFONRY2AzvXLt/KUbNpXCu8rpEbCgPXtfvvMmtbjmhEUqJDOeMO0RMIbJI3j6O0QQkIVa/NO6+5uDJEeBBdw2dIfH4BQ2d4EEo4Q5qODA+l8UeL+y75j3d0jDAaH2/eKN1Uf6Rl+VIZ3tezoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119861; c=relaxed/simple; bh=liJqa2gKzGBuo6lpJB3X0tG+AmpdAvgJqYlmJgVVIn0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qad4gr5GizhBb3s7blEwiFTchhEau/Bx8jbfY6gOgOOpx1sczhsiEKuWV+Gv8GaWL2PFhJ7k2ZpTobdkl3XaqJf70wJQ44dhrH2yxoLlHt6Z7oTXaerd8Zu7sTFTSjfcUPuO4Xbc/JSGW+RglIbsJ8YE4iGXFc728hEXmfabDfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JC3K+n2Z; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JC3K+n2Z" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-39c7ac9b8c3so19183611fa.0 for ; Wed, 15 Jul 2026 05:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119852; x=1784724652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=u0Mk5tzrjHYYy4SGPBdnNN8CoOej7gvf7wUIp89O/Vs=; b=JC3K+n2Z6NerqkcJZUnigjwyj5xCPFx3uqwcMWAhkMwAp4qoV1b2AoNVsa3pvCDEp1 eAvbjOeRvnUwWGMH3h0Oq/OK0zzIQ8+FL1tRIG5CvRN5wwX0lFgll0KzoKmyqr0viENn UXggEp3u8L9gGq7g2yuJancELp/AEXq2w9OA8U2lQDpdLUs31HotJkn3Hr181HvuWY2e Nf1tsyGV9qLA3Yzcg8qqVHwBGNFjIPW1L5wcQqEiqYKYRb8QZU8E6NKsS82y+xEcl/dm qlSKv545S4n0s11BP1Bq9RqtQK/f7p/RaUP7yRQI1bWUi517EeIKKqp1+8RdL4/jLN0h PsvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119852; x=1784724652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=u0Mk5tzrjHYYy4SGPBdnNN8CoOej7gvf7wUIp89O/Vs=; b=bRITKo8A8r0rRQ0La5+EpMJtpBNlN9RbZimEP76dwQTYN6HJzg40s9M9rQdbvBpgBS OR/I+kuz2oAELr0S5i+62NLsXkLnrm7EEkmNedQioAY+FhBSIprXmbugWhLZNl09rpAa zoesH5NP9HwZIWsLFPyMbjQ1ILVJ75CNG1pltIZAlWI04Da/AdB8XOtaE48Sh3WIWRDO 33xwv3L8jv0PESD1+tLZ8HoCezx9n/mJ7tPlaj7cJGjo5OPB9MAR5mb+pKqmVj+RbdkR JbXRyRBgor+Eon1+QEXXxk326+m0GI5iPoxrJnYxAoyymXNrYQY4F6Hixr6IGxcWP2oL X1mw== X-Forwarded-Encrypted: i=1; AHgh+RrFrzId71mWpJvHapbGBD/s60krVUOclkvY+bfYawuWl+eoMr2F9ziU72xKKLLzxgOslZDkmUX9OIAtL5M=@vger.kernel.org X-Gm-Message-State: AOJu0YyvgZbuDq/JSF99gFxqG45KYrAAZyzj8VNfuevE4YjKQOU6dj03 bYmCpzMImv4DkDaMQppgGxqkuTW7xUIo2N3B9zANwEbRU2BSVwYHMdWY X-Gm-Gg: AfdE7cmNA+PtTNJZZ7k37VvthLj+GgOFXK5OaCB+w0iZ9n8z6AqZFa01ImQWUUxx6Ao jHoHI0AelLAQ61aX/pdAAs+vLz9OUepL6jPYMq0/RRHkIt8SmfrBn6YEXrX4VUNmIDw8nJ17rOz H5Slgv5E36d5lk+OO6HyReR1UVdhy1qZKUO4mv/AjpcQf26MoRpvu6/6Zd9HC4vin2+LWNChrmT UKh7Dw5/jjPiJ+26ORlj6HTZHrnCpTAXfD/brvGDy/MfzM9vyDAWfA+nKUUwdOB0w1pCcwVRRZ/ FoJAmbbEzKPIHL6djS94wfHGVfVqhvzbnWUel1zfOMVuhJ+jwx8uiU+oyQtdm0n14Jdao1VdhIX 5CzorbfGJm6mkYi5C0k50XNh7hAW2cwFuGeWYK1WSRLQCKNe6LQ4m0JDlM1CGBi0d0rW0yNRRLd g7XUFax/raGhY3YDXybEPiBc+QJJXXlAKuG983ixE4ldZspj5mcbVDVJQ7MJ1q04B+KuuEdnhsI UVvxcPEA4wE6w== X-Received: by 2002:ac2:51ce:0:b0:5ae:c22e:a12 with SMTP id 2adb3069b0e04-5b0236be738mr4149530e87.65.1784119851479; Wed, 15 Jul 2026 05:50:51 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:51 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 45/61] staging: rtl8723bs: remove c2h_evt_clear wrapper Date: Wed, 15 Jul 2026 19:48:13 +0700 Message-ID: <20260715124829.90290-46-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the single-line helper function c2h_evt_clear. Call rtw_write8 directly with REG_C2HEVT_CLEAR and C2H_EVT_HOST_CLOSE arguments instead to eliminate an unnecessary function call layer. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com.c | 12 +----------- drivers/staging/rtl8723bs/include/hal_com.h | 1 - 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index 01f8b378e..c2944a1c7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1694,7 +1694,7 @@ static void c2h_wk_callback(struct work_struct *work) c2h_evt = (u8 *)rtw_cbuf_pop(evtpriv->c2h_queue); if (c2h_evt) { /* This C2H event is read, clear it */ - c2h_evt_clear(adapter); + rtw_write8(adapter, REG_C2HEVT_CLEAR, C2H_EVT_HOST_CLOSE); } else { c2h_evt = kmalloc(16, GFP_ATOMIC); if (c2h_evt) { diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c index 638d598e4..b357c5145 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -420,16 +420,6 @@ bool Hal_MappingOutPipe(struct adapter *padapter, u8 NumOutPipe) } -/* - * C2H event format: - * Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID - * BITS [127:120] [119:16] [15:8] [7:4] [3:0] - */ - -void c2h_evt_clear(struct adapter *adapter) -{ - rtw_write8(adapter, REG_C2HEVT_CLEAR, C2H_EVT_HOST_CLOSE); -} /* * C2H event format: @@ -472,7 +462,7 @@ s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf) * Clear event to notify FW we have read the command. * If this field isn't clear, the FW won't update the next command message. */ - c2h_evt_clear(adapter); + rtw_write8(adapter, REG_C2HEVT_CLEAR, C2H_EVT_HOST_CLOSE); exit: return ret; } diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/rtl8723bs/include/hal_com.h index e6d32cf53..0a43655f7 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -124,7 +124,6 @@ u8 NumOutPipe -void c2h_evt_clear(struct adapter *adapter); s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf); u8 rtw_get_mgntframe_raid(struct adapter *adapter, unsigned char network_type); -- 2.55.0