From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DCC4ADD88 for ; Wed, 15 Jul 2026 12:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119872; cv=none; b=aq4LFDjWKgYgO9/Ya/dqiaDSz93NyjY2p2NGneaaLRDgabhKc+fuMzjgUdXWnUM7t/jMrQvgK/vo7NTqeTJLbtqcRWe7NwdyIpWcZSKCanhGrHMb19oMEBpCbNOTj0nXTI7yRB47nqs+3t3H/ThTyc4xwf+icGlUKIXed7+PUZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119872; c=relaxed/simple; bh=meFM+m3+QXLv46H2Nga/34GDbnkXJvTqjgu2sz1WhSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cpfqtJ3omPO+yC0DwA7pOhYvaxhSjXsflbdI7JGP9/cGzX20L8Q7OL6p1p+9dx8X8ccjp7gOybqdpN7pLyq6GcOqDuZKYbVJJUu52919itL+LerPH7fBUYyuEhVZStHBhyDPbQIYk3HBIoLJSJlXlh6Cc7DkNBxsN0lI5csBxo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e+QojYoK; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e+QojYoK" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-39c83acb86eso19095141fa.1 for ; Wed, 15 Jul 2026 05:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119859; x=1784724659; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9jk3XKktcIbFuEFIN65sHF6Ly+ytHzoWCdAncm6Hg7g=; b=e+QojYoKBBwM+HPAUNkOg0g0aEc34TYfdmr3qzAvzJRcZxaN98Xrow4DSLbgYJfPbt edzneiPzsdSLZmH51tKZP0ffnc4VKiIN62WI6g6CTVA8NPShQlWqC9xD8W5EecDdfP3w zLG6/fETmYPs6l6eC0pwViBT1sFp8eEm+IrujOxL1zVKGC9jiwusCnPf+kTfrrh16tMV aLdKEmYe63SP2yjWlRC1Lw5ZHqOTmxhIUL5DhmNGlBtbzE4g7MWq1EjlvWqh+GuI8OLQ OgdKT/6YJc5hH7tSTACfjQhREI48vv/y20dlQQPwVC/1NYIxj9ewzODoy3wLexbuB4// wdSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119859; x=1784724659; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9jk3XKktcIbFuEFIN65sHF6Ly+ytHzoWCdAncm6Hg7g=; b=JAEIRMdXBldKX2Uimplx7Pjt9UvTDjoYUuSFO1X1NIJwlDjC72limfPODQLCuTSLKt HW6ujD1UMIg6EdgYbSoP/cTFf1AZVE0ayNcA//naVFoCf/zgftwd2YkSzHfC7WTZEFty xULwzWHjLyyjzHC7TDanwGXUtEhdZsLaXe5JoP2R64TX5PTrz6qjc9nuKaI4vpeHCuNi 8IudHT/WtzTc8xMtmIg9+utWsMKZYsp2U8oa5MlRmHZJVTKhrzSEtBcMWFvdV9GXbvnE juOFO0udYy/G2Cw1IGqkDwgn3+QTMUWfQkpU2ZllwBsuqh8o6lb4XiI3GynPnWi/9hYA eY/g== X-Forwarded-Encrypted: i=1; AHgh+RpkMkvMbMhnCQ0DrayyZ3NA1x+/GQxPgRtokzvFRmmzH2qJTh/hgc2t/MX4EfrtDAIMse9kMEEoC49q74w=@vger.kernel.org X-Gm-Message-State: AOJu0YxUEccWUx41F5ANvvUSG1ipz+6PkHGS2nqM1ihq0yZ2YpL8/Ekq lacycY61uiNmX0PhG6/ebU9V8IFS9w4veZ8mLWuus27yeR2RmfVbihlT X-Gm-Gg: AfdE7cl6+Q8aAHVueav6fJrDpZxoPAzqTkXDNEbI3wZ/8kACa0XupojucNBWPm91URs 8eM4bhx+9/hkC9cNu+1FSCdC+EPPLZE3hGa0y2JnPejVm1tGT5Va1+JxQhZgPjoLdkymRxVWfKs iQDR29pX9KIXrnhM/ibwlOBL+Igl28Vn75t5dIbFPvRiNfOjGC6f5q/Kaw3z+0S5SWsxTARQu+D CEyV53C5pX2iUsmdWDXezdx20OWGrFZS6NCYu0/CsI36oPISBILHwTSENKkztIx2BI6080akYLf QGs0tP5Pa6qRLa/8DsnStSxzbxrRt7GLNuUuHugDDXfIvdXAjF27MAGWfe7F1WYoDZsR0E/L+1+ emlUZcgWe1HXPlETc4iqP6sMfEJBPl5+kQYlGLb1xWUZo3uK92Fg0gopdexTtJkC0ynBzbs2/2p FzqsJy3WmkincJPB5LJ42wFLHti52Mgi/CzP8OqqQNMWshFLQzYVPqTp2fTo1aMFx7+WWlQ9r/d mjw4c+hVruWOA== X-Received: by 2002:a05:6512:61ac:b0:5a8:88f8:9ed4 with SMTP id 2adb3069b0e04-5b02369dae3mr4198488e87.30.1784119859340; Wed, 15 Jul 2026 05:50:59 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:58 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 52/61] staging: rtl8723bs: inline SetHwRegWithBuf8723B into helper Date: Wed, 15 Jul 2026 19:48:20 +0700 Message-ID: <20260715124829.90290-53-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Inline the hardware register configuration logic from SetHwRegWithBuf8723B directly into rtw_hal_set_hwreg_with_buf. This removes a redundant CamelCase layer for C2H packet handling. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/hal/hal_intf.c | 8 +++++++- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 11 ----------- drivers/staging/rtl8723bs/include/hal_intf.h | 1 - 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c index 92e4605fa..e58fc1405 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -128,7 +128,13 @@ void rtw_hal_get_hwreg(struct adapter *padapter, u8 variable, u8 *val) void rtw_hal_set_hwreg_with_buf(struct adapter *padapter, u8 variable, u8 *pbuf, int len) { - SetHwRegWithBuf8723B(padapter, variable, pbuf, len); + switch (variable) { + case HW_VAR_C2H_HANDLE: + C2HPacketHandler_8723B(padapter, pbuf, len); + break; + default: + break; + } } u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable, void *pValue) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index 22d6180f1..0155c523e 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -1079,17 +1079,6 @@ void rtw_read_adapter_info(struct adapter *padapter) } -void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int len) -{ - switch (variable) { - case HW_VAR_C2H_HANDLE: - C2HPacketHandler_8723B(padapter, pbuf, len); - break; - default: - break; - } -} - /* */ /* Description: */ /* Query setting of specified variable. */ diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h index b6ceea02a..1d5c0b7bb 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -241,7 +241,6 @@ s32 rtw_hal_macid_wakeup(struct adapter *padapter, u32 macid); s32 rtw_hal_fill_h2c_cmd(struct adapter *, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer); -void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int len); u8 GetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue); void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level); void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter); -- 2.55.0