From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 479BB4C6EF7 for ; Wed, 15 Jul 2026 12:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119885; cv=none; b=ngsOkkZ725E8dmDPzLv/h2/h6xaFNbtwXNMJIMIu/kZVqBnutdVSvaKevfd2GKjgtlJaoJ5tlHlb9IPc3+9PotIyzsvx5Vm9Gt+Mz8kOfK9hyePDNf0E77iSXS30Jex/8ePpVRubi0IQOvbkgdOOCGf4jkpKZ0nZBM1fgXiV1+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119885; c=relaxed/simple; bh=DRRvD86nDK2KcPwI5kJpJWsUlfUIah8s81TRQPIYBJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oJtfm+6riIHsLZbYIPspxwXgDUzcdRXobbUhkVUG70CybPdc+hMGNcVkyaesYYE7f1CFh4zBlPTTLRnOwTj7oCzIzHHskZ2OOFUond+BWOUjOgnZi4nwWK+ZJw0HArZpTZP4HUBE0UtUNwOJo2G4NnN46YQbBtY61zVRK8rmLHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dilQQZnL; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dilQQZnL" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5b15dcaca31so762241e87.0 for ; Wed, 15 Jul 2026 05:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119862; x=1784724662; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SvmASoz7rlm7VTOG5ZuhTdo5rXKqhp7vpcYKWZMpB7E=; b=dilQQZnL0ZlyhfA79ULQo22C+QRUP72o6xuVAV4G5Wl4Y5C9P7pBkkN1Shrg946aGp q9GdzFatnklAoZQIzu0I9GBYt6XqJBiozrSoVkzNDF9vaf5y3x72b7gATpf7GYZgZgQj F9QMsssoDILWapKLV0GUWahLGb9XGwiJzRJkQI7l1Mb8NekNSUYFeaTTwLkFKBDwqNTc uAmgioUxWgEcS8+zw8dVjiboThKTQ27Vqweho9kvnp2qHJlNBKwm9WZFEnd/jQV5wOUS o5A/v9yyWLW7uhuo/uTQPIvJNC5Ckhu08jpg2V33ggxFRjeVZw3jxZkNbjCb0gXK8AhV +A2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119862; x=1784724662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SvmASoz7rlm7VTOG5ZuhTdo5rXKqhp7vpcYKWZMpB7E=; b=DDXURN/KkWdkiQfkLfyjnscXzbHoKbERGNfTuDEpAsopx/lIrNhzmvSrPgELPCTUl4 3Rx9LmN21PpmeSBN1LcbJnARq/+SrthPUGl1Shs9cfv4BmwMHsDgwOLvAUSsoLdyJeL9 wM4KM9JZwt3kVvYODDuMflSUJEJtPjJOJAvuAYAL7CH7cv8ve+JJBC6UegVGjjppvuk9 m78qNdDpFB9UAb8Jag7ldzri4bAd+YPzAQvCQCapKoWdGHDeFCrGzUK5XY9FxA6K4MMO UsuQq7kCeYS/Ah+LztD4nc0o2FzJOdfjCJBJis3l8o8tglbAu2anoY0NZW2Y7Hn7+isx Ujhg== X-Forwarded-Encrypted: i=1; AHgh+RraXHQKBJxDE0SlSxM24zwUkyVw6zU8WsQY0yQV3pVF3I2IJfQe0lrRmBRSD1TYpL1Lp5AUC88jPDErbJk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq/8lpOpJHPKUeo8mDzZKUJP4/26OKtqnynGkhSebzIupd2Qs/ rStSTDVmB2AOYmDkrVQOr3bciL6TvhRB7cykdfXP4zaWVdSk8zZoOlPEc94uJkSKlR8= X-Gm-Gg: AfdE7cmgx0BjidtHScL5jns4x7Cpzd+VrkWKgZzdeQY1IytRXFKQfLPe8vmvqKI1frG uItXMPVssgRY5hv0LayzHlxcKMYFlwzdmSA5g3vT8lG8ZS7bNHoCHucGHSXoiWm91D37Ih7emeA zfazjMSHOydd3/VEKOlImcO/RlXYA++ioTTJB5+7RDL06dC8xS5pJDlu/xR3obm0U9SOkrhBxTp 0xOpucTuPzzSI52IHO8EL+AOiXYjknKruxoWxF1HA7oCpUEhP/Xu9EQa40xIMLWu1ZAASdnV5Z4 y+qKf8mwSWLe0/0CdywNHWZo7TONcfBRJWiVpTEi3wR3ROp/9Z94bzEIDwfFZrfPSGht+pNJLKc 5HOWE+JAbfXzaBSJcMStdK0QISVyq68hy4fKYotvXVRtym7hL19+U6e3Cf+BqIs7cDfrOUm3Tco 1mDp7h8exw/Mhn65Jv/v9rwaI34m68MAqxX/cd3P+MlP5cM+MPsGkXKXICLjz4Ly4JvnNWdup2V raea5Gad9qeLL5XedN/RXej X-Received: by 2002:a05:6512:39c7:b0:5b0:11cc:2284 with SMTP id 2adb3069b0e04-5b159b7255dmr1549433e87.21.1784119861898; Wed, 15 Jul 2026 05:51:01 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:51:01 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 55/61] staging: rtl8723bs: inline CheckIPSStatus logic with defines Date: Wed, 15 Jul 2026 19:48:23 +0700 Message-ID: <20260715124829.90290-56-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Inline CheckIPSStatus logic directly into rtw_hal_check_ips_status. Replace the 0x100 register and 0xEA magic number with self-documenting defines: REG_FW_PWR_STATUS and FW_PWR_STATUS_IPS_DONE. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- drivers/staging/rtl8723bs/hal/sdio_ops.c | 16 ---------------- drivers/staging/rtl8723bs/include/sdio_ops.h | 4 +++- 3 files changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c index d2e310115..a73abd36f 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -197,7 +197,7 @@ void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariab u8 rtw_hal_check_ips_status(struct adapter *padapter) { - return CheckIPSStatus(padapter); + return rtw_read8(padapter, REG_FW_PWR_STATUS) == FW_PWR_STATUS_IPS_DONE; } int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index c4058cfe7..dced13d2f 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -620,22 +620,6 @@ void rtw_sdio_disable_interrupt(struct adapter *adapter) sdio_local_write(adapter, SDIO_REG_HIMR, 4, (u8 *)&himr); } -/* */ -/* Description: */ -/* Using 0x100 to check the power status of FW. */ -/* */ -/* Assumption: */ -/* Using SDIO Local register ONLY for configuration. */ -/* */ -/* Created by Isaac, 2013.09.10. */ -/* */ -u8 CheckIPSStatus(struct adapter *adapter) -{ - if (rtw_read8(adapter, 0x100) == 0xEA) - return true; - else - return false; -} static struct recv_buf *sd_recv_rxfifo(struct adapter *adapter, u32 size) { diff --git a/drivers/staging/rtl8723bs/include/sdio_ops.h b/drivers/staging/rtl8723bs/include/sdio_ops.h index 252b0e164..b5d426c99 100644 --- a/drivers/staging/rtl8723bs/include/sdio_ops.h +++ b/drivers/staging/rtl8723bs/include/sdio_ops.h @@ -23,7 +23,9 @@ u32 _sdio_read32(struct adapter *padapter, u32 addr); s32 _sdio_write32(struct adapter *padapter, u32 addr, u32 val); extern void sd_int_hdl(struct adapter *padapter); -extern u8 CheckIPSStatus(struct adapter *padapter); + +#define REG_FW_PWR_STATUS 0x100 +#define FW_PWR_STATUS_IPS_DONE 0xEA extern void InitInterrupt8723BSdio(struct adapter *padapter); void rtw_sdio_enable_interrupt(struct adapter *padapter); -- 2.55.0