From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C514BC02F for ; Wed, 15 Jul 2026 12:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119879; cv=none; b=STVpKgPwbmfEVI6JrNy1gwHM2Vy7y34jnRImQj1COAhdag8KAn7qsWHfoBj47xOmdO/g/nKvy/5aCFpOzSKBzgnKYWhiL6DujR6FZSrhyTQB+ZD5Ib3vmNEgmHkR8dwcBI2cFRYHhuYOW7PlyTQSQDeMOf/OSqcFJZ1tHTeXAWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119879; c=relaxed/simple; bh=Vtr4UYwJobCeIRQMXJ4byK+T6xtCXLCAFgENupk65VE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QJGfieVp+Q+F+B0mtwA0wkt2TGV891VIX8bU0ofp+Hx/bV55ZYtY7mZqcUJIqEqDKEGL+IgPxClHcCMBJpZUVD7j9M0cs4rLlb+V/zXoHayn5oLon3K4iS9KMiRq+C238xqZUF63/ep4GnO76BU+v63j3yV1dpefE7M37s0DzFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hsPYPBlR; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hsPYPBlR" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5b021916bd3so4484417e87.3 for ; Wed, 15 Jul 2026 05:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119863; x=1784724663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JWQ3QnN0Oyq9QyqnlMfG+IyPMyxqK/+BZoxD0v9pTJ8=; b=hsPYPBlRuOfmZ6N+v8mMNBmknVTpnJjCf2weBv86lhY9p5HW7dP7zVlQuP8sthPRuR 4VPQ6oR75t/AeffiZ6shThTIYfOq5esr/5DLQIFW+2FrvFkhUCSHwAusi/mdrpMKq5OH W8PPbz4UqDq8uxYrxGE1FOh187J5t6Usck8L8dax0bOV58laMC56EFrc/9R915YYnY/X OtDZu+ZvrA7p6o3sHvZ2S+tK+oMioSsmO6hjBnzQV8oxrjvExngvqK77SsOufBFZfClR 4USiuqnxJI9bBis2mCQxionWc9Stdmfle5+ROmb3tWZBNPZxBBBwOQfB2H2oWMn12l0x X03A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119863; x=1784724663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JWQ3QnN0Oyq9QyqnlMfG+IyPMyxqK/+BZoxD0v9pTJ8=; b=fuIADFXEzD2dsg4hNseQEchYrM8OjiKgyJ4att6ks+wKwfb2U3ZvdhLJcta2NGpkD9 qZAu2DMaNWtjcgt2rU5AGRkc4qHw7tIk1ugnHyHJ80K+ydxyahHI7hv/hm31Q92TwBba mrgQ6zWWj2rh1eBg2w+5FIoXNi9KlI8pY6qnkg4oUfEN2SLZQZ5ZAdo9cWEhb4TEhJQV 9ETb8dBP3PSPGqN0zYftisYfkgFiKheSus1qieNDHZpi8AakdAoiaSmbxgPjaP9CRxhu lB2D4OaWJEClvGElyViioHX0zwJVvPrHS0vHwrsoC4+kfO4kp2ytMIsNa7pdtCK3M7kY qyEA== X-Forwarded-Encrypted: i=1; AHgh+Rp3bAI2b6n3wRt4auFHjPeKtdUg5eUzSQZqKB8naunjqOSBGJ+zQs8s0NBTddA2p+RZuk5lGZmVsyT/cTA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/7c0I8qyR+7TofaXN4ROOsW/CwTfbec08+s72b7Hlh2JEw6JO rYv2Wp3ssWyCK04+kJODTc0TdRApyFU+ylyYW3q8uSORXVoRcRXKWMYXKZ9fHdG9jwI= X-Gm-Gg: AfdE7cljNjuR4W41ozZ5IAiRa98pPDQZUmRksfYwpteFyf+OppaZbKSvla9lrpbl3Ug fPwc7WUiITeW/VbXjCoF1A6GOCY7m2mvPbn8SwIbqHKYsk+8mDAmWiR1V+7h93GAq0r2cJo0gaG xpgkDBvF5GnnNuh/7ZZaLN41wifGd3xV48svh2NWTQlMNMzbe/othNax1sbZ3WUbQ8KPUp0ICai OtVe44KNOqkklnHIrt2p1fPMwiLmc8F+fmhgAwP7BYuCAI3RJ1BqcneO4XpAiI6ETuAOrZoxdgh LWwEK4G/mn+N8RjfEADumkaqqyBOemVMcmWPfRnxBRlqUVuP8i2puWsejqwt1AvpnVlCHLKIU03 Q86q+BKTquWUymfDP4t/sKN9IWjx4tmZqAaOMIyHzUecrTWyFvp4POR65JELZBMwHy3TvQWaAPg IU/Zx3u8wxU6q3tAISO+vcPZcNGOYoeNOTyH1ts96wm9oVsSnrC4VDWrY8a+33Tiyz3OQll3/j7 zFmu1RiIS77pQ== X-Received: by 2002:ac2:5d72:0:b0:5ae:c7a2:69a8 with SMTP id 2adb3069b0e04-5b15d7a6a2dmr379701e87.44.1784119862945; Wed, 15 Jul 2026 05:51:02 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:51:02 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 56/61] staging: rtl8723bs: inline rtl8723bs_hal_xmitframe_enqueue helper Date: Wed, 15 Jul 2026 19:48:24 +0700 Message-ID: <20260715124829.90290-57-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Inline the xmit frame enqueue logic from the internal CamelCase function directly into rtw_hal_xmitframe_enqueue. This simplifies the transmit path, removes an unnecessary layer, and cleans up the driver code. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/hal/hal_intf.c | 14 ++++++++++++- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 20 ------------------- .../staging/rtl8723bs/include/rtl8723b_xmit.h | 1 - 3 files changed, 13 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c index a73abd36f..b11f4ab4a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -202,7 +202,19 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter) int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe) { - return rtl8723bs_hal_xmitframe_enqueue(padapter, pxmitframe); + struct xmit_priv *pxmitpriv = &padapter->xmitpriv; + s32 err; + + err = rtw_xmitframe_enqueue(padapter, pxmitframe); + if (err) { + rtw_free_xmitframe(pxmitpriv, pxmitframe); + + pxmitpriv->tx_drop++; + } else { + complete(&pxmitpriv->SdioXmitStart); + } + + return err; } s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index e40f69c13..a4dfee1d4 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -496,26 +496,6 @@ s32 rtl8723bs_hal_xmit( return false; } -s32 rtl8723bs_hal_xmitframe_enqueue( - struct adapter *padapter, struct xmit_frame *pxmitframe -) -{ - struct xmit_priv *pxmitpriv = &padapter->xmitpriv; - s32 err; - - err = rtw_xmitframe_enqueue(padapter, pxmitframe); - if (err) { - rtw_free_xmitframe(pxmitpriv, pxmitframe); - - pxmitpriv->tx_drop++; - } else { - complete(&pxmitpriv->SdioXmitStart); - } - - return err; - -} - /* * Return *_SUCCESS start thread ok diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h index ddf868c78..8d6d6d2b7 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h @@ -411,7 +411,6 @@ s32 rtl8723bs_init_xmit_priv(struct adapter *padapter); void rtl8723bs_free_xmit_priv(struct adapter *padapter); s32 rtl8723bs_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe); s32 rtl8723bs_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe); -s32 rtl8723bs_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe); s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter); int rtl8723bs_xmit_thread(void *context); -- 2.55.0