From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0537B360EE8 for ; Wed, 15 Jul 2026 14:23:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784125435; cv=none; b=bXhTEuXYaQAIW56RP7Os2bHvcF+p15DY2UqjXsp/3XVi3U26NpY4VzI8KoI71m+3vW+ng4s/7hNuBRtue+SJjyEyuUIjZlWCnN1+gDvSGMMjxj6EeV0XIJmaKIbQyMRA/yPUmUqZgHxRwYueUauk2KGvUBeOorvrn/IblK2epSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784125435; c=relaxed/simple; bh=p/A+hyd8Czmzv+d6bee7JEW5kyJdrX0FwFb3c+j1AQE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fdbR74FF/Rg2WaGQX2FGtNT2t1nTxdXW2XaP6tqYzxj9/r2m/qAbYSqMjZTPkrLc4fcsEF69XH9t2kfnT3S4Y/s6NeDKyBVgxe8q7030JrmrSdIe8tixNoVOFhaIUAiK2Wx0DI/Cz8rpK25r1A4H0v/vVhM/t8cuFcRaaA3dd8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SwqwjfgC; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SwqwjfgC" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-c12614b81c9so1022576766b.3 for ; Wed, 15 Jul 2026 07:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784125430; x=1784730230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=b3M40eRQW8Z0pMjSw8FZJIlwcW2HMM9RvErrQLP04DY=; b=SwqwjfgCEslbuijNYESdaBK7NoufURfPYcTjbE4T/OjQyYATATQZTStoennxlnpu/9 NEhpZuxqun84aEpeYVohYv2wjELeIsSFDG4Lyi2ROipBHnh2EH10zUx+sIUjlicx373R jF1pgN855yRVW9FSh49u+SfaoWgaK62n/OqKKjxshCdV1DtYk/nWWzdVSXtQ90PAObYn Mstc5Hx8fhI9BQ4aF37Hj55jNYW5Zouz9ru/EVPJElEMqsZbONui8qQB4Wm9Dp1PymRM iS61BQP8tV5COrkfwbiCMvGoFMvcmYVFg2Li7R0KIQVX2LOiowwAi9YcfgU3WqlRXukI jrMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784125430; x=1784730230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=b3M40eRQW8Z0pMjSw8FZJIlwcW2HMM9RvErrQLP04DY=; b=Qwpqv1T+BkZnLPPu8I1CeFxm8sdeQNh8/sA9sjWSbXlBbSP29B2G1xq7Bv80OO/PkN irrvrPqH2rL4wpVYO+Fm89tgBHnojqM0oRJPTdbZwYUaS6y7UdyWEnXh+HuT7sScMGli 2a4CpH3PfT2fjSAnqokzC+qqNDgHxV00vw3isLQJCMQ2DXmM14rTOSiKb9pOH6LkMqWw QvKqCDdGmFjAJthw2XPFjGPgmpdKgJAjJ1xSdK3cBMMp5TDSMn5TAxg2UvHHCGp3WCQ4 T9wK9hQuhStlg1W430mNr/Wv2kDd9VZ+NlT2I4D5WrhRkgc742gXl3y53SQyghQGs4BT w4mQ== X-Forwarded-Encrypted: i=1; AHgh+Rrovde5xX9iq3QcJujFkVc3fhDcFIpRTdU2WaemBguDxh8hkmJ+5clKKSDST4P8Qs7/lj7S/1ahPxC1Trk=@vger.kernel.org X-Gm-Message-State: AOJu0YzpRdYLUrtuG6jJHVJlblRbSdHqBNQqZTzbiCX4piRWyQcpLjUh EBifD5Le3R+TSc+yH162D87QbDDHh7DrySsXegdJSHv6H2GV0T9TZmwh X-Gm-Gg: AfdE7clctvs+8Cs+nDJwXJUOWpdgQfrZS9HG2ZfxyJPjIQ7kDOAoRjTBbhwXr2YD4wO WfeAspl1QYUAajc8FO4XswZu3T9x1idww2GzjV8QyBGiIbLnEsx+5JYzsmp4AaneC8hrSFY+wnI DyXNknZ3LIBXA0WhsjnGbyMJfH9qWKGcnBtsAeR6gTVjyz6oIX/WIHuR3Npbmf+lCwHsOPunvDs WixyCufyoqBSNiujYR95uQ0jVo8iLxShrbF/vjGXqfcdInx7T+fBDEvffo2jAf7JNk2bpEVtVAd ABaOGmyiUKF6TQqEA9hXCgxEIafy1afEsMvq2DGOSHas+wZwEYQzRZOQMi0kMHB7B10b8rSnHSB B+BoY/gl/FFUjU/xbNBX1I2oJegoK/RNes8DnQgSxDEH53K0ATGeLtA8fICzz1McyOJOE/DkNWe codDTRQJamGuZ9glY+b1ofjCc+OEluv6S2W6uY2BnIeNAUoxoq0eHkx5hE8H772baEBWaWGpxrE /NT X-Received: by 2002:a17:907:d16:b0:c15:bc2d:e938 with SMTP id a640c23a62f3a-c16792a5887mr227159666b.32.1784125429946; Wed, 15 Jul 2026 07:23:49 -0700 (PDT) Received: from misharu.home (2a02-a463-a071-0-8f3f-3afb-28f6-19c0.fixed6.kpn.net. [2a02:a463:a071:0:8f3f:3afb:28f6:19c0]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c168744bd40sm38743766b.43.2026.07.15.07.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 07:23:49 -0700 (PDT) From: Hari Mishal To: Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Gerd Hoffmann , "Michael S . Tsirkin" , Jason Wang , David Hildenbrand , Henrik Rydberg Cc: Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Hari Mishal Subject: [PATCH 2/4] virtio_input: validate device-reported multitouch slot count Date: Wed, 15 Jul 2026 16:22:41 +0200 Message-ID: <20260715142337.22811-3-harimishal1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715142337.22811-1-harimishal1@gmail.com> References: <20260715142337.22811-1-harimishal1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit nslots is derived from the ABS_MT_SLOT maximum reported by the virtio device. A device could report a bogus maximum (e.g. -1) making nslots = 0, which input_mt_init_slots() does not reject; it returns success without allocating any slot storage, silently leaving the device registered as multitouch capable with no backing state. Reject non-positive slot counts before calling input_mt_init_slots(). Assisted-by: gkh_clanker:t1000 Signed-off-by: Hari Mishal --- drivers/virtio/virtio_input.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index deec24e8e682..2cc19782cdd3 100644 --- a/drivers/virtio/virtio_input.c +++ b/drivers/virtio/virtio_input.c @@ -312,6 +312,10 @@ static int virtinput_probe(struct virtio_device *vdev) if (test_bit(ABS_MT_SLOT, vi->idev->absbit)) { nslots = input_abs_get_max(vi->idev, ABS_MT_SLOT) + 1; + if (nslots <= 0) { + err = -EINVAL; + goto err_mt_init_slots; + } err = input_mt_init_slots(vi->idev, nslots, 0); if (err) goto err_mt_init_slots; -- 2.43.0