mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ahmed S. Darwish" <darwi@linutronix.de>
Cc: linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] Documentation: real-time: Add kernel configuration guide
Date: Wed, 15 Jul 2026 15:15:09 +0000	[thread overview]
Message-ID: <20260715151510.33A621F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260715150147.225715-2-darwi@linutronix.de>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Reference to a non-existent Kconfig option 'CONFIG_WQ_SYSFS'.
- [Low] Unused hyperlink target '_development work' is defined but never referenced.
--

--- Patch [1]: [PATCH v3 1/1] Documentation: real-time: Add kernel configuration guide ---
commit aafa57307e83d54cf2bd4f383aa2ee5d683dab92
Author: Ahmed S. Darwish <darwi@linutronix.de>

Documentation: real-time: Add kernel configuration guide

This commit adds a configuration guide for real-time kernels. It lists
Kconfig options that are recommended to be either enabled or disabled to
help manage worst-case latency.

> diff --git a/Documentation/core-api/real-time/kernel-configuration.rst b/Documentation/core-api/real-time/kernel-configuration.rst
> new file mode 100644
> index 0000000000000..008d706f36cd2
> --- /dev/null
> +++ b/Documentation/core-api/real-time/kernel-configuration.rst

[ ... ]

> +Alternatively, confine EFI runtime service calls to a housekeeping CPU by
> +restricting the ``efi_runtime`` workqueue CPU affinity.  For example, set
> +that workqueue's affinity to CPU #0 and pin your RT tasks to a different
> +CPU range.  Note that exposing workqueues through sysfs requires having
> +``CONFIG_WQ_SYSFS`` enabled.  See :doc:`/core-api/workqueue`.

[Severity: Low]
Does CONFIG_WQ_SYSFS exist? Searching the Kconfig files doesn't show
this option. Could this be confusing the WQ_SYSFS allocation flag used in
the C code with a kernel configuration option?

[ ... ]

> +References
> +==========
> +
> +.. [1] See :doc:`/admin-guide/kernel-parameters`
> +
> +.. _development work: https://lore.kernel.org/r/20260227170103.4042157-1-bigeasy@linutronix.de

[Severity: Low]
This isn't a bug, but this hyperlink target is defined here and never
referenced in the rest of the document. Will this cause the link to be
invisible in the generated HTML documentation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715150147.225715-2-darwi@linutronix.de?part=1

  reply	other threads:[~2026-07-15 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 15:01 [PATCH v3 0/1] Documentation: Add real-time " Ahmed S. Darwish
2026-07-15 15:01 ` [PATCH v3 1/1] Documentation: real-time: Add " Ahmed S. Darwish
2026-07-15 15:15   ` sashiko-bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-14 17:41 [PATCH v2 0/1] Documentation: Add real-time " Ahmed S. Darwish
2026-04-14 17:41 ` [PATCH v2 1/1] Documentation: real-time: Add " Ahmed S. Darwish
2026-04-14 17:54   ` [PATCH v3 " Ahmed S. Darwish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260715151510.33A621F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=darwi@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox