From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6361306B3D for ; Wed, 15 Jul 2026 17:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784136646; cv=none; b=qM0xicro9Co/iCfMW8xMopwjj9UkZbWCjdoQOAdNsYb51pS9IMfi4ut50stP7cZzrvAUF3XvidScnaKP/W3Ll9LDuFnhm7d6892RI5wCvrrxtRI/bA7hHdoRvCtOEc8F1sxo17GHJKTkJzdKiDTBHLlurRinXxKH6vPti6MfG6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784136646; c=relaxed/simple; bh=l47BE7pUOntdEn1Mu5nMlzXv1Lh4KNOOZ4NVwlROktM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qw2u/xd+Pyxl0vAjTov174S/StoxwlWx2++Bm5sVcHlLElFbBDsE+sTV7RuRfm2PVkcqeXIzbsw00BEyked1GD14yCZ7ByyOvpftzS4PhzE0IO+BVmUxi388p+64md0NSXkCYigNLU3e+09Zpm3pV/FxsZjqCdDCw2r+9QVtKgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R5VC9LRO; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R5VC9LRO" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-476d8e647e9so5409369f8f.0 for ; Wed, 15 Jul 2026 10:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784136641; x=1784741441; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tJeFAR7iwdWGDaIC40OEbm2UHXdTFtuNScwJl51xzPY=; b=R5VC9LRO1+xFYQMIlji7JH8dX0+SHXW7bsnM+uvsCWGQoP5ABUryvOzsgPVo+9PDDJ yec8Ek+2hxbJX+hJ5KTh3YNamAPwdZz0Eg/v9rU/OrlxdkrncawMyiusVjElpDuc62h+ HSH9PJWCVKgbg8n934zUwRfzgPmzBYBbEfPRsZQfbIqUnB9n6LQPfnWwM11WW+YTyF18 B8RR4OaW3NgWKZRKxW+fxgHVbGKjkY1v5sSh9cjQcpyPH9hrB1eEhrQyvIgG73K/B6WK gwy02uRCDIRIkxTEa3E9CJ4Pk5KdKy8ZR2K6zPdKl8K/W0ADylYtuntVxwng0n5mmkgD dhow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784136641; x=1784741441; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tJeFAR7iwdWGDaIC40OEbm2UHXdTFtuNScwJl51xzPY=; b=JeWqNs7e07SP3+oM6/Vm90JiY5Usi2KBepvjUJ9/MGxMw4NwoGp5R+LbhfJGZV/KlV 8m2Z8X/YUVaCp4lbrwWfsRE6486P1qpKYKgILeXnunDCUkW0e4eC/RTbspN5tVwVm1nR lFHvArtIDio+d2BaRuMgxLzdbd7VTZ0sepDmGyrNR8gZpv40wj9hhNnzp7TAmltSvk7w Vl+tOEjWVBDX6u2OSTNEpVU3o34wRUj1kdy9yrJAWsSeWMxhW0VgIxzjRrt3nZUV34AI 25WYJVdBmk+i0VPSZbjlVtYsPOGFNoPmaKuf4QkD/MtdAXJEFSkYOto/15YB6KYcKP1s WSkQ== X-Forwarded-Encrypted: i=1; AHgh+Rryk98fnOZiQnKcGk74kO4Q9yjf+KCgnkk/m9AjYD+MZU9eVzTGQ1+9PzuKqeumKEGxuCLzOQX8F57DYlg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3Rx3ci+lu/LSDLN/UfzRzRbZ7ndr3aLT4rrJQhwIyUekS/ynA IHZ+hMtk7E3d6aSsuqDP6YBtTi1JLbP/s3yH17zafx6LW5B3IrZ/LemtGfcLs2ztUpJKCw== X-Gm-Gg: AfdE7ckv7KnnHC6BAlzqEC2eRroA+WoMEsJKRCPARimIoNKuKxwf0L2kiaIO5vyLpZi aVBolYNixCSen++nnfIV9fnnAkwWaMYvK7myOQ9aC619BK3Pzg05LdExggh1r3U9O2xWfszEwsJ vBC3I5q1CHtql4868xUqG5aVvzvK93IbF/6Hc7mJBGfV2K52jhkNxUizNA94CbLrE4uDg36WzHe WXzZa1wzXVXYSIvOf+od9aoSrObgVDBtRrdgd0lDy3X8ZAJ1UcMwYF8CAjJNyqHr739piwq/KID GEe2SLZY8WTmMfQjMzzcJeWwfWYg+rLzUgqqxzRXy1uuwIwpa4B1YTV4wZPAxjTT9tT1qzdGAzi V/pKeV5dwcL2uccq9jl1GpXgE413TM5+QWcaQsXw1aGyi0lTSw3sIKNIKVnG4UuRzNJ/zRQsjdE DgSK/95JRpVTvJdacXZRDYuIWpKnE= X-Received: by 2002:a05:6000:18af:b0:46f:7d90:8128 with SMTP id ffacd0b85a97d-47f4885669dmr9952433f8f.14.1784136640969; Wed, 15 Jul 2026 10:30:40 -0700 (PDT) Received: from Ubuntu.. ([2.147.165.129]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f4635082csm17997981f8f.7.2026.07.15.10.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 10:30:40 -0700 (PDT) From: Mohammad Davoudi X-Google-Original-From: Mohammad Davoudi To: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, rmfrfs@gmail.com Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Mohammad Davoudi Subject: [PATCH] staging: greybus: Replace sprintf with sysfs_emit Date: Wed, 15 Jul 2026 17:28:58 +0000 Message-ID: <20260715172858.17658-1-MDavoudi2011@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace sprintf() with sysfs_emit() in sysfs show functions. The sprintf() function is unaware of the PAGE_SIZE limit of the sysfs buffer, which can potentially lead to buffer overruns. sysfs_emit() is strictly designed for sysfs attributes and inherently protects against buffer boundaries. Signed-off-by: Mohammad Davoudi --- drivers/staging/greybus/gbphy.c | 2 +- drivers/staging/greybus/light.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index bdb0f5164..bb9a5b538 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); - return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); + return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); } static DEVICE_ATTR_RO(protocol_id); diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index cab02b5da..2689f9a75 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev, \ struct led_classdev *cdev = dev_get_drvdata(dev); \ struct gb_channel *channel = get_channel_from_cdev(cdev); \ \ - return sprintf(buf, "%u\n", channel->fade_##__dir); \ + return sysfs_emit(buf, "%u\n", channel->fade_##__dir); \ } \ \ static ssize_t fade_##__dir##_store(struct device *dev, \ @@ -220,7 +220,7 @@ static ssize_t color_show(struct device *dev, struct device_attribute *attr, struct led_classdev *cdev = dev_get_drvdata(dev); struct gb_channel *channel = get_channel_from_cdev(cdev); - return sprintf(buf, "0x%08x\n", channel->color); + return sysfs_emit(buf, "0x%08x\n", channel->color); } static ssize_t color_store(struct device *dev, struct device_attribute *attr, -- 2.43.0