From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79040495509 for ; Wed, 15 Jul 2026 20:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784145861; cv=none; b=IXDH4FIc5Xp25GdQzicuKLf1bmQObeEw88fuV9NJ9Mz07xjYQA1EojPWBQROO7/VM2yTDavk1q1YlhYfxpu1bdYn9bfzu/x74gXWweqG7TWFsUZDbEsbAmA+oJXdUNZfHZWvq0gVf29B1deBeU3D0njp1BAkPoXCW2yFB5KuZro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784145861; c=relaxed/simple; bh=AsGw2cfLkaONb+hz1lp1JsC0pssrsQjFnxY03Ut6hJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D/gHyswvdHcPwW+jzxo7I3i2PS/+yxvRmDWBkkYvNFKyx0DFUYTp0mHZqhlcCt1qWmi9nwy2OC62ydehFL7kUurrcuGQwdoKBwbfZ8zCyM3SXBo0UGptZLKSvfwOh97jPz4cM1c2kvjZQNe8bExmVlp6nytTQNS9ccdSAlMq+pw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f+UDWPTv; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f+UDWPTv" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7e9ed64d490so2208450a34.3 for ; Wed, 15 Jul 2026 13:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784145857; x=1784750657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AsGw2cfLkaONb+hz1lp1JsC0pssrsQjFnxY03Ut6hJE=; b=f+UDWPTvhTLvpaUFs5mAgdRDEibmq7Kap7Kuf++80dNphcX/o1qi/AoIc3Uwk/Xs9u l/bkQ4GP4siHpfg6uZV5RniWK/E03Z2Z7iGPnUyyB3INk25DKurjj15ebPDbzdtj4zxt xbQnNDicuc0IZg1M9IgAP2YOSyd5iRCdS5RfnSIS3A2f8onsbvrJx47koEjlPb8sdsGN FXy8cn7ouNUUDpS00YwivHpmiKCvJ+UjfweLWCw1lCeCpbVKLge28ELEb6yj8tuql6en l6BTmIFRYD5rp8ImGVvrP+KfKB6BUb4OEgaIsyl0M0z5AaDkPIkjJTO3ddjNH6MCcGWc g7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784145857; x=1784750657; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AsGw2cfLkaONb+hz1lp1JsC0pssrsQjFnxY03Ut6hJE=; b=cARTd0jau8kdhhOLCRYc+UneavHL+B3HHVRJ7o7dJAMgoe6St62ZDHhDyeuWB1H2d3 YrvcCD097zCL7pB0I2WavoLlihH8sPWGN5jya8uZqEmmu1UptsAa2Db5iMaemADRVbw2 +3OYnURFz5dEigBabNfMwIcun8u7JPamh0+SCmL2hnnwOHJWLv9BpBqjxrMJysyg4NSv 4a/b4gVFQsO7/ZvG4LThzkpQzFssW8257QgZBp/G/Jw3/KqOnbN5X3SzXWo+59WvWTDo /YiWEeIRygS09xI5LPL0tUwQL+BLS2bquiO7lVpKuxpI7/wzvZrN05qdS/ChrPaK2QMH uPiA== X-Forwarded-Encrypted: i=1; AHgh+RoIQOloy0yNPhHSCo6MVulspw6zfEVbF7juQh5MUv8tTy8D9cJclUBcIcxumfuO4IfYDXu5SkAKyuZaazU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyxp5LXB/QMpx96VXHMMIoxCjQjGeJ63wigoMQ1wPTrStu7MEU9 qwxIxahuAC+J5wIPc4H6VWUMRHEXqspJmeZrDBtO0s+Tsltykhvmhfk2 X-Gm-Gg: AfdE7cmUicQ8ZWSG8DTh9IfD5Oh1o1JGZxw3vDhp8pM8el00EwiP7TXHxeN9rSISXAM 9mXcdn45WN/77yz6jGo26qrqRmSeYZYrv87aFEAdDYh6bMRsrM6sU/n2JP4IUyTuq9cZogcWTG8 cgNHdYkM+y4jaUlQPOE+RHC/i/xcmmgx5seur2mDma1p+3bzEyYsY5nR0VZVUEw/8J2ejwizpX0 U9oU/XPU3O2hQq0fRpDAiUUL4jhV7yCgK0b/TYI5wVgX3jaXvVG3UWKcOMvJIz9siJSggSHQDqu 6Lkodcv5YCYQfSHUi+RVhIVfv0aYObSzo2s9hAe1+Y/P0F1RP0PMHHwBwJ75IgI/UwPVKMQ1nz7 TQ/L215Drre/oxLCE7olRfoN3+HedDFH9LU49hq7wwVEgyNikI33Cj8xfCeqDrywhM3x9Dduh4e 2/pyBagOAR9R0F X-Received: by 2002:a05:6808:f8a:b0:4a4:744:a4ff with SMTP id 5614622812f47-4a495ec0433mr2616051b6e.4.1784145856699; Wed, 15 Jul 2026 13:04:16 -0700 (PDT) Received: from desktop ([2806:2f0:9260:f072:92d3:78b1:9863:130a]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a1ad6b73c1sm16842969b6e.7.2026.07.15.13.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 13:04:15 -0700 (PDT) From: =?UTF-8?q?Jose=20Villase=C3=B1or=20Montfort?= To: Alec Hall Cc: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Jose=20Villase=C3=B1or=20Montfort?= Subject: Re: [PATCH 3/3] HID: magicmouse: report charge status over Bluetooth Date: Wed, 15 Jul 2026 14:03:54 -0600 Message-ID: <20260715200354.1307250-1-pepemontfort@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260714101235.99447-4-signshop.alec@gmail.com> References: <20260714101235.99447-4-signshop.alec@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Alec, Thanks, that all sounds good -- if mine lands first, great; the wrapper split is exactly as you describe, so rebasing 3/3 is just relocating your report-check hunk. On the NULL msc->input deref: good timing -- I actually already have a fix for that one ready, from digging into the same Sashiko review on your series. Rather than a guard in the callbacks, I went at the root cause in magicmouse_probe(): the USB Magic Mouse 2 / Trackpad 2 path returns 0 before the existing "input not registered" check, so I moved that check ahead of the early return. That rejects a device that bound without an input and covers both ->raw_event and ->event in one go. I just sent it as a separate patch so we don't duplicate -- happy for you to review, and shout if you'd rather take it instead. Thanks, Jose