From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91D1F3D4125 for ; Wed, 15 Jul 2026 22:18:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784153934; cv=none; b=G+t1wNvIyDtN2sMIBd6kDLAx9k40xppJR0dn6ep6ys1cMRPqAzpE+Q6q+UP8CD/bQKgib7D4wZADm2y8FkR2fnLjhkGWnSxn804tp9PFB0ItjJJH2n8SvvD9afzxWkWYnHcJSuZ6k9c9VmLhqx2Uq7W9IUijD4vwqVJrGSmgX+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784153934; c=relaxed/simple; bh=NziCqKrc157hSlJYPaNb++ltMAq1KP2pbThHesNWW4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pq/Y+Z2MlMkBji8oEcmfpe8Um6neubd4Bb6e/kEwguNw3m7jypOJ8JmY5vOCxY8SAD5ZZ1Nk/ZiZZmdWV+Z306C4OGgLSIrPcszjJQWDVx8+2BeaeoDWXUn8m+00TwoNDIG7DqUfJXZUud0dLUjvZ84Wt0OBan2PKfc8DTz9wpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=azC1PNwh; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="azC1PNwh" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-902e4af2d9dso8702966d6.0 for ; Wed, 15 Jul 2026 15:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784153932; x=1784758732; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NziCqKrc157hSlJYPaNb++ltMAq1KP2pbThHesNWW4I=; b=azC1PNwh580xK0CoWnj5pTdbVGKqfhPkrp9qfjlxBmT4mCJ+1Gf3t68HGnUHUW4a1s C3mNIdUBobLuZ5FVx+F7IpZDVPCZHwIAC3OOEYu16PRY3LDsWRu3MCjo+P9ecA3GH8xn jgdkexLBGzkzThGBrd68EVao/Mq9IfmTsjCcNeQeLz/+vqE81/UaKmoHljkky9pcCsL9 RTtwSHok7hIUBcrcv/9NbG92MyBHgzW0xgNf1e7zjG7ZJi8Tr1P+jvywhpBu1Zqp2Oqs OwdBqk7/aPpysYjhrCI1JN9tkms6Gt8zWiwBcE405+bbmaU/hTX/hN5UGtzuSVSLEjxb mSvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784153932; x=1784758732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NziCqKrc157hSlJYPaNb++ltMAq1KP2pbThHesNWW4I=; b=g7mXC03KjWB4rfs0YkSyaONv87KIUu0xTYBuCZ3VlspNl8GQPxnufLW6EVInzFIPsM Obd105zNY/A+a8sG6PsmXKKEhPLqh/kU9GqbO+cG2IUPCdMc2l7hoVmssEzyq98Lf3mZ Wrnjfr7MLJjyf8/6YD+J7CCmGSUDDRrl8CUE0iZJdYWmAa29JA/oEUMJjcWY7dfCB8Fx zEgL4aZAxkucSb4+GN/SmymbUiVRinbu5y1JrPZqDZpApAGA4ygIs2M+3QRCNzcfqGho JGUjH6Om35VrpfAi/BE1ZPbPDKjtFBIKsjDjbeS2Zd1+cIMxtxjxFCOHcFm9bFn/wWvk HE6Q== X-Forwarded-Encrypted: i=1; AHgh+Rprt5LbOTOeIX2vphbLemgln40R+Xz39dDFiR4UWl3oayYzcO1CZIquHBL2AQ2v+pAGvml6/XlEggIVkaE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzvfy8NgUEdSx9viqOM1E1UzxjXHSrninbQ3Jyv8jyaRrqLlBUZ Muii7uJgWejJzSFogmB7AbynW3Xx0AIOobbFa6RRJe8trhHiB6t+RSbc X-Gm-Gg: AfdE7cngyN4sy0t202AYXEXz0o4wtxgOeOcelsjqFoBqNs5zzNTGCBrtWvGA6EN1Ieb +m9l+19rmmwezDmAdJIaaC7+xnieAvskpkuu+KgUU/ZN/h5hLzu+sRqlIGG4Kaax6SWukwQTYGg TIXzged1lLAvFqCuVTbNwJPsEPj87vwGmVX9V3OKChpmBgs/ItRXTEn/rF8uia/r3fMSnRQOeUn g6FpinuXzKTP5js2elaM653ElwElLr+ntrzXnAm7xYkPTJmPd6HU4awnJ0InyW6YKhSOCUerwOz 7MpCplUDDWk11iYrNm+LoxiSqTv0XKj0tImV5JXscvgQ8mP3z5jlngwnwa5nitLCismbgVNWEah +xJ0DG8UgtZiXI04ledF2FWi/ij7S4WD9loktpS4H0rR7n3ZoJ6Zzr6wbNhV/aoLsKoGY5G/HtW bAUKWtsVbLkkfgJjN9nsULyoc= X-Received: by 2002:a05:6214:226a:b0:8f0:744d:f992 with SMTP id 6a1803df08f44-9076546db96mr15781396d6.24.1784153932377; Wed, 15 Jul 2026 15:18:52 -0700 (PDT) Received: from FairplayBox ([2601:5cf:837e:d920::f9a2]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd57baf8dsm206731786d6.20.2026.07.15.15.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 15:18:52 -0700 (PDT) From: Alec Hall To: =?UTF-8?q?Jose=20Villase=C3=B1or=20Montfort?= , linux-input@vger.kernel.org Cc: Jiri Kosina , Benjamin Tissoires , linux-kernel@vger.kernel.org, Alec Hall Subject: Re: [PATCH 3/3] HID: magicmouse: report charge status over Bluetooth Date: Wed, 15 Jul 2026 18:18:49 -0400 Message-ID: <20260715221849.148886-1-signshop.alec@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715200354.1307250-1-pepemontfort@gmail.com> References: <20260715200354.1307250-1-pepemontfort@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Jose, Great -- doing it in magicmouse_probe() is the better fix. Moving the "input not registered" check ahead of the early return rejects the bad device up front and covers both ->raw_event and ->event, which is cleaner than a guard in the hot path. No need for me to take it; please keep it. I'll review both patches and give them a run on my hardware (Magic Keyboard 2021 and Magic Trackpad 2 over Bluetooth) to confirm the normal enumeration and battery path is unaffected, and follow up with Reviewed-by/Tested-by on the respective threads. Agreed on the rebase too -- if yours land first I'll just relocate the 3/3 report-check hunk into the new wrapper. Thanks for taking both of these, Alec