From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D154C41D4F3 for ; Thu, 16 Jul 2026 12:32:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784205129; cv=none; b=boLZ2FBZBhSSQE6Qc6/Xuyrt4goClpinaXR/t8T6cpTvSfZwNEMCJM+hcTsRuJclKly17naVLyEYwJpw3tBygTHOVdTqAom5h+DoYv3oF4pdMTeDtDAOtuBMj5Frt5eBH8oknh1xWTGpTWmpekWK86CklWrSueXoXrkp7GZwSp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784205129; c=relaxed/simple; bh=V/KoRkaS+83usWGN912iUHUZ0L9VCW5/9FGQG/93XDA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I4zbiQ0h8K6mH9KVTkDhnHhxHq2Tve6pKMntGVdqwuzR5JXnnxQG44xucdYZP2NL3eGaNKw9fslpT6lnQ4AJpDB3uOvAJugCSUo4c7tfZV/aCMhl4XeCoOt7Je9iBRCoqy5Sc9fx8JDXOafYSfes4xl/fObA+bTHzmlmwWAssTw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NzcA/YnU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kbsg++2v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NzcA/YnU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kbsg++2v" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GBj2SH2731890 for ; Thu, 16 Jul 2026 12:32:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9l0T0GCUa4XXTn8B4it8C3G46rwuAieDuTvkXQVUEaQ=; b=NzcA/YnUIFTOOyx7 6f90moPDulXAs6HdrfRjnL8ufIMakApXtUwSx6wEybdv18wjncn1AKp7xMoe/dXB FDlhFvPFLeDp4J4p8u7rfIAwTG1MScJHwOOwnFgmysl/FDfYZ5SrSNE3juIQ/7pp MaMGUEzghiXsUDnT4MGKzBIIB1p1NovjRen1C/gMPEbBiUSRYUEe/58875T/RWcp GXX4l/6MJrWTNzVSiirqEJh7j+WFr7CFT4qgBZQsHvF8hqHhOwQXK7IAJXBMW/I3 jQjiUgyJnZtF26R6zwungofLPQ5Zicsu5MBNc3Ueb7GpytHRdpuMP4/nH+14RG/w BsmlXA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fen4waddf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 12:32:06 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e9a2b95b5so679785885a.2 for ; Thu, 16 Jul 2026 05:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784205126; x=1784809926; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9l0T0GCUa4XXTn8B4it8C3G46rwuAieDuTvkXQVUEaQ=; b=kbsg++2v4SeKksDIMLGqlPmEMsu/5wRQytcoOsw5ptKb6VZY5DvEsHgLupQuYBIsLb Gteh9E3KS78KWbvTzZb4+iMXpOvrlgPHMmZdy3kKu4durRfN1WY4NK4Tuu70i0pBaV5c UURZcdWFaD1kxarVrC3o0R0J3/RCta49FktzhDdv4zt9RTLEF+BLrgMscqB8CBFzD5lD V22JKXRxLF9024q9DXTBdB/R3QrtN07Z6rmDadDjyAwyRgQHXi3KFEiJdw3UVsxmkcFQ h7gXrQBKZCkFd80OfA6gwGy/35vNfJdG2Ryt/ULZVlzse7NVSPSWxXHwxnO0H5UK4Fm5 RRhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784205126; x=1784809926; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9l0T0GCUa4XXTn8B4it8C3G46rwuAieDuTvkXQVUEaQ=; b=iDrO79o48Dph5TLz3L8hEdJw5U7AdsIOgcA2sjQe6ODFYBhB2eJF7IYS9xcQUsbpQX uW14oVbUDx3qXzaZgLCmVZddM/es2IvcRmJ11F4Y5r7CzCU+iethFWTMOg0ZPhKqxPUu /jlAUcNRGF3wMteWYA4YYSwDY0BTyjKs4NWUbpUFgIQEEJ8TrVdgSQhnQ33FskK/BDZ4 U9Zm1zP9VPCLUyWaPn1Qvbz2Eckp4NlMMTYjzhMjNKboZgiDculaWJnVoZNIhVHUuitw r0BBuC2RtgLr2oLOQI+RPuedpSgmwlygd208aQoSfwW9XamqUM6jzviYAsBQJvSnOdtH IAHw== X-Forwarded-Encrypted: i=1; AHgh+RrLS9U95kp7usDIce2x2BFGbUQUe7Zf1vN01XJG+pYsAmeGmDZLbBLTggUG/k5C5Mxrs8vKh0arTOeJ/5A=@vger.kernel.org X-Gm-Message-State: AOJu0YxQEmOLH0acazBrO57HN2di5hjfReCwHWmsW7bnkUdkg099DXkg MkYmjrWa1TC737+5C/Y7jwT5+ELqmitiy8m92oovwJPBIMd0rqoXBtmOy48N5hSVzkawrLvl0Rg PR1LI+ObdxGwMEu37JPjNvfNFhFjU32po8dpG4oKNVzI+Tujmx2ZX7LuHCIq214llu64= X-Gm-Gg: AfdE7cm1DA8E68DuULynoRYrP+qg65yVvonBoIfEVmH0eG41Q2Xrfu7mDk9h9iZUAj3 +3fbbA/ZHTSHmGu2BIYUJObY8tnfGsTKqcXrmmaFGQTW77U/z5qr3JHRjAK88+IU0J+//sLk2AU doXRkSpCvD2vl//+losk7UFgbxL7AglrV18cCRv2EnQRm335YzMK6M8M0NPLRkjVpv3iSj21Bph +WEp1rK6G8JB1H0sLGKkT4z9ATbMm82P7JvwoNClrgTycFqFuRcL9mWAE4+iVuqjoQ+123c2AZJ lmK6P0IAQN/kN5aj1Lsv29csajd15DNQT47NL1TQ9P8VgRkeoOr4dDO2vlAW3ioY0YzEIJXTDKl B5M/SmNzd+VdweZvArK9xHgMCecQ= X-Received: by 2002:ac8:6f16:0:b0:519:f59e:8108 with SMTP id d75a77b69052e-51cbf1601a5mr221555111cf.31.1784205125709; Thu, 16 Jul 2026 05:32:05 -0700 (PDT) X-Received: by 2002:ac8:6f16:0:b0:519:f59e:8108 with SMTP id d75a77b69052e-51cbf1601a5mr221551271cf.31.1784205121589; Thu, 16 Jul 2026 05:32:01 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:76f:d108:485:5b34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464c7c96sm23766635f8f.33.2026.07.16.05.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 05:32:00 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 16 Jul 2026 14:31:37 +0200 Subject: [PATCH v8 2/5] platform/surface: gpe: use platform_device_register_full() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260716-swnode-remove-on-dev-unreg-v8-2-5c2b8cc38c28@oss.qualcomm.com> References: <20260716-swnode-remove-on-dev-unreg-v8-0-5c2b8cc38c28@oss.qualcomm.com> In-Reply-To: <20260716-swnode-remove-on-dev-unreg-v8-0-5c2b8cc38c28@oss.qualcomm.com> To: Maximilian Luz , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Cc: brgl@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, driver-core@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2590; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=V/KoRkaS+83usWGN912iUHUZ0L9VCW5/9FGQG/93XDA=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqWM83p9RhBwshF4v+CF7UXRSRfhDVORsXqTwJU 8v1VZYWbjyJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaljPNwAKCRAFnS7L/zaE w6bLEACeQ+4V/bJNhB1WQ2H6dfrwOUnKDGZwjMD2bpdwuqfEUzAcCRev4jXklTgd3KmKQmjvjJ5 V3bviQgXPe1vcVXP7uUFN79OgQBkLMfH5mKJ62AcgOSKTLmBFYF60GRZ1XMuQkUpRP/Ambd4vzE TaTvXhASUgCDA32nnOTZgkLMvUPoGv5kLBBdOBsUBXGin7coEH2npQP3i8dsVUByeNzfnmmzVys isOEE3p8B4BKITgqM3lZ3dOSqEjGBHyoXvQouFqUgJuoEou30Dk/QYEmb79qDfFl7hbdrITIOgG S+bLySv/eAgRKWYiy20yFKIxiJPzWIFLXt1FhfL0TNnmH6AnV7XNaUH93hbP2OGsngqLePWyVhC KA/Zvzt22eJFPxOgiwvvyFlHxVcqqQ5Ss3OvTXhhBcQa1TKI5nKm/QKZOaBwSm/ADdeVso2VXJO kyI6h1udNzdLEk2RY8ueGxWZXQDO93MXaJDTajfwCcL00Ndx3wlylUSeX30NeIEkZ3wVEBT15ep A8epEbSZnjjNd2P7VgEy0e8Qp+qVu6zAuF4GIwwtOZOshdSxyM6rpOvY3N71NS7IS2ZpLH2kJ7L dIPr9hKSDR5eA9cYQNyAlbPDR05FixCknh3x1NSyMUCBws7Xd7DO0JhORd/gGknYTDtwuKgN9tp c/13CIP8A7ARwlQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=PsejqQM3 c=1 sm=1 tr=0 ts=6a58cf46 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=vKDqCkOE6BQjc6v61vgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: uw00FIUSkEdxwPGa2P3MSRDDgsc86Nr4 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDEyOSBTYWx0ZWRfX4kehJbmTMScC clZnIH1PAFzphr12IdwQWrmzdqbiHIFsIW+yqoWnhW6lZoq2SFoG4Sl6B8+0nzG6OqM1EZaAuGF yl5HQKUInVHq7iMsnnynfLfio+YXoI8= X-Proofpoint-ORIG-GUID: uw00FIUSkEdxwPGa2P3MSRDDgsc86Nr4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDEyOSBTYWx0ZWRfX9ncuTwR5kosH si2kpaSclvcMWH+5fXV1zEbvDaXiUT6Gj7TbhqPpYaZ1sv+vDvqQYx3xgkyL0hfhuJd6yadvHfO cIA/NBFGmFRroQ/5OgDShYuJDomKw7qiIDpxta06h7Vb3a7mowgL+d/o2MtvnOE/U0EaevK/A2O ltlJGBU+xf25FRC4S6Uz3Z3KxjrGa7NF61F7aa1zTLrPfQ6vghSwQTiFqXOc7rRyLPIUpSPOZxs a/CY3mWOcLYE/bwTja16DwLfP1rWvji/r3y432IOZjMiSbBaC8ht8W25ec6+HbcSR3mPwgzmBlp zlO//bmtLXhGCrGM5AO4u9bvZn57EJoWssxwKSGh0CzoVSrj9ROg8MHV7YrWnc221abjRZbOszR 5LQry2BfPXxtKyTrSSxe7oKdcIqcRpInhzbmAkzPczZUIMchtYZCUp1AbVB39hJ64mSBBgQQypQ 4EcajBF2SS0fQgKKVKQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_04,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160129 Creating a software node for a given set of properties and adding it to a platform device can be achieved with a single call to platform_device_register_full(). There's nothing in this driver that suggests using the more fine-grained interfaces was intentional so switch to using the high-level helper. Acked-by: Ilpo Järvinen Signed-off-by: Bartosz Golaszewski --- drivers/platform/surface/surface_gpe.c | 39 ++++++++++------------------------ 1 file changed, 11 insertions(+), 28 deletions(-) diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c index 40896a8544b0a4da4261ea881b1eaed62d93b32b..4ca7ad76f3b9d2b6c455a5d5b37f23a85eb69c69 100644 --- a/drivers/platform/surface/surface_gpe.c +++ b/drivers/platform/surface/surface_gpe.c @@ -290,9 +290,9 @@ static struct platform_device *surface_gpe_device; static int __init surface_gpe_init(void) { + struct platform_device_info pdevinfo; const struct dmi_system_id *match; struct platform_device *pdev; - struct fwnode_handle *fwnode; int status; match = dmi_first_match(dmi_lid_device_table); @@ -305,44 +305,27 @@ static int __init surface_gpe_init(void) if (status) return status; - fwnode = fwnode_create_software_node(match->driver_data, NULL); - if (IS_ERR(fwnode)) { - status = PTR_ERR(fwnode); - goto err_node; - } - - pdev = platform_device_alloc("surface_gpe", PLATFORM_DEVID_NONE); - if (!pdev) { - status = -ENOMEM; - goto err_alloc; + pdevinfo = (struct platform_device_info){ + .name = "surface_gpe", + .id = PLATFORM_DEVID_NONE, + .properties = match->driver_data, + }; + + pdev = platform_device_register_full(&pdevinfo); + if (IS_ERR(pdev)) { + platform_driver_unregister(&surface_gpe_driver); + return PTR_ERR(pdev); } - platform_device_set_fwnode(pdev, fwnode); - - status = platform_device_add(pdev); - if (status) - goto err_add; - surface_gpe_device = pdev; return 0; - -err_add: - platform_device_put(pdev); -err_alloc: - fwnode_remove_software_node(fwnode); -err_node: - platform_driver_unregister(&surface_gpe_driver); - return status; } module_init(surface_gpe_init); static void __exit surface_gpe_exit(void) { - struct fwnode_handle *fwnode = surface_gpe_device->dev.fwnode; - platform_device_unregister(surface_gpe_device); platform_driver_unregister(&surface_gpe_driver); - fwnode_remove_software_node(fwnode); } module_exit(surface_gpe_exit); -- 2.47.3