From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9850BBE63 for ; Thu, 16 Jul 2026 00:04:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784160268; cv=none; b=Nfk+LUoUIIVvubB8BJ2DXf+w5OYmdXI3WAtahiOuSsqPmUcvpJestMEDsgd0RCyq77G40IacjyGQh/tnpZUHj6lfOSg6WuWmEXhYG4PvrkV7SzH/HbkkkFSfY+mbhQBEF12XwWXpFCbsNF5v5qliIwRfybiCnb2MvIlGF7jlJMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784160268; c=relaxed/simple; bh=cjSbt+GVSzgutghVrfQP8/3UXe81/EKamqssfS+Gc+Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nrARcA/XlP6ckgYYKkLMHGtx3Nd2Rv6WJ9Ry8oMCyOkPJuI4pgwIhXgsJ0V7Lc5/RvW7luvxqwGmvrRBbIiQIHGDXryjeGyZkr4/MYPNW9W3iWTWLLSXrfBjX2DlQIf26taxC60dRVFcpgDtfau4P9kc7XTpvaC6loQRe49KO6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q7gymfd/; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7gymfd/" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2cc6dd436c6so32909535ad.2 for ; Wed, 15 Jul 2026 17:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784160265; x=1784765065; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=z1kBdUU9x3GgTo7sRVI3Isnfl0f5gHbcdHM43ihRGMg=; b=Q7gymfd/NIpqd3fZoID/tMaf3eXJRddw0YqlkK//DLSU3HtSA5Ce02Et5caxJ58hAz uOKkcqXHzxwCTtpHz43s7N0npxWdwM8i+uTt1kCeYPxo03ZdVcES5SdlodcFkBSAcoU1 yjDiPNZoNn3OxbJDtB1seMnzzfgXPm9NEBH+ScslapduFrh/yIKQNWteMUoNxV/WtQ0k Jybju0fZFR6doBK3TVLoPLm9EU7Akb4Q7VQZBNYey8dA/6Lgg2/c2h0mwNMjt/3V79jY 8kmpXs3Y7tniZhd9A5DLKyo/wkY0rKLW/ysuO1oBRsXnVdHvf+AOv5aMwc5ecCc3iaTo ve9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784160265; x=1784765065; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z1kBdUU9x3GgTo7sRVI3Isnfl0f5gHbcdHM43ihRGMg=; b=CP6X1yixruOPMXobUX4cShcxnIeqFdaJPdVZqBWgpNNwUTgkZ8nZyQpdblkfo+Q1DW kyVtKXS9q9AdxqRr0cCW7vftHNOHjkC8BnVnW//TbzCprlRwUwicDluZJyXX/N6pnpQJ +9e54eEWGCqKP2e2PPbDcHJVvHQT0MlSziIVVb8Hxi7asKtnrCGh9r6ghqL5eo+01IMY 8lUq7shAmwsXP8wugDF9wHapBabzGLmOzK96zHMSFiDu6QG7qn2hbj6xACSfWqW9XJI/ bYlf7dmCn7YrilGbNhJ/cJwdI49URQIi84l9qA02l+xOsfJEKwKgcHXT8uIK2z+Mt+fw qaqw== X-Forwarded-Encrypted: i=1; AHgh+RrzdS5/RLqgNHSF99ykFR23rIVgmn2jJ+zR6LuXPAGa2SwKpw1OvsreEMlTzkT5Kbw9LLzHXGj22u6+LI8=@vger.kernel.org X-Gm-Message-State: AOJu0YwGefjwssxkTRSilMiXALbHydHrJ8XYgtHm2A0phAi8YKm0tAtz SG5EBzMlayPtUsJ3Z///3TyV4ozlHTb/S64uc8smGPmwqxWkVg9AEl+p X-Gm-Gg: AfdE7cmJVHau90zyUJruV4ETx7/7xKq4UDhDQVUcGaegEjKDI5vxxzoG894xsH9KAgb hrJWCHom46U8/wIsc1hDhRV8Yabmm16PJ30/iotqlmaPkZDtTkHvu/X8vI8yGnb91sVd28XPpMe 2pr9tk9rjzRFQjqSPN9DSL/uSpXKw4kk73pAekvrlrXfUYqLwYaeZIBbAhN65QHZd4l9lMvCMMS zON4rlBjnK53K+yq9k7Y3zKSFL7cFff442IAUHWTCEkWZPkd7uE42Y38eveAuT5dModjRI0DXcW Ggvny8f3f1naeMtD4MywjhtgYQOlG9rTbIetvtMiZtSg7VLpQRFZByHFx0/tSye55I2HSTSifS9 nn2/S7LE//M43cQulsDqXQ3pRYBlpvuUiIr1ErqFAoBnxtWIqgvcNBbRmC5KMOVuEblKzR0Dwhd /3tp1W9rht7MOOFcLjqqunn4spA1IVhZMQut8on+IUJtgXLm+Z+aB963mYKn1Vag09CIZbZ3aO0 A== X-Received: by 2002:a17:902:d2cf:b0:2c9:97a8:aff4 with SMTP id d9443c01a7336-2ce9f3d8422mr191906295ad.45.1784160264802; Wed, 15 Jul 2026 17:04:24 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::9dab]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf1055f193sm10177695ad.46.2026.07.15.17.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 17:04:24 -0700 (PDT) From: Ivy Lopez To: peterhuewe@gmx.de, jarkko@kernel.org Cc: jgg@ziepe.ca, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] tpm: use kfree_sensitive() for context and session buffers Date: Wed, 15 Jul 2026 18:03:55 -0600 Message-ID: <20260716000355.13825-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The context_buf and session_buf fields in struct tpm_space contain TPM context blobs which may include sensitive cryptographic material. Use kfree_sensitive() instead of kfree() to ensure the memory is zeroed before being freed, consistent with how chip->auth is handled in the same tpm_dev_release() function since commit c424d2664f08 ("tpm: Use kfree_sensitive() to free auth session in tpm_dev_release()") Signed-off-by: Ivy Lopez --- drivers/char/tpm/tpm-chip.c | 4 ++-- drivers/char/tpm/tpm2-space.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c index 12b7394b34bd..6f16fc358175 100644 --- a/drivers/char/tpm/tpm-chip.c +++ b/drivers/char/tpm/tpm-chip.c @@ -244,8 +244,8 @@ static void tpm_dev_release(struct device *dev) idr_remove(&dev_nums_idr, chip->dev_num); mutex_unlock(&idr_lock); - kfree(chip->work_space.context_buf); - kfree(chip->work_space.session_buf); + kfree_sensitive(chip->work_space.context_buf); + kfree_sensitive(chip->work_space.session_buf); #ifdef CONFIG_TCG_TPM2_HMAC kfree_sensitive(chip->auth); #endif diff --git a/drivers/char/tpm/tpm2-space.c b/drivers/char/tpm/tpm2-space.c index 60354cd53b5c..a7200e6dc462 100644 --- a/drivers/char/tpm/tpm2-space.c +++ b/drivers/char/tpm/tpm2-space.c @@ -46,7 +46,7 @@ int tpm2_init_space(struct tpm_space *space, unsigned int buf_size) space->session_buf = kzalloc(buf_size, GFP_KERNEL); if (space->session_buf == NULL) { - kfree(space->context_buf); + kfree_sensitive(space->context_buf); /* Prevent caller getting a dangling pointer. */ space->context_buf = NULL; return -ENOMEM; @@ -64,8 +64,8 @@ void tpm2_del_space(struct tpm_chip *chip, struct tpm_space *space) tpm_put_ops(chip); } - kfree(space->context_buf); - kfree(space->session_buf); + kfree_sensitive(space->context_buf); + kfree_sensitive(space->session_buf); } int tpm2_load_context(struct tpm_chip *chip, u8 *buf, -- 2.55.0