From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814223B9DA1 for ; Thu, 16 Jul 2026 08:39:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784191149; cv=none; b=QthUnO0PQjWNJbyEibe7ffCJmvmgJCe3zNLVKu9PwEPBrl5iblcXITib4ZsyBbY2zJ/Klbz8/BPBW5ogBGPUuLUYeBx4mZ547t0FsPA1n9SsuMF+/wmfKIf1YuYp4IUbFUshG1kvOTW70/Xe+pm5Uj2NXEuHv/YGjRFFAOENvV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784191149; c=relaxed/simple; bh=6w1aFKENJ6dw0MgnMkbvcdMXN9gjX/3TR2mc0pCoG4o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UeGZ40xfIC+7YarjawXVNF6piZy07Ifj4lduDyGdtNveZSlfAipVi4lMeHWI2Ohk5BWko+2lSw8m2jOZEjTJetiRmLkDlX93LlmqC/Q+IFo8YqqgfcGJwbP/5wR94KpBzjRgdPHfGWGdsrveWej3P7H3TVHMOTUzfAj/iS4+HgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nIV0vf8B; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nIV0vf8B" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5aeba09900bso2329609e87.2 for ; Thu, 16 Jul 2026 01:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784191145; x=1784795945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fSN7+6Fal8dugoHe5tu1FqihQojJTmJBwjlyE5PG8WU=; b=nIV0vf8BzK2mLZoHBbxR89Liz5+TEg7LHgIM7Y4KRhuMgd/mwXQq3htjc6yMxXtyh8 T5aPGGmIVlGa8fOTD/sSlPx2+NpBsrm3K7+r4AowokHKm0xI1/zMzqy2denQ1tAZPN3x lKdDYiFw6Ig2hMaIAN7SVwUfK/nucIn1LBBh/2MdNbvBA5ejDcDF8Opo4jhIWZ+Km0Po UImNI8WM4sZx6X+fumKJ/VZa9cPDGt4Iap5q/TdkQAWZm54V2ZGHekqbXKzPpjrh+37/ vsb81GGpMJHQGnLiZK0v+daAYH0L0Eni2q8zdYF3nHRX9odC+Jdc9FmMWXLK/HkAIOLd aFXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784191145; x=1784795945; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fSN7+6Fal8dugoHe5tu1FqihQojJTmJBwjlyE5PG8WU=; b=ayjXrgs0UUj7u5wv4zH6GYJ1wgUPe6WSyHQOdr57dXqDXlp5JZblQ5pFvmN0NDvnaF WAt8h6v5WeyMbM/t0xkBQuz+KmBeuGlV9xZyCV5uOrr6bUUqVhGigy5f7iy563ZyFiz9 X9Z0L1h9AsULun5tmdIcMzx3kkP3C/WpTm9rW/0+qVvwHizA7fNCursj3zsjzIpmTQij HIUx3OEGIkGanw3IfPI2vWPUfaDDlTr9AdaiaiGkWwV6oSmbTFDdyVAItTFYAd6Qt2NS GjUBFWCuJLy2ccfjCm+u9tpHK9Ghrkwv3Zyt6m++TIQHfpMPKf/rftqyZcKeMcJnilTz b9AA== X-Forwarded-Encrypted: i=1; AHgh+Ro1HSOMVhKG4hGrnqd84K71BUKVvTC9fJGxI6QcfdKLgj7dcC2uoHeUwC+V4hFi9dzT6bJQWB9p4lh/xEA=@vger.kernel.org X-Gm-Message-State: AOJu0YysLAvG+X/lkvWxV4uxJMskhb2AKUBbPpsHNgUDz/q86DvgNsZ+ paKEtWW0u2Qpe6NgX251xI3qp/oQHjISPyrkfUXX3HL0PQT1u+DigFBm X-Gm-Gg: AfdE7ckIxBskd3ZNKlAeLWJjsgsne7aSchXyQNRTvHnwJzKvtt0XPYFXqI6mtSYZe/7 DJUIdO59REkP3ruqgO9QfZITfKUqZDbTvfS4VO2LT/gXSZ8+3kcUrafPaK2g3kNAMWwGfiXInjB 9SORj7cmhKfKowA4Ujq5XKho79wtMyHD3+qUwmiZVF6OF3+/rIdLwGZp/M/ikAaAw9jyBkWz9YS IPeCtIvcqVYM/axLV5ALCpEl+JQwgAJNgxYIqIUswrBtGCn+gPH6esX6TzVN/n5yLdvyxdh2BMO kMeVKdhpUf4TRF3CdZhOxpT5AXp1/r5mlN4k9DJLcXMtPzQS/T0PkO+8Ca+dPxN1tx1fotGNr40 4zYzkXZbH7onQ0gUhS0puBX2cfhrnxOdmehMmcpBnpaLgzsZtW1JG47adoWBQcFKMs2pKLQwyel tuwUL/bp+0p1ejAnji3k4bQJBSQKU= X-Received: by 2002:a05:6512:6699:10b0:5ae:ba93:9116 with SMTP id 2adb3069b0e04-5b02356142emr2946023e87.2.1784191145229; Thu, 16 Jul 2026 01:39:05 -0700 (PDT) Received: from DESKTOP-PGTNBU2.localdomain ([178.131.96.94]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b01ca4f90csm4865554e87.21.2026.07.16.01.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 01:39:04 -0700 (PDT) From: Amin Madani To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Amin Madani Subject: [PATCH v2] staging: rtl8723bs: Split multiple assignments in _rtw_open_pktfile Date: Thu, 16 Jul 2026 12:08:22 +0330 Message-ID: <20260716083822.2898-1-aminmadani112@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In _rtw_open_pktfile(), multiple variables are assigned on the same line. According to the Linux kernel coding style, multiple assignments on a single line should be avoided. Split them into separate lines to improve readability. Signed-off-by: Amin Madani --- v2: Assign pktptr values directly to variables instead of chaining them, as suggested by Dan Carpenter. (https://lore.kernel.org/all/aZ_0OratIkUBNHmy@stanley.mountain/) drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c index 4260ed5f4..ea60320c0 100644 --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c @@ -15,8 +15,10 @@ uint rtw_remainder_len(struct pkt_file *pfile) void _rtw_open_pktfile(struct sk_buff *pktptr, struct pkt_file *pfile) { pfile->pkt = pktptr; - pfile->cur_addr = pfile->buf_start = pktptr->data; - pfile->pkt_len = pfile->buf_len = pktptr->len; + pfile->buf_start = pktptr->data; + pfile->cur_addr = pktptr->data; + pfile->buf_len = pktptr->len; + pfile->pkt_len = pktptr->len; pfile->cur_buffer = pfile->buf_start; } -- 2.53.0