From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CD825F984 for ; Thu, 16 Jul 2026 18:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784226186; cv=none; b=RTLZ708M/Tp4ppA3VPwoYT8D1FatdWpXJk5wrNYfpSpiNKrCKgGDSY/ZWAGOQWKtfMJ2QFJZh/lJSTN24V8jgxn4tHi/lTjZ7+wiWLOEKwGhZXTUlSaDH912MZdqtjUcS1USt2Un+fuQR9bLLDQCdvDTMWtWYqE7o/gzbCRf4a0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784226186; c=relaxed/simple; bh=2YFErkEfWTid63HWff5+u2dUjlWzOX6GXTUxwvfYZsA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=eMIeq1zZ+cYoNz41XZwvOwXwmfg6zaodKTQqYNJD8eXnyZ132Y76dnqCRDuNHbK1zhlGlwnZTAfdLZy2jaH/yQnN1nXdgW2TUr5Ht9hbdvybFb+yXSwOxGho5MIIV4q4wO2NFZOtfxQ89SHcmDWz3Z5MuSS3uS0e0MZHgrutYmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q3O2WFrp; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q3O2WFrp" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ceaf8a1265so64547825ad.2 for ; Thu, 16 Jul 2026 11:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784226180; x=1784830980; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ttGVBBLV5S7SFqtsKUPChZqO8zfT3Rb+MVyL1uhuCco=; b=Q3O2WFrp4ldbolWwLpD37HPl+i7lc7rjMXtXjZ/yxkjuADA2TjXmge+IZ41Hqa8oLE DCmYeJi/DCdQEREgkQHXfueB/0AbCsckygIzW08mF3QfAXjtxz3DVY3Czwtl9iDDgIei ZTewPLAmniqikBW1qBf0Yua9zsIkOQf+kno2iRvhzi96m/RvG2u7nmzdw6BcsCxmBi0i 8bnfQavoYnqmtv2Rh1BOiwu809v5VQzsGtpwhQMVQVNmAfndb+ngpfsIy4V4XkhCfPMz ghek5covdzFDWmmgPUEPeH7T+eUM8jjKuh5qJSB4j3wiHmQsOJzF76Wa7gsQ3AxnlsPN b8Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784226180; x=1784830980; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ttGVBBLV5S7SFqtsKUPChZqO8zfT3Rb+MVyL1uhuCco=; b=Lpv6f4VvlmPegiPOIUjv4mVY8udHqVg54Cm1xBmA5zCeZ0O9LT7xVLOPI8hCEA9PPL c6BhrTM66TeAeRTBSx4Xyzkdm+AyfPkGFGwcxX7McUHIyFbYu8uASd1MrmDMn1fx/Exb sc2smjWYECiM4f8bEkZFM7kQtmJVAVSocU775FmEQp0SXluijjo/sMAf7ktc6JlI8QZ6 r7H9Xy1mdWl5bRpRHX2ucQzEEXNQmdcgHF/ZJxv94jYLJMzA9bSwnygP3nIksUSOAyZE fe9BZ5cFAoegdKljYg2MCxqwtJGcxuxk0gZdNklIexs1N5ZQ3m+kskehKCVHzgi444ag TfDw== X-Forwarded-Encrypted: i=1; AHgh+RqP959U7zpF6HHAFsYIst5+5R+pVODj9x3nEM8zknyaKGlDvoJttEjFN+QE9ZwPwXyLVp1AK71XJGDOexk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6z0r67myUm7ONa82xvzwP7iWexAKyULzZWjIlGbyYMfx5O1Wt yfT3lCRf/dxBDu654SS6dC4MNHMJToC+IMrM1aIhsaky/cP8QBg6phud X-Gm-Gg: AfdE7ckfm9WM76D6UODQ2xdukgPaSPAP5QDyzOsaWxuGGvFWsLRaFn6aC9SZBeQjQwH vBM8+v74nCI2Xq32n+7WquinT7sqrthNIBEOELypxF9cs9Uj2Yymgh/MNQ8kfuXbGSBinzUorUa ZfFYfE5iTRTMMnDWfAUwifrBhmyiqasgqb4rV6Svd6s6ct5ITCkyMPgR2ELwkwK4ku6SQvdZyUe +OHqD1JuMUfOH2HacChAfnoyx8zAxqCNfS65Wp0Gg1oPRgdtIbH0bITXTACbSg/Uu4W/P0VGOtN fv6S3nsCngZGF0KHxjSy5mponSJEVpePMJHii4TwB39hO1MFDdMuP+Tfz35T10Qb+RcOUDV6D5V Q6vDYpWi1CUXE/aB3EPx13DMAydfpNPWHCpHeYq4g4yJ4dhRBmporPqglpJV3t3gJR5AhhltuIV AzrJ67HyeMMUqPhdyUcenFtsw= X-Received: by 2002:a05:6a20:d486:b0:3c3:9c95:c0f1 with SMTP id adf61e73a8af0-3c39c95c1afmr2292536637.41.1784226179955; Thu, 16 Jul 2026 11:22:59 -0700 (PDT) Received: from localhost.localdomain ([2409:408d:321c:1213:a9ae:1111:f32a:a657]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3141dc5154dsm4066939eec.7.2026.07.16.11.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 11:22:59 -0700 (PDT) From: Arunachalam To: Lee Jones , Pavel Machek Cc: Andreas Werner , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Arunachalam Subject: [PATCH 3/4] leds: menf21bmc: convert to dev_err_probe() Date: Thu, 16 Jul 2026 23:52:47 +0530 Message-Id: <20260716182247.9449-1-arun07172003@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace open-coded dev_err() + return pattern with dev_err_probe(), which also handles -EPROBE_DEFER correctly. Signed-off-by: Arunachalam --- drivers/leds/leds-menf21bmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-menf21bmc.c b/drivers/leds/leds-menf21bmc.c index 6b1b47160..a7e4db487 100644 --- a/drivers/leds/leds-menf21bmc.c +++ b/drivers/leds/leds-menf21bmc.c @@ -84,10 +84,8 @@ static int menf21bmc_led_probe(struct platform_device *pdev) leds[i].cdev.brightness_set = menf21bmc_led_set; leds[i].i2c_client = i2c_client; ret = devm_led_classdev_register(&pdev->dev, &leds[i].cdev); - if (ret < 0) { - dev_err(&pdev->dev, "failed to register LED device\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "failed to register LED device\n"); } dev_info(&pdev->dev, "MEN 140F21P00 BMC LED device enabled\n"); -- 2.39.5