From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E4E93B0AE3 for ; Thu, 16 Jul 2026 18:23:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784226205; cv=none; b=gDnKNN8qsn0/y0x2vPO1f9SmwMuR/bCl7EZV+6yQD++FqLqEIyZHC8x7CZbI14CWyvmoNdqaKXodSWnoWvhnk7IGCKd3ZOhoOjNB3zK67NR10Y37EMn3e9mfr23JN3vmKrime1sijd1N/NYw00R1va9c7GTZtBpH1F+AsRiLZo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784226205; c=relaxed/simple; bh=SxMJKKHIjLot1MKxc4madisP7myfnRxTH7Li813XyLI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pI/dVTN8vqK4lopypPJpHs1Vy2r4rypuCMxQ8BYzhgTe6HaMlfMI+ALPIkFvWI7Em2WYXSTSO2o1limsAi//3i2QyM2lC5xsJRmUkSzrWKHIFi1unwn3axuFjTTQQ63w9GppK3x5hQ2kub71unObjd++fdkx/PlOwa8D6+BedHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=alUmGiWS; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="alUmGiWS" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-383cb94f742so6624238a91.3 for ; Thu, 16 Jul 2026 11:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784226195; x=1784830995; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YqS6+/NhYi/kkkz81wwm8hdbXSRvuTlEop7nHW08UoA=; b=alUmGiWSRW1YfLVPZxWgmCZmSA4yf6nxGrFKzE9ACZQMvRw0zBkeyFOlRFtuHyFRCA qcs8f+ldtXy762zDZFZEQ8X+Pg6bbqcAmzaKo8VBeS4Y/eM3savr6/6hvqMF5/d1x48u yK9LE2vl2EPJ8OozKTYartdHAPZcPT8ehdUwSNNZJ+3wvXju39z14vFC7ypzyXQVQlHp 8rIM9v/UYVIZn4ehU2JH6LJoXejfv9PRNd1rV5xnBbkF6bRGrgoT/ZD5My3Iqsfl/1HA VEdVX15zECtlXQ8BRXeidbWmVXpuaRH5zo81WR35fHs75R67rmKr6Ckq6mT8CE9ISQA1 2knA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784226195; x=1784830995; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YqS6+/NhYi/kkkz81wwm8hdbXSRvuTlEop7nHW08UoA=; b=POJV7S8NIXSNz8+ECkrcyENlZp2NawEzFNpCLeTjSHu3MyoGnA5t1H/E8TMyGg0reJ cDuDBUsbHJ8xLrz7aNB0+rb7boYbT5nRL+9niBdmaWiEN20wttYGJO+ad1NHI8jjvb35 fxhJBmQkuPapplwadBUjayBLp503HwqWP/ucWTuENbW5MsEA7O+J3gJ9pGEeoWnU37u/ CKAN4h2Q96q7BAY6DKnFaVYQcRhxb2Onp9Db7TUgGx/MHnEdTQjnK55Q8y/dS0o22mCc BxJ66jm4HbTE6NM9CULG1eJ5Q8fwBnznpk3oOSlwIfI5+9rvPGpzgr0dcRe/4isXQ75T 83UQ== X-Forwarded-Encrypted: i=1; AHgh+RoSpV/ssb7ZlR7ZHJh4l9/Iljjvo0yv/syi7s0Fnkti2Q6ybcs9L9iSLVQySCAls8Re/qsdPSOoSMdyios=@vger.kernel.org X-Gm-Message-State: AOJu0YzqVbCnM0FhlycCIqVpSDfs7CcGOrg0ODzsoeGWvFCdaXGUtAYk dO7W/R8puSrI17GJKTwi7Q2aqO8KNEQp420MfeY8vfCJYVtXY+NjBkBo X-Gm-Gg: AfdE7ckRrQTYh/EyUWxyw92kJSQG+0A/zA8zMaGUkT40SidGSa20/m2HUe/0zPWKsAG 17oynyCpUFzqcEYDGkaOhxUbj50A5evoF5WBI/gd2SN7tmov6H2/xZnKCPv4EaAdagj3rw63XUI dZe+BN6ITDyNn717aq2JoipcIQrEcd+mNdEuXW+HKxR3KwzecS1SgELB95XrSnfV3F5lP3THfSB qh8mHI71kfwLkk0S+YKOfNEKEKAtP0DB+8IszIndIP8jGL8xtqzP4NCZ0mREMtwHhEqhNtypCrf OP6ILnWqBybKodgGvBW93IAOUJid8igklBvh6ZbeQ9Wg1IDVKKUvdPsfMU/gRS2aFDFPF5DOrJV tVOr9o2H+p/SIimxj1Syedi5MNI9Q4DkSIFNl+eMZwo2OEUytyuVMq7W1P9CHGZOOOae18R3pUG iWz9/GSMPTTcFcUnYc/P8PcZs= X-Received: by 2002:a17:90b:3f84:b0:37f:e326:6559 with SMTP id 98e67ed59e1d1-38e2a0c3460mr7581581a91.22.1784226195108; Thu, 16 Jul 2026 11:23:15 -0700 (PDT) Received: from localhost.localdomain ([2409:408d:321c:1213:a9ae:1111:f32a:a657]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3140e6f0dcdsm12137148eec.31.2026.07.16.11.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 11:23:14 -0700 (PDT) From: Arunachalam To: Lee Jones , Pavel Machek Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Arunachalam Subject: [PATCH 4/4] leds: 88pm860x: convert to dev_err_probe() Date: Thu, 16 Jul 2026 23:53:03 +0530 Message-Id: <20260716182303.9467-1-arun07172003@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace open-coded dev_err() + return patterns with dev_err_probe(), which also handles -EPROBE_DEFER correctly. Signed-off-by: Arunachalam --- drivers/leds/leds-88pm860x.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c index ef5c6c466..65f2af134 100644 --- a/drivers/leds/leds-88pm860x.c +++ b/drivers/leds/leds-88pm860x.c @@ -152,16 +152,12 @@ static int pm860x_led_probe(struct platform_device *pdev) if (data == NULL) return -ENOMEM; res = platform_get_resource_byname(pdev, IORESOURCE_REG, "control"); - if (!res) { - dev_err(&pdev->dev, "No REG resource for control\n"); - return -ENXIO; - } + if (!res) + return dev_err_probe(&pdev->dev, -ENXIO, "No REG resource for control\n"); data->reg_control = res->start; res = platform_get_resource_byname(pdev, IORESOURCE_REG, "blink"); - if (!res) { - dev_err(&pdev->dev, "No REG resource for blink\n"); - return -ENXIO; - } + if (!res) + return dev_err_probe(&pdev->dev, -ENXIO, "No REG resource for blink\n"); data->reg_blink = res->start; memset(data->name, 0, MFD_NAME_SIZE); switch (pdev->id) { @@ -203,10 +199,8 @@ static int pm860x_led_probe(struct platform_device *pdev) mutex_init(&data->lock); ret = led_classdev_register(chip->dev, &data->cdev); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to register LED: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "Failed to register LED\n"); pm860x_led_set(&data->cdev, 0); platform_set_drvdata(pdev, data); -- 2.39.5